I've noticed there is a Notification:resetNotifySource() call on line 1202 that is inside the for loop which is probably related. Does anything need changing there to guarantee it gets called (if needed) or is the for-loop always guaranteed to have items to iterate?

've noticed there is a Notification:resetNotifySource() call on line 1202 that is inside the for loop which is probably related. Does anything need changing there to guarantee it gets called (if needed) or is the for-loop always guaranteed to have items to iterate?

Good point.

Since there's no other notify call, you can probably just move it at the end of your new branch outside the loop (i.e., setSource => Notify => ResetSource).

Or, well, this can be simplified to a single notify call with the source being passed to the Notify call itself directly, if there are no longer any other notify calls.

By which I mean, if there's only a single notify call involved, just pass the proper source to it directly.

The whole bracketing thing is only necessary when there are multiple notify calls involved.

The whole bracketing thing is only necessary when there are multiple notify calls involved.

Which, actually, there might be... inside whatever the dispatcher actions are going to be running.

So, TL;DR: ignore most of my rambling, but, still, good point, I'd reset the notif source outside the loop, but after it.

The whole bracketing thing is only necessary when there are multiple notify calls involved.

For example, when a profile (manual or auto triggered) has multiple actions?

Closed in favor of #13078. Thanks.