[Common settings] remove screenshot setting from unsupported devices#12293
[Common settings] remove screenshot setting from unsupported devices#12293Commodore64user wants to merge 1 commit into
Conversation
|
While this setting is of no import, they can take screenshots perfectly fine through profiles. |
|
Didn't we also keep the stupid-ass default Kindle shortcut for screenshots? (Which I can't even remember given how stupid it is. It's like Sym + something + something). |
|
That's covered here. The exclusion considers it. But in any case, I'd rather just keep the setting. koreader/frontend/ui/widget/screenshoter.lua Lines 138 to 150 in 949b996 I think profiles doesn't have the ability to run an action in x seconds. |
Oh well, this makes absolutely no difference to me. I just thought it would be better not to give false hope to hasFewKeys when even with the Profile trick, is not really "perfectly fine" to capture them. At least in my attempts i could not hide the Menu which meant all screenshots are half the profile menu (to trigger said profile) and half whatever you want to screen shot.
There is actually a reason for that. If you |
That's also covered by what I said about the timeout, although that was more about capturing different screens. You could update the PR like this (or close this one and start a new one): diff --git a/plugins/profiles.koplugin/main.lua b/plugins/profiles.koplugin/main.lua
index 768518f97..ca356f742 100644
--- a/plugins/profiles.koplugin/main.lua
+++ b/plugins/profiles.koplugin/main.lua
@@ -124,14 +124,14 @@ function Profiles:getSubMenuItems()
text = _("Execute"),
callback = function(touchmenu_instance)
touchmenu_instance:onClose()
- self:onProfileExecute(k, { qm_show = false })
+ UIManager:nextTick(self.onProfileExecute, self, k, { qm_show = false })
end,
},
{
text = _("Show as QuickMenu"),
callback = function(touchmenu_instance)
touchmenu_instance:onClose()
- self:onProfileExecute(k, { qm_show = true })
+ UIManager:nextTick(self.onProfileExecute, self, k, { qm_show = true })
end,
},
{ |
Mainly a difference without distinction, but in some edge cases like screenshots it keeps the menu on the screen. See <koreader#12293 (comment)>. The "Show as QuickMenu" is really just for balance; it makes little to no difference.
|
I took care of it since I was already looking at it. |
…12299) Mainly a difference without distinction, but in some edge cases like screenshots it keeps the menu on the screen. See <#12293 (comment)>. The "Show as QuickMenu" is really just for balance; it makes little to no difference.
|
since the other solution didn't work, would you reconsider this now @Frenzie ? |
|
Okay. |
|
You can reopen it then, (i can't since you closed it). It's rebased and all ;) |
|
I can't. It says the branch was "force-pushed or recreated". Please open a new PR. |
…oreader#12299) Mainly a difference without distinction, but in some edge cases like screenshots it keeps the menu on the screen. See <koreader#12293 (comment)>. The "Show as QuickMenu" is really just for balance; it makes little to no difference.
removes
screenshot foldersetting from unsupported devices (i.e non-touch bar kindle)This change is