Profiles: make sure to close menu/quickmenu before executing action#12299
Merged
Conversation
Mainly a difference without distinction, but in some edge cases like screenshots it keeps the menu on the screen. See <koreader#12293 (comment)>. The "Show as QuickMenu" is really just for balance; it makes little to no difference.
Frenzie
commented
Aug 5, 2024
| UIManager:close(quickmenu) | ||
| Dispatcher:execute(settings, { qm_show = false }) | ||
| UIManager:nextTick(function() | ||
| Dispatcher:execute(settings, { qm_show = false }) |
Member
Author
There was a problem hiding this comment.
Actually why is this Dispatcher and not self, anyway?
Member
There was a problem hiding this comment.
Maybe @yparitcher emphasizes that there are no instances but one and only mighty Dispatcher?
Member
Author
There was a problem hiding this comment.
Haha, maybe. Anyway, I don't mind.
Member
There was a problem hiding this comment.
IIRC when i created dispatcher it was to show that it is a singleton, (also that was my first big contribution to koreader, so was still figuring out lua) this style is throughout the whole dispatcher, I didn't use self much
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Sep 9, 2024
Fixes koreader#12447. Regression in koreader#12299.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…oreader#12299) Mainly a difference without distinction, but in some edge cases like screenshots it keeps the menu on the screen. See <koreader#12293 (comment)>. The "Show as QuickMenu" is really just for balance; it makes little to no difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly a difference without distinction, but in some edge cases like screenshots it keeps the menu on the screen. See #12293 (comment).
The "Show as QuickMenu" is really just for balance; it makes little to no difference.
This change is