Skip to content

Ability to combine multiple response projections #985#1031

Merged
kobylynskyi merged 10 commits into
developfrom
985-combine-multiple-response-projections
Feb 22, 2023
Merged

Ability to combine multiple response projections #985#1031
kobylynskyi merged 10 commits into
developfrom
985-combine-multiple-response-projections

Conversation

@kobylynskyi

@kobylynskyi kobylynskyi commented Feb 20, 2023

Copy link
Copy Markdown
Owner

Description

Related to #985


Changes were made to:

  • Codegen library - Java
  • Codegen library - Kotlin
  • Codegen library - Scala

@kobylynskyi kobylynskyi added this to the 5.5.1 milestone Feb 20, 2023
@kobylynskyi kobylynskyi force-pushed the 985-combine-multiple-response-projections branch from 1c184f2 to 5a5a30d Compare February 20, 2023 02:09
@kobylynskyi kobylynskyi force-pushed the 985-combine-multiple-response-projections branch from 70d3bbf to 1a5bbd9 Compare February 21, 2023 02:01
@kobylynskyi

Copy link
Copy Markdown
Owner Author

@jxnu-liguobin
I've made some changes to kotlin/scala .ftls and would appreciate if you take a look at it and possibly make some adjustments too.
Thanks!

Comment thread src/main/resources/templates/scala-lang/parametrized_input.ftl Outdated
Comment thread src/main/resources/templates/scala-lang/parametrized_input.ftl Outdated
Comment thread src/main/resources/templates/kotlin-lang/parametrized_input.ftl
Comment thread src/main/resources/templates/scala-lang/response_projection.ftl Outdated
Comment thread src/main/resources/templates/scala-lang/response_projection.ftl Outdated
Comment thread src/main/resources/templates/scala-lang/response_projection.ftl Outdated

@jxnu-liguobin jxnu-liguobin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, you can try to make changes, or wait for me to make changes sometime in the evening.

@jxnu-liguobin

Copy link
Copy Markdown
Collaborator

plz see #1032

@kobylynskyi

Copy link
Copy Markdown
Owner Author

@jxnu-liguobin thank you for your feedback, I've applied your changes to templates in this PR. Please take a look.

jxnu-liguobin
jxnu-liguobin previously approved these changes Feb 22, 2023
@kobylynskyi kobylynskyi merged commit e06d69b into develop Feb 22, 2023
@kobylynskyi kobylynskyi deleted the 985-combine-multiple-response-projections branch February 22, 2023 12:16
@kobylynskyi kobylynskyi mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants