Upstream/985 combine multiple response projections#1032
Closed
jxnu-liguobin wants to merge 2 commits into
kobylynskyi:985-combine-multiple-response-projectionsfrom
jxnu-liguobin:upstream/985-combine-multiple-response-projections
Closed
Upstream/985 combine multiple response projections#1032jxnu-liguobin wants to merge 2 commits intokobylynskyi:985-combine-multiple-response-projectionsfrom jxnu-liguobin:upstream/985-combine-multiple-response-projections
jxnu-liguobin wants to merge 2 commits into
kobylynskyi:985-combine-multiple-response-projectionsfrom
jxnu-liguobin:upstream/985-combine-multiple-response-projections
Conversation
3 tasks
Collaborator
Author
|
In order to verify major changes, I put Scala and kotlin files into the test module to ensure that they can be compiled, but at present, I need to manually execute GraphQLCodegenVerifyCompileTest.java |
kobylynskyi
requested changes
Feb 22, 2023
| void cleanup() { | ||
| Utils.deleteDir(outputBuildDir); | ||
| } | ||
| // @AfterEach |
| id "signing" | ||
| id "maven-publish" | ||
| id "org.sonarqube" version "3.2.0" | ||
| id 'org.jetbrains.kotlin.jvm' version '1.8.20-Beta' |
Owner
There was a problem hiding this comment.
@jxnu-liguobin I would like not to add kotlin code and dependencies to the main project. instead, please add this as part of example kotlin plugin which we already have.
Collaborator
Author
There was a problem hiding this comment.
Yes. We can update the sample synchronously when major changes occur.
Collaborator
Author
There was a problem hiding this comment.
The template changes in this PR have been verified, closed it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #ISSUE_NUMBER
Changes were made to: