Skip to content

ran codegen with go1.19 & fix linter warnings #13438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 3 commits into from
Nov 3, 2022
Merged

ran codegen with go1.19 & fix linter warnings #13438

knative-prow merged 3 commits into from
Nov 3, 2022

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 3, 2022 •
edited
Loading

There's a drift in formatting between go1.18 and go1.19.

Secondly, new linter errors will be addressed in a follow up made an issue #13439

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2022
@codecov
Copy link

codecov bot commented Nov 3, 2022 •
edited
Loading

Codecov Report

Base: 86.50% // Head: 86.42% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (a65536c) compared to base (bc368c3).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13438      +/-   ##
==========================================
- Coverage   86.50%   86.42%   -0.08%     
==========================================
  Files         196      196              
  Lines       14556    14560       +4     
==========================================
- Hits        12591    12584       -7     
- Misses       1667     1676       +9     
- Partials      298      300       +2
Impacted Files Coverage Δ
pkg/activator/net/lb_policy.go 91.22% <ø> (ø)
pkg/autoscaler/metrics/sample_size.go 100.00% <ø> (ø)
pkg/autoscaler/statforwarder/forwarder.go 96.00% <ø> (ø)
pkg/queue/sharedmain/main.go 0.61% <0.00%> (-0.01%) ⬇️
pkg/reconciler/autoscaling/kpa/kpa.go 95.26% <ø> (ø)
pkg/reconciler/revision/rate_limiter.go 100.00% <ø> (ø)
pkg/autoscaler/statserver/server.go 75.91% <100.00%> (-1.87%) ⬇️
pkg/reconciler/revision/resolve.go 85.00% <0.00%> (-7.50%) ⬇️
pkg/reconciler/configuration/configuration.go 82.93% <0.00%> (-1.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nader-ziada
Copy link
Member

nader-ziada commented Nov 3, 2022

Code Style still failed

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso dprotaso changed the title ran codegen with go1.19 ran codegen with go1.19 & fix linter warnings Nov 3, 2022
@dprotaso dprotaso mentioned this pull request Nov 3, 2022
Closed
@nader-ziada
Copy link
Member

nader-ziada commented Nov 3, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2022
@knative-prow knative-prow bot merged commit a47c428 into knative:main Nov 3, 2022
@dprotaso dprotaso deleted the serving-codegen branch November 3, 2022 18:23
@dprotaso
Copy link
Member Author

dprotaso commented Nov 22, 2022

/cherry-pick release-1.8

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 22, 2022
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 22, 2022

@dprotaso: new pull request created: #13492

Details

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member Author

dprotaso commented Nov 22, 2022

/cherry-pick release-1.7

@dprotaso
Copy link
Member Author

dprotaso commented Nov 22, 2022

/cherry-pick release-1.6

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 22, 2022

@dprotaso: new pull request created: #13493

Details

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 22, 2022
Merged
@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Nov 22, 2022

@dprotaso: #13438 failed to apply on top of branch "release-1.6":

Patch is empty.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nader-ziada nader-ziada

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @nader-ziada @knative-prow-robot