Skip to content

[release-1.7] ran codegen with go1.19 & fix linter warnings #13493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 3 commits into from
Nov 22, 2022
Merged

[release-1.7] ran codegen with go1.19 & fix linter warnings #13493

knative-prow merged 3 commits into from
Nov 22, 2022

Conversation

@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Nov 22, 2022

This is an automated cherry-pick of #13438

@knative-prow-robot knative-prow-robot mentioned this pull request Nov 22, 2022
Merged
@knative-prow knative-prow bot added area/API API objects and controllers area/autoscale area/networking size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022 •
edited
Loading

Codecov Report

Base: 86.54% // Head: 86.51% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (a136d27) compared to base (812f1c8).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.7   #13493      +/-   ##
===============================================
- Coverage        86.54%   86.51%   -0.03%     
===============================================
  Files              196      196              
  Lines            14511    14515       +4     
===============================================
  Hits             12558    12558              
- Misses            1653     1657       +4     
  Partials           300      300
Impacted Files Coverage Δ
pkg/activator/net/lb_policy.go 91.22% <ø> (ø)
pkg/autoscaler/metrics/sample_size.go 100.00% <ø> (ø)
pkg/autoscaler/statforwarder/forwarder.go 96.00% <ø> (+5.33%) ⬆️
pkg/queue/sharedmain/main.go 0.61% <0.00%> (-0.01%) ⬇️
pkg/reconciler/autoscaling/kpa/kpa.go 95.26% <ø> (ø)
pkg/reconciler/revision/rate_limiter.go 100.00% <ø> (ø)
pkg/autoscaler/statserver/server.go 75.91% <100.00%> (-1.87%) ⬇️
pkg/reconciler/revision/resolve.go 85.00% <0.00%> (-7.50%) ⬇️
pkg/reconciler/revision/background.go 90.90% <0.00%> (-1.82%) ⬇️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member

dprotaso commented Nov 22, 2022

/lgtm
/approve

@knative-prow
Copy link

knative-prow bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2022
@knative-prow knative-prow bot merged commit 89fe233 into knative:release-1.7 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@dprotaso dprotaso

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/autoscale area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@knative-prow-robot @dprotaso