Skip to content

fix: only run openshift tests in integration mode#868

Closed
lkingland wants to merge 2 commits intoknative:mainfrom
lkingland:lkingland/openshift-int-test-mode
Closed

fix: only run openshift tests in integration mode#868
lkingland wants to merge 2 commits intoknative:mainfrom
lkingland:lkingland/openshift-int-test-mode

Conversation

@lkingland
Copy link
Copy Markdown
Member

@lkingland lkingland commented Feb 28, 2022

Changes

The OpenShift integration test was running in unit test mode; simply needing the tag.

  • 🐛 OpenShift integration test running in unit test mode

/kind bug

Fixes #867

@knative-prow-robot
Copy link
Copy Markdown

knative-prow-robot commented Feb 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels Feb 28, 2022
@lkingland lkingland marked this pull request as draft February 28, 2022 11:51
@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. label Feb 28, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2022

Codecov Report

Merging #868 (2e8cdb8) into main (663fd29) will increase coverage by 0.68%.
The diff coverage is 67.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   42.87%   43.55%   +0.68%     
==========================================
  Files          49       48       -1     
  Lines        4786     4741      -45     
==========================================
+ Hits         2052     2065      +13     
+ Misses       2446     2392      -54     
+ Partials      288      284       -4
Impacted Files Coverage Δ
cmd/version.go 66.66% <60.71%> (-33.34%) ⬇️
cmd/root.go 69.03% <69.84%> (-0.42%) ⬇️
openshift/openshift.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663fd29...2e8cdb8. Read the comment docs.

@lkingland lkingland changed the title Lkingland/openshift int test mode fix: only run openshift tests in integration mode Feb 28, 2022
@matejvasek
Copy link
Copy Markdown
Contributor

matejvasek commented Feb 28, 2022 •
edited
Loading

this contains a lot of changes that does not seem to be related

@lkingland lkingland mentioned this pull request Feb 28, 2022
Closed
@matejvasek
Copy link
Copy Markdown
Contributor

matejvasek commented Feb 28, 2022

Closing in favor of #870.

@matejvasek matejvasek closed this Feb 28, 2022
@lkingland
Copy link
Copy Markdown
Member Author

lkingland commented Feb 28, 2022

this contains a lot of changes that does not seem to be related

Yes, I was planning to rebase after #865 was merged. Thanks for just putting the change in straight away!

@lkingland lkingland deleted the lkingland/openshift-int-test-mode branch September 20, 2022 01:04
creydr pushed a commit to creydr/knative-func that referenced this pull request Sep 10, 2024
@matejvasek
More granular image references (knative#868)
2248efe 
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. kind/bug Bugs size/L 🤖 PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests failing locally

3 participants

@lkingland @knative-prow-robot @matejvasek