Skip to content

Mark OpenShift test as an integration test#870

Merged
knative-prow-robot merged 1 commit intoknative:mainfrom
matejvasek:fix-osh-test
Feb 28, 2022
Merged

Mark OpenShift test as an integration test#870
knative-prow-robot merged 1 commit intoknative:mainfrom
matejvasek:fix-osh-test

Conversation

@matejvasek
Copy link
Copy Markdown
Contributor

  • Make OpenShift test an integration test
  • Fix OpenShift detection

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@knative-prow-robot knative-prow-robot added size/S 🤖 PR changes 10-29 lines, ignoring generated files. approved 🤖 PR has been approved by an approver from all required OWNERS files. labels Feb 28, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 28, 2022

Codecov Report

Merging #870 (58944eb) into main (60dbeac) will increase coverage by 0.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #870      +/-   ##
==========================================
+ Coverage   44.04%   44.66%   +0.62%     
==========================================
  Files          49       48       -1     
  Lines        4804     4726      -78     
==========================================
- Hits         2116     2111       -5     
+ Misses       2390     2317      -73     
  Partials      298      298              
Impacted Files Coverage Δ
openshift/openshift.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60dbeac...58944eb. Read the comment docs.

Copy link
Copy Markdown
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm 🤖 PR is ready to be merged. label Feb 28, 2022
@knative-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek, zroubalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [matejvasek,zroubalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit bea34d2 into knative:main Feb 28, 2022
lkingland pushed a commit to lkingland/func that referenced this pull request Mar 1, 2022
Signed-off-by: Matej Vasek <mvasek@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. lgtm 🤖 PR is ready to be merged. size/S 🤖 PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants