Skip to content

Conversation

picking knative#2962

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2965

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2025
@matejvasek matejvasek requested a review from dprotaso October 14, 2025 16:44
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 39.72603% with 44 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.73%. Comparing base (28c35e2) to head (fbca826).
⚠️ Report is 1 commits behind head on release-1.19.

Files with missing lines Patch % Lines
pkg/oci/python_builder.go 0.00% 18 Missing ⚠️
pkg/builders/buildpacks/builder.go 0.00% 9 Missing ⚠️
pkg/builders/buildpacks/scaffolding_injector.go 0.00% 7 Missing ⚠️
pkg/functions/runner.go 0.00% 7 Missing ⚠️
cmd/run.go 90.62% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.19    #3089       +/-   ##
=================================================
+ Coverage         46.64%   59.73%   +13.08%     
=================================================
  Files               130      132        +2     
  Lines             16827    16879       +52     
=================================================
+ Hits               7849    10082     +2233     
+ Misses             8273     5839     -2434     
- Partials            705      958      +253     
Flag Coverage Δ
e2e-tests 41.14% <35.61%> (?)
integration-tests 54.47% <39.72%> (?)
unit-tests 46.64% <39.72%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matejvasek and others added 6 commits October 14, 2025 19:16
picking knative#2987

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2992

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#2994

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#3080

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#3082

Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#3055

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>
picking knative#3076

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @dprotaso

@gauron99
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@knative-prow
Copy link

knative-prow bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

/retest

@knative-prow knative-prow bot merged commit 2988acf into knative:release-1.19 Oct 14, 2025
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants