fix: use python3 when python not present #3082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Vašek <mvasek@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Contributor
|
/unhold |
Contributor
|
/lgtm |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3082 +/- ##
==========================================
+ Coverage 58.46% 59.16% +0.70%
==========================================
Files 134 134
Lines 17251 17263 +12
==========================================
+ Hits 10085 10213 +128
+ Misses 6234 6090 -144
- Partials 932 960 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@gauron99 override the tests. |
Contributor
|
/override unit-tests_func_main |
|
@gauron99: Overrode contexts on behalf of gauron99: unit-tests_func_main DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Oct 14, 2025
picking knative#3082 Signed-off-by: Matej Vašek <mvasek@redhat.com>
Merged
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Oct 14, 2025
picking knative#3082 Signed-off-by: Matej Vašek <mvasek@redhat.com>
knative-prow bot
pushed a commit
that referenced
this pull request
Oct 14, 2025
* Fix backward compat Python pack build picking #2962 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: Python host builder base image version picking #2965 Signed-off-by: Matej Vašek <mvasek@redhat.com> * Remove container flag - variant I picking #2987 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix python injector bug picking #2992 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix-of-a-fix picking #2994 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: python scaffolding picking #3080 Signed-off-by: Matej Vašek <mvasek@redhat.com> * fix: use python3 when python not presetn picking #3082 Signed-off-by: Matej Vašek <mvasek@redhat.com> * dapr install upgrade picking #3055 Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com> Signed-off-by: Matej Vašek <mvasek@redhat.com> * test: skip ipv6 test correctly picking #3076 Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Signed-off-by: David Fridrich <fridrich.david19@gmail.com> Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
python3whenpythonnot present, sometimes there is missing symlinkpython->python3on some systems.fixes: #3078
/kind bug