Skip to content

bug: python injector didnt choose signature #2992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 1 commit into from
Aug 20, 2025
Merged

bug: python injector didnt choose signature #2992

knative-prow merged 1 commit into from
Aug 20, 2025

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Aug 20, 2025

Changes

/kind

Fixes #

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Aug 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow
Copy link

knative-prow bot commented Aug 20, 2025

@gauron99: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2025
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2025
@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.60%. Comparing base (c13214d) to head (4a4fc73).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/buildpacks/scaffolding_injector.go 0.00% 7 Missing ⚠️
pkg/builders/buildpacks/builder.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2992      +/-   ##
==========================================
+ Coverage   57.96%   59.60%   +1.64%     
==========================================
  Files         132      132              
  Lines       16944    16974      +30     
==========================================
+ Hits         9821    10118     +297     
+ Misses       6222     5899     -323     
- Partials      901      957      +56
Flag Coverage Δ
e2e-tests 40.91% <0.00%> (+7.55%) ⬆️
integration-tests 54.36% <0.00%> (+1.57%) ⬆️
unit-tests 46.58% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 20, 2025
@gauron99 gauron99 marked this pull request as ready for review August 20, 2025 11:09
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 20, 2025
@gauron99
Copy link
Contributor Author

gauron99 commented Aug 20, 2025

@matejvasek PTAL

@gauron99 gauron99 requested review from matejvasek and removed request for dsimansk and jrangelramos August 20, 2025 11:09
@matejvasek
Copy link
Contributor

matejvasek commented Aug 20, 2025

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [gauron99,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gauron99
Copy link
Contributor Author

gauron99 commented Aug 20, 2025 •
edited
Loading

cc @lkingland FYI if your e2es fail; this fixes standard python-pack builder build with http

@knative-prow knative-prow bot merged commit c48dbc1 into knative:main Aug 20, 2025
39 checks passed
@gauron99 gauron99 mentioned this pull request Aug 20, 2025
Merged
@gauron99 gauron99 deleted the push-oxqlnxtrtsns branch August 20, 2025 17:37
matejvasek added a commit to matejvasek/faas that referenced this pull request Oct 14, 2025
@matejvasek
fix python injector bug
a39ecd4 
picking knative#2992

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek mentioned this pull request Oct 14, 2025
Merged
matejvasek added a commit to matejvasek/faas that referenced this pull request Oct 14, 2025
@matejvasek
fix python injector bug
8ecc6fb 
picking knative#2992

Signed-off-by: Matej Vašek <mvasek@redhat.com>
knative-prow bot pushed a commit that referenced this pull request Oct 14, 2025
@matejvasek @gauron99
Cherry picks 1.19 (#3089)
2988acf 
* Fix backward compat Python pack build

picking #2962

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: Python host builder base image version

picking #2965

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Remove container flag - variant I

picking #2987

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix python injector bug

picking #2992

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix-of-a-fix

picking #2994

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: python scaffolding

picking #3080

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: use python3 when python not presetn

picking #3082

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* dapr install upgrade

picking #3055

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

* test: skip ipv6 test correctly

picking #3076

Signed-off-by: Matej Vašek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees

@matejvasek matejvasek

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gauron99 @matejvasek