Skip to content

Conversation

@matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Aug 4, 2025

Changes

related to #2964

  • 🐛 Host builder picks base-image with the same version of Python that is used locally.

/kind bug

fix: host builder uses base-image with correct version of Python

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 4, 2025
@knative-prow knative-prow bot requested review from dsimansk and jrangelramos August 4, 2025 17:20
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2025
@matejvasek matejvasek requested review from gauron99, lkingland and matzew and removed request for dsimansk and jrangelramos August 4, 2025 17:20
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.98%. Comparing base (719b286) to head (e80b57e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/oci/python_builder.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2965      +/-   ##
==========================================
+ Coverage   58.27%   59.98%   +1.71%     
==========================================
  Files         132      132              
  Lines       16837    16847      +10     
==========================================
+ Hits         9812    10106     +294     
+ Misses       6124     5783     -341     
- Partials      901      958      +57     
Flag Coverage Δ
e2e-tests 41.21% <0.00%> (+7.65%) ⬆️
integration-tests 54.74% <0.00%> (+1.67%) ⬆️
unit-tests 46.86% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice call!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2025
@knative-prow
Copy link

knative-prow bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 80d0598 into knative:main Aug 4, 2025
45 of 47 checks passed
matejvasek added a commit to matejvasek/faas that referenced this pull request Oct 14, 2025
picking knative#2965

Signed-off-by: Matej Vašek <mvasek@redhat.com>
@matejvasek matejvasek mentioned this pull request Oct 14, 2025
knative-prow bot pushed a commit that referenced this pull request Oct 14, 2025
* Fix backward compat Python pack build

picking #2962

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: Python host builder base image version

picking #2965

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Remove container flag - variant I

picking #2987

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix python injector bug

picking #2992

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix-of-a-fix

picking #2994

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: python scaffolding

picking #3080

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* fix: use python3 when python not presetn

picking #3082

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* dapr install upgrade

picking #3055

Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Signed-off-by: Matej Vašek <mvasek@redhat.com>

* test: skip ipv6 test correctly

picking #3076

Signed-off-by: Matej Vašek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vašek <mvasek@redhat.com>
Signed-off-by: David Fridrich <fridrich.david19@gmail.com>
Co-authored-by: David Fridrich <fridrich.david19@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants