feat: add noninteractive flow to labels config #2886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2886 +/- ##
==========================================
+ Coverage 60.83% 61.49% +0.65%
==========================================
Files 129 129
Lines 16215 16271 +56
==========================================
+ Hits 9865 10006 +141
+ Misses 5429 5310 -119
- Partials 921 955 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b65f5e0 to
e438fa6
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e438fa6 to
38441a4
Compare
Contributor
|
/lgtm |
matejvasek
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 14, 2025
picking knative#2886 Signed-off-by: Matej Vašek <mvasek@redhat.com>
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 14, 2025
* feat: add noninteractive flow to volume config picking knative#2883 * feat: add noninteractive flow to labels config picking knative#2886 Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Co-authored-by: Luke Kingland <luke@lukekingland.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a noninteractive flow to func config labels.
Note that, as with the other updates to the
func config ...commands, tests will necessarily be in the E2Es until we have a chance to refactor these to be more testable./kind enhancement