feat: add noninteractive flow to volumes config #2883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
074cc62 to
6b92bb3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
+ Coverage 57.96% 62.43% +4.46%
==========================================
Files 129 129
Lines 15767 15925 +158
==========================================
+ Hits 9140 9942 +802
+ Misses 5785 5038 -747
- Partials 842 945 +103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauron99, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 14, 2025
openshift-merge-bot bot
pushed a commit
to openshift-knative/kn-plugin-func
that referenced
this pull request
Oct 14, 2025
* feat: add noninteractive flow to volume config picking knative#2883 * feat: add noninteractive flow to labels config picking knative#2886 Signed-off-by: Matej Vašek <mvasek@redhat.com> --------- Signed-off-by: Matej Vašek <mvasek@redhat.com> Co-authored-by: Luke Kingland <luke@lukekingland.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flags for manipulating volumes via cli flags
Note that tests are not included because the commands were not developed in a way conducive to testing. Tests are included in the forthcoming E2E test refactor, and will be included when the various config subcommands are refactored to match the architecture of other commands.