Skip to content

OTel docs follow up #6360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
knative-prow merged 3 commits into from
Sep 3, 2025
Merged

OTel docs follow up #6360

knative-prow merged 3 commits into from
Sep 3, 2025

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Sep 3, 2025

  • include UCUM link
  • address Evan's OTel Docs feedback
  • include autoscaler attributes

/assign @evankanderson @Cali0707

@netlify
Copy link

netlify bot commented Sep 3, 2025 •
edited
Loading

✅ Deploy Preview for knative ready!

Name Link
🔨 Latest commit d8e7096
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68b8addebc99e400080e311b
😎 Deploy Preview https://deploy-preview-6360--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot requested review from nainaz and skonto September 3, 2025 21:06
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 3, 2025
evankanderson
evankanderson approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@knative-prow
Copy link

knative-prow bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,evankanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit eb45d60 into knative:main Sep 3, 2025
19 checks passed
@dprotaso dprotaso deleted the otel-follow-up branch September 3, 2025 21:13
dprotaso added a commit to dprotaso/knative-docs that referenced this pull request Sep 3, 2025
@dprotaso
OTel docs follow up (knative#6360)
9392363 
* include UCUM link

* address Evan's OTel Docs feedback

* include autoscaler attributes
@dprotaso dprotaso mentioned this pull request Sep 3, 2025
Merged
knative-prow bot pushed a commit that referenced this pull request Sep 3, 2025
@dprotaso
[release-1.19] Cherry pick OTel docs changes (#6361)
01ca6d0 
* Cherry-pick (#6352)

* OTel docs follow up (#6360)

* include UCUM link

* address Evan's OTel Docs feedback

* include autoscaler attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson evankanderson approved these changes

@nainaz nainaz Awaiting requested review from nainaz

@skonto skonto Awaiting requested review from skonto

Assignees

@evankanderson evankanderson

@Cali0707 Cali0707

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprotaso @evankanderson @Cali0707