Skip to content

Conversation

@dprotaso
Copy link
Member

@dprotaso dprotaso commented Sep 3, 2025

* include UCUM link

* address Evan's OTel Docs feedback

* include autoscaler attributes
@knative-prow
Copy link

knative-prow bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Sep 3, 2025

Deploy Preview for knative ready!

Name Link
🔨 Latest commit 9392363
🔍 Latest deploy log https://app.netlify.com/projects/knative/deploys/68b8af9b42e3e700098d6e77
😎 Deploy Preview https://deploy-preview-6361--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2025
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2025
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 3, 2025
@dprotaso dprotaso changed the base branch from main to release-1.19 September 3, 2025 21:14
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 3, 2025
@dprotaso
Copy link
Member Author

dprotaso commented Sep 3, 2025

/assign @evankanderson @Cali0707

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2025
@dprotaso dprotaso changed the title Cherry pick OTel docs changes [release-1.19] Cherry pick OTel docs changes Sep 3, 2025
Copy link
Member

@evankanderson evankanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2025
@knative-prow knative-prow bot merged commit 01ca6d0 into knative:release-1.19 Sep 3, 2025
6 checks passed
@dprotaso dprotaso deleted the cherry-pick-otel-docs branch September 3, 2025 22:35
@dprotaso dprotaso mentioned this pull request Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants