src/update_engine_client: handle -update with idle#10
Merged
tormath1 merged 1 commit intoflatcar-masterfrom Jul 2, 2021
Merged
src/update_engine_client: handle -update with idle#10tormath1 merged 1 commit intoflatcar-masterfrom
tormath1 merged 1 commit intoflatcar-masterfrom
Conversation
pothos
reviewed
Jul 2, 2021
| exit(1); | ||
| } | ||
| if (current_op == "UPDATE_STATUS_IDLE") { | ||
| LOG(INFO) << "Update cancelled -- remote version is not newer than the local one"; |
Member
There was a problem hiding this comment.
Suggested change
| LOG(INFO) << "Update cancelled -- remote version is not newer than the local one"; | |
| LOG(INFO) << "No update available"; |
Whether the version is newer or not is not really guaranteed. I would also not call it cancelled, but maybe not available.
Contributor
Author
There was a problem hiding this comment.
make senses - also it's a clearer message :)
pothos
approved these changes
Jul 2, 2021
idle status was not correctly handled by the update_engine. When a user wants to check for an update with `update_engine_client -update` the command will fail with "Update failed" which can be misleading. Actually, the update does not failed it is just cancelled because there is no newer version. Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
538210d to
e826e24
Compare
tormath1
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Jul 2, 2021
related to: flatcar/update_engine#10, flatcar/Flatcar#356 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
t-lo
pushed a commit
to flatcar/scripts
that referenced
this pull request
Apr 17, 2023
related to: flatcar/update_engine#10, flatcar/Flatcar#356 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idle status was not correctly handled by the update_engine.
When a user wants to check for an update with
update_engine_client -updatethe command will fail with "Update failed" which can be misleading.
Actually, the update does not failed it is just cancelled because there
is no newer version.
Signed-off-by: Mathieu Tortuyaux mathieu@kinvolk.io
How to use
build a Flatcar image using this commit in
coreos-base/update-engineebuild.Testing done
Closes flatcar/Flatcar#356