kola/tests/update: add test for idle status#183
kola/tests/update: add test for idle status#183tormath1 wants to merge 2 commits intoflatcar-masterfrom
Conversation
this test assert that there is no regression regarding the status check when there is no new upload available Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
kola/tests/update/update.go
Outdated
| c.Fatalf("unable to run update_engine_client -update: %v", err) | ||
| } | ||
|
|
||
| if string(out) == "Update cancelled -- remote version is not newer than the local one" { |
There was a problem hiding this comment.
I'm new to this, but just reading the logic I would think that the test should be:
| if string(out) == "Update cancelled -- remote version is not newer than the local one" { | |
| if string(out) != "Update cancelled -- remote version is not newer than the local one" { |
There was a problem hiding this comment.
@jepio that's totally right, it seems my 🧠 is already in week-end. :D
I also added an output redirection in the fixup commit.
| // assert that -update does not fail | ||
| // when there is nothing to do | ||
| // https://github.com/kinvolk/Flatcar/issues/356 | ||
| func idle(c cluster.TestCluster) { |
There was a problem hiding this comment.
This test is only valid for developer builds or as long as the next release is not published. It may be confusing when running the tests for a published release.
Besides that I'm also a bit concerned about the runtime of the tests because this small test needs its own instance created and that takes multiple minutes depending on the platform.
There was a problem hiding this comment.
I think there is some support in kola for emulating an update service and to perform an update. In combination with this it makes sense to have a test where maybe in one test case an update is handed and in the other test case there is none. But I wouldn't let the behavior depend on the public update service.
There was a problem hiding this comment.
Ok then we can close this PR for the moment - I'm currently trying to think about a better way to test the update behavior of Flatcar :)
There was a problem hiding this comment.
I see that we are already in the right file: cl.update.payload is currently not used in Jenkins, would make sense to set this up.
--- SKIP: cl.update.payload (19.31s)
update.go:93: no update payload provided
There was a problem hiding this comment.
yeah I dug around a bit - we would need to generate an update payload with delta_generator and to provide it to the kola command line. I can open a dedicated issue to track this :) That would be a good start !
this test assert that there is no regression regarding the status
check when there is no new upload available
Signed-off-by: Mathieu Tortuyaux mathieu@kinvolk.io
Related to: flatcar/update_engine#10