Skip to content

fix(android/app): Another attempt at fixing OSK rotation#8353

Merged
darcywong00 merged 1 commit intomasterfrom
fix/android/rotate-osk-again
Mar 3, 2023
Merged

fix(android/app): Another attempt at fixing OSK rotation#8353
darcywong00 merged 1 commit intomasterfrom
fix/android/rotate-osk-again

Conversation

@darcywong00
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 commented Mar 2, 2023 •
edited
Loading

Fixes #8229 and re-implements #8291

I believe the concerns from #8306 are actually fixed by #8349 which fixed a few issues about interactions between InApp and System keyboard.

User Testing

Setup - Install the PR build of Keyman for Android

  1. Install the PR build of Keyman for Android on portrait orientation
  2. Open the Keyman app
  3. Change the mobile view into landscape.
  4. Verify the OSK readjusts to fill the entire width
  1. Install the PR build of Keyman for Android
  2. Open Keyman In-App.
  3. Open Settings menu.
  4. Enable Keyman as system-wide keyboard.
  5. Enable 'Set Keyman as default keyboard'.
    6 Add 'Khmer Angkor' Keyboard using 'Install Keyboard or Dictionary' option.
  6. Verify after keyboard and dictionary installed, the keyboard OSK is not blank

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Mar 2, 2023
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Mar 2, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_OSK_ROTATION (PASSED): Tested with the attached PR build (17.0.60-alpha-test-8353) in Android 12 /API 31 and here is my observation: The OSK readjusts to fill the entire width after the rotation. (ie., from Portrait to Landscape view) (notes)
  • ✅ TEST_INSTALL_SECOND_LANGUAGE (PASSED): Verified that after installing Khmer Angkor keyboard and dictionary in Keyman, the keyboard OSK appears correctly on screen. (notes)

Test Artifacts

@darcywong00 darcywong00 marked this pull request as ready for review March 2, 2023 08:53
@darcywong00 darcywong00 requested a review from sgschantz as a code owner March 2, 2023 08:53
@darcywong00 darcywong00 added this to the A17S7 milestone Mar 2, 2023
@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Mar 3, 2023

Test Results

  • TEST_OSK_ROTATION (PASSED): Tested with the attached PR build (17.0.60-alpha-test-8353) in Android 12 /API 31 and here is my observation: The OSK readjusts to fill the entire width after the rotation. (ie., from Portrait to Landscape view)

  • TEST_INSTALL_SECOND_LANGUAGE (PASSED): Verified that after installing Khmer Angkor keyboard and dictionary in Keyman, the keyboard OSK appears correctly on screen.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Mar 3, 2023
@darcywong00 darcywong00 merged commit 1d0d38f into master Mar 3, 2023
@darcywong00 darcywong00 deleted the fix/android/rotate-osk-again branch March 3, 2023 05:55
@keyman-server
Copy link
Copy Markdown
Collaborator

keyman-server commented Mar 3, 2023

Changes in this pull request will be available for download in Keyman version 17.0.61-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@sgschantz sgschantz Awaiting requested review from sgschantz

Assignees

No one assigned

Labels

android/app/ android/ fix has-user-test

Projects

None yet

Milestone

A17S7

Development

Successfully merging this pull request may close these issues.

bug(android/app): OSK didn't resize in Landscape mode

4 participants

@darcywong00 @bharanidharanj @keyman-server @mcdurdin