Skip to content

fix(android/engine): Fix various OSK bugs due to refactor 🛋#8349

Merged
darcywong00 merged 1 commit intomasterfrom
fix/android/keyboard-webview-client
Mar 2, 2023
Merged

fix(android/engine): Fix various OSK bugs due to refactor 🛋#8349
darcywong00 merged 1 commit intomasterfrom
fix/android/keyboard-webview-client

Conversation

@darcywong00
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 commented Mar 2, 2023 •
edited
Loading

Fixes #8305 and fixes #8337 which were regressions introduced in the #7993 refactoring

During my refactoring of KMKeyboardWebViewClient.java, I haphazardly left all the members static, which meant there were collisions when both InApp and System keyboards updated themselves.

User Testing

Setup - Install the PR build of Keyman for Android

  1. Install the PR build of Keyman for Android
  2. Open Keyman In-App
  3. Click the Globe key
  4. May notice that the Keyboard picker menu opens on the screen
  5. Open Settings menu
  6. Enable Keyman as the "System-wide keyboard" and "Default keyboard"
  7. Revert to OSK
  8. Click the globe key
  9. Dismiss keyboard picker and verify keyboard area is not blank
  1. Install the PR build of Keyman for Android
  2. Open Keyman In-App
  3. Open Settings menu
  4. Enable the tick against 'Enable Keyman as system-wide keyboard' check box.
  5. Enable the tick against 'Set Keyman as default keyboard' check box.
  6. Click Installed languages option.
  7. Click English option to go to English Settings menu.
  8. Disable both predictions and corrections.
  9. Click the Dictionary(MTNT) option.
  10. Uninstall English dictionary (MTNT).
  11. Switch to main keyboard view.
  12. Verify the predictive text banner no longer appears

@darcywong00 darcywong00 requested a review from sgschantz as a code owner March 2, 2023 03:55
@keymanapp-test-bot keymanapp-test-bot bot added the user-test-missing User tests have not yet been defined for the PR label Mar 2, 2023
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Mar 2, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_GLOBE_KEY_WORKS_AFTER_SYSTEM_KEYBOARD (PASSED): Tested with the attached PR build (Keyman 17.0.60-alpha-test-8349) in Android 12 / API 31 emulator and here is my observation: Verified that the keyboard is no more blank after reverting from the keyman list menu. (using globe key) (notes)
  • ✅ TEST_PREDICTIVE_TEXT_BANNER_DISAPPEARS_AFTER_UNINSTALL (PASSED): Tested with the attached PR build (Keyman 17.0.60-alpha-test-8349) in Android 9 / API 28 emulator and here is my observation : Verified that the Predictive text banner no longer appears after uninstalling the MTNT English Dictionary. (notes)

Test Artifacts

@darcywong00 darcywong00 added this to the A17S7 milestone Mar 2, 2023
@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed and removed user-test-missing User tests have not yet been defined for the PR labels Mar 2, 2023
mcdurdin
mcdurdin approved these changes Mar 2, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darcywong00 darcywong00 linked an issue Mar 2, 2023 that may be closed by this pull request
refactor(android/engine): Merge SystemKeyboard and InappKeyboard in KMManager 🛋 #7881
Closed
@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Mar 2, 2023

Test Results

  • TEST_GLOBE_KEY_WORKS_AFTER_SYSTEM_KEYBOARD (PASSED): Tested with the attached PR build (Keyman 17.0.60-alpha-test-8349) in Android 12 / API 31 emulator and here is my observation: Verified that the keyboard is no more blank after reverting from the keyman list menu. (using globe key)

  • TEST_PREDICTIVE_TEXT_BANNER_DISAPPEARS_AFTER_UNINSTALL (PASSED): Tested with the attached PR build (Keyman 17.0.60-alpha-test-8349) in Android 9 / API 28 emulator and here is my observation : Verified that the Predictive text banner no longer appears after uninstalling the MTNT English Dictionary.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Mar 2, 2023
@darcywong00 darcywong00 merged commit fbd9d15 into master Mar 2, 2023
@darcywong00 darcywong00 deleted the fix/android/keyboard-webview-client branch March 2, 2023 07:41
@darcywong00 darcywong00 mentioned this pull request Mar 2, 2023
Merged
@keyman-server
Copy link
Copy Markdown
Collaborator

keyman-server commented Mar 2, 2023

Changes in this pull request will be available for download in Keyman version 17.0.60-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment