Skip to content

fix(android/app): Fix OSK width when rotating#8291

Merged
darcywong00 merged 1 commit intomasterfrom
fix/android/landscape-osk
Feb 22, 2023
Merged

fix(android/app): Fix OSK width when rotating#8291
darcywong00 merged 1 commit intomasterfrom
fix/android/landscape-osk

Conversation

@darcywong00
Copy link
Copy Markdown
Contributor

@darcywong00 darcywong00 commented Feb 22, 2023

Fixes #8229

This issue was quite puzzling. Only on newer Android SDKs, the in-app keyboard width failed to refresh when rotating the device from portrait to landscape. System Keyboard wasn't affected so I compared MainActivity.onConfigurationChanged and SystemKeyboard.onConfigurationChanged.

I add this line, and OSK rotation works. I take revert, and the issue is reprod. afaict, the issue not appear on stable-16.0.

User Testing

Setup - Use Android emulator/device with SDK >= 31

  • TEST_OSK_ROTATION - Verifies OSK refreshes width on rotation
  1. Install the PR build of Keyman for Android in portrait orientation
  2. Observe the in-app keyboard fills the device width
  3. Rotate the device to landscape (you may need to toggle the Android setting to auto-rotate)
  4. Observe the in-app keyboard rotate to landscape
  5. Verify in-app keyboard fills the device width.

@keymanapp-test-bot keymanapp-test-bot bot added has-user-test user-test-required User tests have not been completed labels Feb 22, 2023
@keymanapp-test-bot
Copy link
Copy Markdown

keymanapp-test-bot bot commented Feb 22, 2023 •
edited
Loading

User Test Results

Test specification and instructions

  • ✅ TEST_OSK_ROTATION (PASSED): Tested with the attached PR build (17.0.54-alpha-test-8291) in Android 12 / API 31 emulator and here is my observation: 1. Able to see the keyboard fills the device width, either in landscape view or portrait view. Seems to be working fine. Thanks. (notes)

Test Artifacts

@darcywong00 darcywong00 added this to the A17S7 milestone Feb 22, 2023
@bharanidharanj
Copy link
Copy Markdown

bharanidharanj commented Feb 22, 2023

Test Results

  • TEST_OSK_ROTATION (PASSED): Tested with the attached PR build (17.0.54-alpha-test-8291) in Android 12 / API 31 emulator and here is my observation: 1. Able to see the keyboard fills the device width, either in landscape view or portrait view. Seems to be working fine. Thanks.

@keymanapp-test-bot keymanapp-test-bot bot removed the user-test-required User tests have not been completed label Feb 22, 2023
@darcywong00 darcywong00 merged commit dc7603a into master Feb 22, 2023
@darcywong00 darcywong00 deleted the fix/android/landscape-osk branch February 22, 2023 13:10
@keyman-server
Copy link
Copy Markdown
Collaborator

keyman-server commented Feb 22, 2023

Changes in this pull request will be available for download in Keyman version 17.0.54-alpha

@darcywong00 darcywong00 mentioned this pull request Feb 24, 2023
Closed
8 tasks
darcywong00 added a commit that referenced this pull request Feb 24, 2023
@darcywong00
chore(android): Revert "Merge pull request #8291 from keymanapp/fix/a…
57f4987 
…ndroid/landscape-osk"

This reverts commit dc7603a.
This was referenced Feb 24, 2023
Merged
Closed
mcdurdin added a commit that referenced this pull request Feb 25, 2023
@mcdurdin
Merge pull request #8314 from keymanapp/chore/android/revert-8291
8c5bd34 
chore(android/app): Revert #8291
@darcywong00 darcywong00 mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcdurdin mcdurdin mcdurdin approved these changes

@sgschantz sgschantz Awaiting requested review from sgschantz

Assignees

No one assigned

Labels

android/app/ android/ fix has-user-test

Projects

None yet

Milestone

A17S7

Development

Successfully merging this pull request may close these issues.

bug(android/app): OSK didn't resize in Landscape mode

4 participants

@darcywong00 @bharanidharanj @keyman-server @mcdurdin