Merged
Conversation
…ndroid/landscape-osk" This reverts commit dc7603a.
User Test ResultsTest specification and instructions
Results TemplateTest Artifacts |
mcdurdin
approved these changes
Feb 24, 2023
Member
|
Let's go ahead and merge this so that we can unbreak Android on master. Given it just reverts the previous thing which broke master, it should be good to merge. |
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.57-alpha |
Test Results
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8291 and fixes #8306
I will have to re-open #8229 for investigation...
This reverts commit dc7603a.
User Testing
Setup - install the PR build of Keyman for Android
6 Add 'Khmer Angkor' Keyboard using 'Install Keyboard or Dictionary' option.