Skip to content

feat(core,developer): simplify markers 🙀#10565

Merged
srl295 merged 5 commits intomasterfrom
feat/core/10317-simplify-marker-epic-ldml
Feb 1, 2024
Merged

feat(core,developer): simplify markers 🙀#10565
srl295 merged 5 commits intomasterfrom
feat/core/10317-simplify-marker-epic-ldml

Conversation

@srl295
Copy link
Copy Markdown
Member

@srl295 srl295 commented Jan 30, 2024

#10317

@keymanapp-test-bot skip

@srl295 srl295 self-assigned this Jan 30, 2024
@keymanapp-test-bot keymanapp-test-bot bot added this to the A17S31 milestone Jan 30, 2024
@srl295 srl295 marked this pull request as draft January 30, 2024 23:00
Copy link
Copy Markdown
Member

@mcdurdin mcdurdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤯

@srl295 srl295 marked this pull request as ready for review January 31, 2024 21:23
@srl295 srl295 force-pushed the feat/core/10317-double-marker2-epic-ldml branch from 9f9183c to cb181cd Compare January 31, 2024 21:42
@srl295 srl295 force-pushed the feat/core/10317-simplify-marker-epic-ldml branch from c17860e to 266d224 Compare January 31, 2024 21:43
@srl295 srl295 linked an issue Jan 31, 2024 that may be closed by this pull request
2 tasks
@srl295 srl295 added the m:normalization Issues related to text normalization label Jan 31, 2024
@srl295 srl295 force-pushed the feat/core/10317-double-marker2-epic-ldml branch from cb181cd to 600fdcc Compare February 1, 2024 00:06
- clean up removing multi-segment processing
@srl295 srl295 force-pushed the feat/core/10317-simplify-marker-epic-ldml branch from 266d224 to 6c1447b Compare February 1, 2024 00:17
feat(core): report on (lack of) normalization 🙀
Base automatically changed from feat/core/10317-double-marker2-epic-ldml to master February 1, 2024 20:29
@srl295 srl295 merged commit 88a9f72 into master Feb 1, 2024
@srl295 srl295 deleted the feat/core/10317-simplify-marker-epic-ldml branch February 1, 2024 20:29
@keyman-server
Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 17.0.259-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common/web/ common/ core/ Keyman Core developer/ feat m:normalization Issues related to text normalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(developer): normalization on the developer side 🙀

3 participants