feat(developer): double markers once again 🙀#10541
Merged
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
srl295
commented
Jan 29, 2024
7693408 to
3767f7a
Compare
srl295
commented
Jan 30, 2024
mcdurdin
approved these changes
Jan 30, 2024
Member
mcdurdin
left a comment
There was a problem hiding this comment.
LGTM. My head is hurting now but it seems to all make sense
Comment on lines
+351
to
+365
| // now, push the rest of the glue chars as an NFD sequence. | ||
| // For example, `\m{m}\u0344` will create the following stream: | ||
| // { ch: 0308, end: true} | ||
| // { ch: 0308, marker: 1} | ||
| // { ch: 0301, end: true} // added because of decomp |
Member
There was a problem hiding this comment.
I see so the marker gets glued to the last character in the decomposition. Definitely slightly unintuitive -- more so than other gluings.
Member
There was a problem hiding this comment.
I'm not entirely following?
\m{m}\u0344 ==> \m{m}\u0308\u0301 or \u0308\m{m}\u0301?
Member
Author
There was a problem hiding this comment.
\m{m}\u0308\u0301 - adding a test. markers are re-added in reverse order.
bf69802 to
7cb4697
Compare
06b6e7f to
6b60ac4
Compare
9d2731c to
2c92cfe
Compare
6b60ac4 to
1988c43
Compare
…10317-double-marker-epic-ldml
Base automatically changed from
feat/core/10516-reorder-norm-epic-ldml
to
master
February 1, 2024 05:18
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.259-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#10516
@keymanapp-test-bot skip