chore: merge master into feature-gestures 🐵#10242
Merged
jahorton merged 74 commits intofeature-gesturesfrom Dec 13, 2023
Merged
chore: merge master into feature-gestures 🐵#10242jahorton merged 74 commits intofeature-gesturesfrom
jahorton merged 74 commits intofeature-gesturesfrom
Conversation
- distinguish between unmapped and 0-length output strings - don't do any processing for 0-length output strings - no change to developer, that will be next - remove a comment referencing transform=no For: #9451
- restructure keyup/keydown code some - new utility function emit_invalidate_passthrough_keystroke() For: #9451
- unused nit fix For: #9451
Adds state->set_actions(). This sets the Core's action list to match the contents of the action struct. Note that markers are not supported and backspace expected_values will be empty, as this information is not available. As the intended consumer of the action struct does not need to know this information, this should be adequate.
From TODO item in #9948.
Fixes #10144. Also adds .keyboard_info, for now, although it is removed in 17.0, as there will be numerous projects which still have a .keyboard_info and it is handy to be able to load it and view its contents while upgrading.
Fixes #10145. Turns out we were clobbering out internal data because Delphi strings are copy-on-write. At the same time, moved from using the Hint property to just referencing the source filename in the array, as that is cleaner anyway.
Fixes #10146. Some developers may wish to stick with kpj-1.0 for now, and the prompt to upgrade would annoying because it cannot be hidden. This resolves that. Note that I haven't at this point renamed UrlRenderer.pas, although it may be worth considering in the future.
Fixes #10148. We now force the SourcePath and BuildPath project properties to be a direct subfolder of the project folder, in order to avoid issues with paths in the future. This is only applied to v2.0 projects, and only enforced via the UI at this point.
Fixes #10138. If the current instance of Keyman Developer already has a project open, then the New Project dialog will now open the new project in a new instance of Keyman Developer. Note: this also moves a couple of functions out of dmActionsMain and into UfrmMain, as their functionality belongs more closely there. The `TmodActionsMain.OpenProject` function has been renamed to `TfrmMain.OpenProjectInCurrentProcess` to clarify its usage and context.
- don't skip markers when calling context_to_string()! Oops. - update docs on ldml_processor::remove_text() - update remove_text() to handle markers in the context string. This is really: #9468
1. Fcitx does not need restart to load newly installed keyman keyboard 2. Restart fcitx may cause issue on kwin/weston Wayland where input method have to be spawned by compositor process.
- copy exception table for reset from VKScanCodes.cpp - update test For: #9451
fix(linux): Do not restart Fcitx
auto: increment master version to 17.0.228
Fixes: #8069 (all of the rest are in other tickets)
jahorton
reviewed
Dec 13, 2023
Comment on lines
+10
to
+12
| <string>227D454DE9320031D7E9C3E02FEB7463B9A33776</string> | ||
| <key>installerSigningCertificate</key> | ||
| <string>C4726D4C8BD4C2FE38A551B84CEDB8E4B3FD12D6</string> | ||
| <string>227D454DE9320031D7E9C3E02FEB7463B9A33776</string> |
Contributor
There was a problem hiding this comment.
For posterity: the reason behind this early merge - iOS CI checks fail on the feature-branch without this.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
jahorton
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@keymanapp-test-bot skip