fix(linux): Do not restart Fcitx#10180
Merged
ermshiperete merged 1 commit intokeymanapp:masterfrom Dec 8, 2023
wengxt:master
Merged
fix(linux): Do not restart Fcitx#10180ermshiperete merged 1 commit intokeymanapp:masterfrom wengxt:master
ermshiperete merged 1 commit intokeymanapp:masterfrom
wengxt:master
Conversation
1. Fcitx does not need restart to load newly installed keyman keyboard 2. Restart fcitx may cause issue on kwin/weston Wayland where input method have to be spawned by compositor process.
User Test ResultsTest specification and instructions ERROR: user tests have not yet been defined Test Artifacts
|
Collaborator
|
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
Member
|
I will defer to @ermshiperete on review of this -- he may have more comments on why the reset is there at present for fcitx. |
ermshiperete
approved these changes
Dec 8, 2023
Contributor
ermshiperete
left a comment
There was a problem hiding this comment.
Thanks for your contribution! LGTM
Collaborator
|
Changes in this pull request will be available for download in Keyman version 17.0.227-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.