Fix lots of requests in single session#16
Merged
kevin1024 merged 2 commits intokevin1024:masterfrom Dec 1, 2014
Merged
Conversation
This test is actually failing for me at least part of the time on py34. This was inspired by a bug in httpie: httpie/cli#278 (comment)
that adds `Connection: Close` response header so that clients don't expect keep alives. Fixes: kevin1024#13
This was referenced Dec 1, 2014
Collaborator
Author
|
You can merge this if you like it and close #13, as @sigmavirus24 pointed out. |
kevin1024
added a commit
that referenced
this pull request
Dec 1, 2014
…ession Fix lots of requests in single session
Owner
|
@msabramo thanks for all the improvements! I'm on vacation right now so I can't do a release, but I have added you as a maintainer so you can do a release if you have time. Just bump the version number, update the release notes in the REAMDE, add a release on github, and update to pypi. Thanks again for your help! |
Collaborator
Author
|
@kevin1024: OK, I uploaded 0.0.4: https://pypi.python.org/pypi/pytest-httpbin/0.0.4 Hope you're enjoying your vacation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented on top of #13 because that adds the test whose failure this PR fixes.
Add
cleanup_headersmethod toServerHandlerthat addsConnection: Closeresponse header so that clients don't expect keep alives.Fixes: #13
Passing Travis CI build: https://travis-ci.org/kevin1024/pytest-httpbin/builds/42608004