Skip to content

Add test_httpbin_accepts_lots_of_get_requests_in_single_session#13

Merged
kevin1024 merged 1 commit intokevin1024:masterfrom
msabramo:add_test_httpbin_accepts_lots_of_get_requests_in_single_session
Dec 1, 2014
Merged

Add test_httpbin_accepts_lots_of_get_requests_in_single_session#13
kevin1024 merged 1 commit intokevin1024:masterfrom
msabramo:add_test_httpbin_accepts_lots_of_get_requests_in_single_session

Conversation

@msabramo
Copy link
Copy Markdown
Collaborator

@msabramo msabramo commented Dec 1, 2014

This test is actually failing for me at least part of the time on py34.

This was inspired by a bug in httpie:
httpie/cli#278 (comment)

@msabramo
Add test_httpbin_accepts_lots_of_get_requests_in_single_session
355a6dc 
This test is actually failing for me at least part of the time on py34.

This was inspired by a bug in httpie:
httpie/cli#278 (comment)
msabramo referenced this pull request Dec 1, 2014
@kevin1024
test lots of requests
3de8e6e
@msabramo msabramo mentioned this pull request Dec 1, 2014
Closed
@msabramo
Copy link
Copy Markdown
Collaborator Author

msabramo commented Dec 1, 2014

Notice test fails on py33 with:

=================================== FAILURES ===================================
_________ test_httpbin_accepts_lots_of_get_requests_in_single_session __________
...
        except (ProtocolError, socket.error) as err:
>           raise ConnectionError(err, request=request)
E           requests.exceptions.ConnectionError: ('Connection aborted.', BadStatusLine("''",))
../../../virtualenv/python3.4.2/lib/python3.4/site-packages/requests/adapters.py:407: ConnectionError
----------------------------- Captured stderr call -----------------------------
127.0.0.1 - - [01/Dec/2014 01:51:59] "GET /get HTTP/1.1" 200 332
===================== 1 failed, 13 passed in 1.35 seconds ======================

@msabramo
Copy link
Copy Markdown
Collaborator Author

msabramo commented Dec 1, 2014

Fails locally too:

❯ .tox/py33/bin/py.test --tb=short -k test_httpbin_accepts_lots_of_get_requests_in_single_session --pdb
============================================================================= test session starts ==============================================================================
platform darwin -- Python 3.3.3 -- py-1.4.26 -- pytest-2.6.4
plugins: httpbin
collected 14 items

tests/test_httpbin.py F
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> traceback >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
tests/test_httpbin.py:27: in test_httpbin_accepts_lots_of_get_requests_in_single_session
    assert session.get(httpbin.url + '/get').status_code == 200
.tox/py33/lib/python3.3/site-packages/requests/sessions.py:469: in get
    return self.request('GET', url, **kwargs)
.tox/py33/lib/python3.3/site-packages/requests/sessions.py:457: in request
    resp = self.send(prep, **send_kwargs)
.tox/py33/lib/python3.3/site-packages/requests/sessions.py:569: in send
    r = adapter.send(request, **kwargs)
.tox/py33/lib/python3.3/site-packages/requests/adapters.py:407: in send
    raise ConnectionError(err, request=request)
E   requests.exceptions.ConnectionError: ('Connection aborted.', BadStatusLine("''",))
>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PDB >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>
> /Users/marca/dev/git-repos/pytest-httpbin/.tox/py33/lib/python3.3/site-packages/requests/adapters.py(407)send()
-> raise ConnectionError(err, request=request)

@msabramo
Copy link
Copy Markdown
Collaborator Author

msabramo commented Dec 1, 2014

I feel like this has something to do with the fact that wsgiref is being used for HTTP/1.1. If I changed http_version to 1.0 then this test always passes.

I'm guessing it has something to do with HTTP/1.1 defaulting to using keep alives rather than closing the connection like in HTTP/1.0.

msabramo added a commit to msabramo/pytest-httpbin that referenced this pull request Dec 1, 2014
@msabramo
Add cleanup_headers to ServerHandler
f4aa78c 
that adds `Connection: Close` response header so that clients don't
expect keep alives.

Fixes: kevin1024#13
@msabramo msabramo mentioned this pull request Dec 1, 2014
Merged
@msabramo
Copy link
Copy Markdown
Collaborator Author

msabramo commented Dec 1, 2014

PR #16 appears to fix this issue for me.

$ tox
...
  py26: commands succeeded
  py27: commands succeeded
  py34: commands succeeded
  pypy: commands succeeded
  congratulations :)

@sigmavirus24
Copy link
Copy Markdown

sigmavirus24 commented Dec 1, 2014

Perhaps this should be closed since the commit is in #16

@msabramo msabramo mentioned this pull request Dec 1, 2014
Closed
@kevin1024 kevin1024 merged commit 355a6dc into kevin1024:master Dec 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msabramo @sigmavirus24 @kevin1024