Some additions / cleanup for Fermi LAT#3
Merged
Conversation
It's simpler and there are two detectors on Fermi: LAT and GBM and eventually we want to access data from both.
Owner
There was a problem hiding this comment.
Is this necessary and/or better?
Owner
There was a problem hiding this comment.
I'll merge anyway - I want all this in there fixing up my PR - but I'd like to know the motivation for this change
Author
There was a problem hiding this comment.
For me using just result gave an error because it's a requests result object, not a string.
I wonder why it works for you ....
Author
There was a problem hiding this comment.
The fact that _content has an underscore indicates we shouldn't use it.
I haven't looked at the requests documentation on this topic.
keflavich
added a commit
that referenced
this pull request
Apr 14, 2013
Some additions / cleanup for Fermi LAT
keflavich
pushed a commit
that referenced
this pull request
Aug 4, 2014
fix test_xmatch monkeypatching to use eso-ish methods
keflavich
pushed a commit
that referenced
this pull request
Sep 11, 2014
keflavich
added a commit
that referenced
this pull request
May 3, 2026
# This is the 1st commit message: add HiGal module more cleanup add changelog it is possible for a cutout to be missing; we need to allow for that. Also, the hack I had before isn't needed when you appropriately query for multiple wavelengths remove some comments, still not done with the PR minor correction added basic docs pep8 fixes. The bracket closures DO match the indentation, though. pep8 lies sometimes. add local tests and cleanup some testing more interactive tests revealed that my hacks didn't really work, this commit has some fixes move everything into astroquery.herschel.higal update relative paths whitespace # This is the commit message #2: update tests # This is the commit message #3: the higal server genuinely isn't showing anything when I search online now # This is the commit message #4: add HiGal module # This is the commit message #5: more cleanup # This is the commit message #6: add changelog # This is the commit message #7: it is possible for a cutout to be missing; we need to allow for that. Also, the hack I had before isn't needed when you appropriately query for multiple wavelengths # This is the commit message #8: remove some comments, still not done with the PR # This is the commit message #9: minor correction # This is the commit message #10: added basic docs # This is the commit message #11: pep8 fixes. The bracket closures DO match the indentation, though. pep8 lies sometimes. # This is the commit message #12: add local tests and cleanup some testing # This is the commit message #13: more interactive tests revealed that my hacks didn't really work, this commit has some fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.