Show countdown for clipboard clearing#6333
Merged
droidmonkey merged 6 commits intokeepassxreboot:developfrom Apr 1, 2021
ByteHamster:clipboard-countdown
Merged
Show countdown for clipboard clearing#6333droidmonkey merged 6 commits intokeepassxreboot:developfrom ByteHamster:clipboard-countdown
droidmonkey merged 6 commits intokeepassxreboot:developfrom
ByteHamster:clipboard-countdown
Conversation
Member
|
I don't like this at all, sorry. Condense it to one side please. |
Contributor
Author
|
Do you like this more?
I must admit that I'm pretty new to Qt. What do you think about the code structure? |
Member
|
The code is complicated but we can clean that up, there is no need for a signal slot to control the countdown. |
Contributor
Author
Could you give me a pointer what to do instead, please? |
Member
|
I am on the fence on whether the countdown updates should occur within MainWindow or the Clipboard class like you currently have. I want to re-use this progress bar setup for database decryption status and database saving as well. In order to make this more generic it would be good for the slot to accept a message along with the current progress. Also, it appears that the status bar is unstyled and rather large, we probably need to add a style to it in the stylesheets. |
Member
|
I made some styling fixes for you. See what you can do to make this more generic for other uses. BTW, just noticed you manage AntennaPod, I use that app all the time thank you! |
Sometimes the scheduling is not 100% accurate and countdownTick can get called just before a complete second has passed.
Contributor
Author
|
I renamed the slot to something more generic and added a message parameter. Now multiple signals can be connected to the same slot. Was that what you had in mind? |
Member
|
Yes it is actually perfect! I van easily add messaging like "Transforming database key" and "Saving database". Thank you! |
Member
|
Fixed a bug where the progress bar would stay visible after database lock. |
droidmonkey
approved these changes
Apr 1, 2021
Contributor
Author
|
Thanks for reviewing and merging! |
droidmonkey
added a commit
that referenced
this pull request
May 15, 2021
* Closes #1843 Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey
added a commit
that referenced
this pull request
May 15, 2021
* Closes #1843 Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey
added a commit
that referenced
this pull request
May 16, 2021
* Closes #1843 Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey
added a commit
that referenced
this pull request
May 30, 2021
* Closes #1843 Co-authored-by: Jonathan White <support@dmapps.us>
droidmonkey
added a commit
that referenced
this pull request
Jun 8, 2021
Added - Show search bar when toolbar is hidden or in overflow [#6279] - Show countdown for clipboard clearing in status bar [#6333] - Command line option to lock all open databases [#6511] - Allow CSV import of bare TOTP secrets [#6211] - Retain file creation time when saving database [#6576] - Set permissions of saved attachments to be private to the current user [#6363] - OPVault: Use Text instead of Name for attribute names [#6334] Changed - Reports: Allow resizing of reports columns [#6435] - Reports: Toggle showing expired entries [#6534] - Save Always on Top setting [#6236] - Password generator can exclude additional lookalike characters (6/G, 8/B) [#6196] Fixed - Allow setting MSI properties in unattended install [#6196] - Update MainWindow minimum size to enable smaller verticle space [#6196] - Use application font size when setting default or monospace fonts [#6332] - Fix notes not clearing in entry preview panel in some cases [#6481] - macOS: Correct window activation when restoring from tray [#6575] - macOS: Better handling of minimize after unlock when using browser integration [#6338] - Linux: Start after the system tray is available on LXQt [#6216] - Linux: Allow selection of modal dialogs on X11 in Auto-Type [#6204] - KeeShare: prevent crash when file extension is missing [#6174]
aswild
added a commit
to aswild/keepassxc
that referenced
this pull request
Jun 15, 2021
Release 2.6.5 Added - Show search bar when toolbar is hidden or in overflow [keepassxreboot#6279] - Show countdown for clipboard clearing in status bar [keepassxreboot#6333] - Command line option to lock all open databases [keepassxreboot#6511] - Allow CSV import of bare TOTP secrets [keepassxreboot#6211] - Retain file creation time when saving database [keepassxreboot#6576] - Set permissions of saved attachments to be private to the current user [keepassxreboot#6363] - OPVault: Use Text instead of Name for attribute names [keepassxreboot#6334] Changed - Reports: Allow resizing of reports columns [keepassxreboot#6435] - Reports: Toggle showing expired entries [keepassxreboot#6534] - Save Always on Top setting [keepassxreboot#6236] - Password generator can exclude additional lookalike characters (6/G, 8/B) [keepassxreboot#6196] Fixed - Allow setting MSI properties in unattended install [keepassxreboot#6196] - Update MainWindow minimum size to enable smaller verticle space [keepassxreboot#6196] - Use application font size when setting default or monospace fonts [keepassxreboot#6332] - Fix notes not clearing in entry preview panel in some cases [keepassxreboot#6481] - macOS: Correct window activation when restoring from tray [keepassxreboot#6575] - macOS: Better handling of minimize after unlock when using browser integration [keepassxreboot#6338] - Linux: Start after the system tray is available on LXQt [keepassxreboot#6216] - Linux: Allow selection of modal dialogs on X11 in Auto-Type [keepassxreboot#6204] - KeeShare: prevent crash when file extension is missing [keepassxreboot#6174] Release 2.6.6 Fixed - Fix focusing search when pressing hotkey [keepassxreboot#6603] - Trim whitespace from TOTP key input prior to processing [keepassxreboot#6604] - Fix building on macOS [keepassxreboot#6598] - Resolve compiler warnings for unused return values [keepassxreboot#6607]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double-clicking to copy a password in the list is my most-used interaction with the application. Recently, I found myself clicking 3-4 times "just to be sure" because there is no visual indication that the password was actually copied. This PR now adds a progress bar and timer message to the status bar.
Closes #1843
Screenshots
Testing strategy
Manual - clicked the item and watched the progress bar.
Type of change