Force Always on Top to be persisted#6236
Merged
droidmonkey merged 1 commit intokeepassxreboot:developfrom Mar 7, 2021
mantlabs1:always_on_top
Merged
Force Always on Top to be persisted#6236droidmonkey merged 1 commit intokeepassxreboot:developfrom mantlabs1:always_on_top
droidmonkey merged 1 commit intokeepassxreboot:developfrom
mantlabs1:always_on_top
Conversation
Member
|
I'm not adding yet another option for this. Just save the always on top setting. |
Member
|
I am against adding this, but I am definitely against adding it as another option. |
Contributor
Author
I thought you didn't want to change the existing functionality, that's why I introduced a new option. I reverted the new option and made the existing option to be saved as you told me. If you would like to add it or not, it's up to you. In my opinion this is the right approach, because it is comfortable and it is reasonable for an option to be saved if selected. Regards, |
droidmonkey
approved these changes
Mar 7, 2021
droidmonkey
added a commit
that referenced
this pull request
Jun 8, 2021
Added - Show search bar when toolbar is hidden or in overflow [#6279] - Show countdown for clipboard clearing in status bar [#6333] - Command line option to lock all open databases [#6511] - Allow CSV import of bare TOTP secrets [#6211] - Retain file creation time when saving database [#6576] - Set permissions of saved attachments to be private to the current user [#6363] - OPVault: Use Text instead of Name for attribute names [#6334] Changed - Reports: Allow resizing of reports columns [#6435] - Reports: Toggle showing expired entries [#6534] - Save Always on Top setting [#6236] - Password generator can exclude additional lookalike characters (6/G, 8/B) [#6196] Fixed - Allow setting MSI properties in unattended install [#6196] - Update MainWindow minimum size to enable smaller verticle space [#6196] - Use application font size when setting default or monospace fonts [#6332] - Fix notes not clearing in entry preview panel in some cases [#6481] - macOS: Correct window activation when restoring from tray [#6575] - macOS: Better handling of minimize after unlock when using browser integration [#6338] - Linux: Start after the system tray is available on LXQt [#6216] - Linux: Allow selection of modal dialogs on X11 in Auto-Type [#6204] - KeeShare: prevent crash when file extension is missing [#6174]
aswild
added a commit
to aswild/keepassxc
that referenced
this pull request
Jun 15, 2021
Release 2.6.5 Added - Show search bar when toolbar is hidden or in overflow [keepassxreboot#6279] - Show countdown for clipboard clearing in status bar [keepassxreboot#6333] - Command line option to lock all open databases [keepassxreboot#6511] - Allow CSV import of bare TOTP secrets [keepassxreboot#6211] - Retain file creation time when saving database [keepassxreboot#6576] - Set permissions of saved attachments to be private to the current user [keepassxreboot#6363] - OPVault: Use Text instead of Name for attribute names [keepassxreboot#6334] Changed - Reports: Allow resizing of reports columns [keepassxreboot#6435] - Reports: Toggle showing expired entries [keepassxreboot#6534] - Save Always on Top setting [keepassxreboot#6236] - Password generator can exclude additional lookalike characters (6/G, 8/B) [keepassxreboot#6196] Fixed - Allow setting MSI properties in unattended install [keepassxreboot#6196] - Update MainWindow minimum size to enable smaller verticle space [keepassxreboot#6196] - Use application font size when setting default or monospace fonts [keepassxreboot#6332] - Fix notes not clearing in entry preview panel in some cases [keepassxreboot#6481] - macOS: Correct window activation when restoring from tray [keepassxreboot#6575] - macOS: Better handling of minimize after unlock when using browser integration [keepassxreboot#6338] - Linux: Start after the system tray is available on LXQt [keepassxreboot#6216] - Linux: Allow selection of modal dialogs on X11 in Auto-Type [keepassxreboot#6204] - KeeShare: prevent crash when file extension is missing [keepassxreboot#6174] Release 2.6.6 Fixed - Fix focusing search when pressing hotkey [keepassxreboot#6603] - Trim whitespace from TOTP key input prior to processing [keepassxreboot#6604] - Fix building on macOS [keepassxreboot#6598] - Resolve compiler warnings for unused return values [keepassxreboot#6607]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regarding this issue #6231, I agree that the nature of the "Always on Top" option is to be persisted like in KeePass.
However, in order to keep the current functionality intact, and let the user decide how it will work, I made a pull request with an additional option in:
Settings -> General (Basic Settings) -> User Interface: "Force Always on Top to be persisted". Note that this option only allows persistance of the existing "Always on Top" in View submenu.
This gives the ability to the user to persist the "Always on Top" setting on "View" menu.
Screenshots
Notable code changes
Additional Settings in .ini
Testing strategy
Open the application with both settings false (default). Close the application. Re-open it. It works as in the initial state and works with "Always on Top" disabled.
Open the application with only "Always on Top" setting checked. Close the application. Re-open it. The "Always on Top" is reset to false and works with it disabled.
Open the application with only "Always on Top" setting checked. Check also the "Force Always on Top to be persisted". Close the application. Re-open it. The "Always on Top" is fetched from saved settings and is checked. "Always on Top" is enabled.
Open the application with "Always on Top" setting un-checked. Check the "Force Always on Top to be persisted". Close the application. Re-open it. The "Always on Top" remains disabled and un-checked.
Built successfully via cmake based on "develop" branch.
Run tests (all passed) with:
make test ARGS+="--output-on-failure"
Type of change