Fix waitfordeploymentreplicareadycount duration logs#6990
Merged
zroubalik merged 6 commits intokedacore:mainfrom Aug 21, 2025
Merged
Conversation
|
Thank you for your contribution! 🙏 Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected. While you are waiting, make sure to:
Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient. Learn more about our contribution guide. |
…time for runnning the asertion Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com>
90ed8a9 to
69aeac6
Compare
Contributor
Author
|
cc: @rickbrouwer |
rickbrouwer
requested changes
Aug 19, 2025
Member
rickbrouwer
left a comment
There was a problem hiding this comment.
Great! Thank you!
A few minor nits
tests/scalers/gcp/gcp_cloud_tasks_workload_identity/gcp_cloud_tasks_workload_identity_test.go
Outdated
Show resolved
Hide resolved
tests/scalers/redis/redis_standalone_streams_lag/redis_standalone_streams_lag_test.go
Outdated
Show resolved
Hide resolved
tests/scalers/redis/redis_standalone_streams_lag/redis_standalone_streams_lag_test.go
Outdated
Show resolved
Hide resolved
...rs/trigger_auth_bound_service_account_token/trigger_auth_bound_service_account_token_test.go
Outdated
Show resolved
Hide resolved
zroubalik
approved these changes
Aug 19, 2025
Member
zroubalik
left a comment
There was a problem hiding this comment.
Thanks!
Once the comments from @rickbrouwer are resolved, we can merge
Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: elieser pereira <elieser.pereiraa@gmail.com>
rickbrouwer
requested changes
Aug 19, 2025
Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: elieser pereira <elieser.pereiraa@gmail.com>
Contributor
Author
|
All check have passed but I see merging is blocked because need 2 approvers with write access. Not sure who can help @rickbrouwer @zroubalik |
Contributor
Author
|
friendly reminder, any reason for this to not get merged? |
Member
Appreciate your patience! Just waiting for the final merge, should be done soon. |
JorTurFer
approved these changes
Aug 21, 2025
jmickey
pushed a commit
to jmickey/keda
that referenced
this pull request
Aug 22, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: elieser pereira <elieser.pereiraa@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com>
3 tasks
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: elieser pereira <elieser.pereiraa@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>
alt-dima
pushed a commit
to alt-dima/keda
that referenced
this pull request
Dec 13, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: elieser pereira <elieser.pereiraa@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Dec 22, 2025
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: elieser pereira <elieser.pereiraa@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com>
tangobango5
pushed a commit
to tangobango5/keda
that referenced
this pull request
Feb 13, 2026
Signed-off-by: Elieser Pereira <elieser.pereiraa@gmail.com> Signed-off-by: elieser pereira <elieser.pereiraa@gmail.com> Co-authored-by: Rick Brouwer <rickbrouwer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated test logs to reflect the amount of time the assertion actually takes, only changed the ones using https://github.com/kedacore/keda/blob/main/tests/helper/helper.go#L466
Time for the assertion to fail is
iterations * intervalSecondsNOTE: no test changed, only the logging. Because of this Im not sure if most of the checklist bellow make sense for this PR
Checklist
Fixes #6972