Skip to content

Incorrect log lines in e2e tests #6972

@rickbrouwer

Description

@rickbrouwer

In the tests, a specific time is waited for a TestScaleIn or TestScaleOut. These times may not match the log entry.
For example, the Dynatrace scaler states that it waits 60 seconds and does so three times, so 3 minutes.
If it fails, a log entry appears stating that it failed to complete the process within the specified timeframe. The example below states 2 minutes. That is incorrect, it should be 3 minutes.

func testScaleOut(t *testing.T, kc *kubernetes.Clientset) {
t.Log("--- testing scale out ---")
stopCh := make(chan struct{})
go setMetricValue(t, 10, stopCh)
assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName, testNamespace, maxReplicaCount, 60, 3),
"replica count should be %d after 2 minutes", maxReplicaCount)
close(stopCh)

This may be incorrect for other scalers.

This issue is here to see where this might be incorrect and correct this.

Metadata

Metadata

Assignees

Labels

Type

Projects

Status

Ready To Ship

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions