-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Labels
good first issueGood for newcomersGood for newcomershelp wantedLooking for support from communityLooking for support from community
Description
In the tests, a specific time is waited for a TestScaleIn or TestScaleOut. These times may not match the log entry.
For example, the Dynatrace scaler states that it waits 60 seconds and does so three times, so 3 minutes.
If it fails, a log entry appears stating that it failed to complete the process within the specified timeframe. The example below states 2 minutes. That is incorrect, it should be 3 minutes.
keda/tests/scalers/dynatrace/dynatrace_test.go
Lines 165 to 171 in 56a023d
| func testScaleOut(t *testing.T, kc *kubernetes.Clientset) { | |
| t.Log("--- testing scale out ---") | |
| stopCh := make(chan struct{}) | |
| go setMetricValue(t, 10, stopCh) | |
| assert.True(t, WaitForDeploymentReplicaReadyCount(t, kc, deploymentName, testNamespace, maxReplicaCount, 60, 3), | |
| "replica count should be %d after 2 minutes", maxReplicaCount) | |
| close(stopCh) |
This may be incorrect for other scalers.
This issue is here to see where this might be incorrect and correct this.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedLooking for support from communityLooking for support from community
Type
Projects
Status
Ready To Ship