Add annotations to exclude labels from generated HPA and Job objects by skgsergio · Pull Request #6851 · kedacore/keda

skgsergio · 2025-06-19T13:03:14Z

Implement scaledobject.keda.sh/hpa-excluded-labels and scaledjob.keda.sh/job-excluded-labels annotations to allow excluding labels from being propagated to HPA and Job generated objects.

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6849

Relates to kedacore/keda-docs#1579

JorTurFer

I like this feature! Could you cover the change of the ScaledJob also in the already existing e2e test (scaled_job_validation_test)?

Please open another PR to docs documenting this new annotation https://github.com/kedacore/keda-docs

skgsergio · 2025-07-04T09:06:40Z

I like this feature! Could you cover the change of the ScaledJob also in the already existing e2e test (scaled_job_validation_test)?

Oops! Forgot about it because I added the Scaled Job logic later. On it.

Please open another PR to docs documenting this new annotation https://github.com/kedacore/keda-docs

It is already done: kedacore/keda-docs#1579

tests/helper/helper.go

skgsergio · 2025-07-07T11:37:26Z

@JorTurFer added the test for the ScaledJob (took me a while 😓) and improved how is tested (didn't make sense to count labels and test the remaining one so I tested the ones I didn't want are not present).

To be honest I don't know if the e2e tests work as I didn't find a way to run them locally.

zroubalik · 2025-07-07T17:20:44Z

/run-e2e internal
Update: You can check the progress here

skgsergio · 2025-07-08T06:02:07Z

🤦🏻‍♂️ test failed due to lack of quotes in the value of a label that is a number, damn YAML. Fixed.

rickbrouwer · 2025-07-09T12:51:53Z

/run-e2e internal
Update: You can check the progress here

skgsergio · 2025-07-10T07:12:23Z

I think I fixed the e2e tests for good, I'm sorry for all the running around

rickbrouwer · 2025-07-10T07:29:08Z

I think I fixed the e2e tests for good, I'm sorry for all the running around

Thanks and no problem! I will run the e2e test :)

rickbrouwer · 2025-07-10T07:29:55Z

/run-e2e internal
Update: You can check the progress here

skgsergio · 2025-07-10T08:55:39Z

🤦🏼 I hope this is the last one.

rickbrouwer · 2025-07-10T09:30:55Z

🤦🏼 I hope this is the last one.

the fossa build failed.
can you do a git commit --amend --no-edit and a git push so the checks are triggered to run again?

skgsergio · 2025-07-10T09:37:13Z

Done!

rickbrouwer · 2025-07-10T09:40:44Z

Thanks!
Can you also please mention the docs PR kedacore/keda-docs#1579 in the description of this PR?

rickbrouwer · 2025-07-10T09:47:02Z

/run-e2e internal
Update: You can check the progress here

…HPA and Job objects Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

skgsergio · 2025-07-10T11:56:30Z

Ok I'm confident this is the one. 🤞🏼

The ScaledObject tests worked and the ScaledJob had an incorrect anotation in the text fixture but actually worked.

To be honest I should have invested some time in trying to get the e2e tests to run locally, but not sure how feasible is.

rickbrouwer · 2025-07-10T13:37:02Z

/run-e2e internal
Update: You can check the progress here

JorTurFer · 2025-07-11T14:30:40Z

thanks for the contribution!

…edacore#6851) * Add annotations to exclude labels from being propagated to generated HPA and Job objects Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Improve testing Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix tests label type Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix job fetch helper function for e2e tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix scaled object excluded labels tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Use cron trigger instead of cpu on e2e test Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Use a job without secret dependencies in e2e tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix annotation in tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> --------- Signed-off-by: Sergio Conde <skgsergio@gmail.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>

…edacore#6851) * Add annotations to exclude labels from being propagated to generated HPA and Job objects Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Improve testing Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix tests label type Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix job fetch helper function for e2e tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix scaled object excluded labels tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Use cron trigger instead of cpu on e2e test Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Use a job without secret dependencies in e2e tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> * Fix annotation in tests Signed-off-by: Sergio Conde <skgsergio@gmail.com> --------- Signed-off-by: Sergio Conde <skgsergio@gmail.com>

houman-moallemi · 2025-10-14T12:55:17Z

Thank you for this PR!
It's worth considering hpa-excluded-annotations as ScaledObject passes helm annotations to HPA.

skgsergio requested a review from a team as a code owner June 19, 2025 13:03

skgsergio force-pushed the 6849-exclude-labels-from-generated-objects branch from 000f7b4 to c318fda Compare June 19, 2025 13:28

skgsergio mentioned this pull request Jun 19, 2025

Add annotations to exclude labels from being propagated to generated HPA and Job objects kedacore/keda-docs#1579

Merged

1 task

JorTurFer reviewed Jul 3, 2025

View reviewed changes

skgsergio force-pushed the 6849-exclude-labels-from-generated-objects branch from c318fda to 7b678c4 Compare July 7, 2025 11:27

semgrep-app bot reviewed Jul 7, 2025

View reviewed changes

tests/helper/helper.go Outdated Show resolved Hide resolved

skgsergio force-pushed the 6849-exclude-labels-from-generated-objects branch from 7b678c4 to a8ffa37 Compare July 7, 2025 11:32

skgsergio force-pushed the 6849-exclude-labels-from-generated-objects branch from d347829 to 72c84fc Compare July 7, 2025 11:44

skgsergio force-pushed the 6849-exclude-labels-from-generated-objects branch from 69491ba to 8d06ebf Compare July 10, 2025 07:11

skgsergio force-pushed the 6849-exclude-labels-from-generated-objects branch from cd124c5 to 79de40d Compare July 10, 2025 09:37

skgsergio added 7 commits July 10, 2025 13:54

Add annotations to exclude labels from being propagated to generated …

5c66f37

…HPA and Job objects Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Improve testing

003b1ef

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Fix tests label type

4f036e4

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Fix job fetch helper function for e2e tests

a2b1d92

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Fix scaled object excluded labels tests

8a2429c

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Use cron trigger instead of cpu on e2e test

d8d41d8

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Use a job without secret dependencies in e2e tests

25f5ad7

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

Fix annotation in tests

7aeeba0

Signed-off-by: Sergio Conde <skgsergio@gmail.com>

skgsergio force-pushed the 6849-exclude-labels-from-generated-objects branch from d103582 to 7aeeba0 Compare July 10, 2025 11:54

JorTurFer approved these changes Jul 10, 2025

View reviewed changes

rickbrouwer approved these changes Jul 11, 2025

View reviewed changes

JorTurFer merged commit ef7da8d into kedacore:main Jul 11, 2025
25 checks passed

skgsergio deleted the 6849-exclude-labels-from-generated-objects branch July 11, 2025 15:52

Conversation

skgsergio commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

skgsergio commented Jul 4, 2025

Uh oh!

Uh oh!

skgsergio commented Jul 7, 2025

Uh oh!

zroubalik commented Jul 7, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skgsergio commented Jul 8, 2025

Uh oh!

rickbrouwer commented Jul 9, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skgsergio commented Jul 10, 2025

Uh oh!

rickbrouwer commented Jul 10, 2025

Uh oh!

rickbrouwer commented Jul 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skgsergio commented Jul 10, 2025

Uh oh!

rickbrouwer commented Jul 10, 2025

Uh oh!

skgsergio commented Jul 10, 2025

Uh oh!

rickbrouwer commented Jul 10, 2025

Uh oh!

rickbrouwer commented Jul 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skgsergio commented Jul 10, 2025

Uh oh!

rickbrouwer commented Jul 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Jul 11, 2025

Uh oh!

houman-moallemi commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

skgsergio commented Jun 19, 2025 •

edited

Loading

zroubalik commented Jul 7, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 9, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 10, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 10, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 10, 2025 •

edited by github-actions bot

Loading