Add annotations to exclude labels from being propagated to generated HPA and Job objects#1579
Merged
JorTurFer merged 3 commits intokedacore:mainfrom Jul 11, 2025
Conversation
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7 tasks
cff8347 to
6b2d4ae
Compare
…HPA and Job objects Signed-off-by: Sergio Conde <sconde@tinybird.co>
6b2d4ae to
8346765
Compare
JorTurFer
approved these changes
Jul 10, 2025
Member
JorTurFer
left a comment
There was a problem hiding this comment.
let's remove the weird characters
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Sergio Conde Gómez <skgsergio@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Sergio Conde Gómez <skgsergio@gmail.com>
Contributor
Author
I don't know where they come from, either some random copy paste I did from a rendered version or maybe I accepted some AI sugestion from copilot. To be honest no clue, but didn't show on the terminal when I did the git diff. Thanks for spotting then. |
JorTurFer
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add documentation for the
scaledobject.keda.sh/hpa-excluded-labelsandscaledjob.keda.sh/job-excluded-labelsannotations.Checklist
Related to kedacore/keda#6851