New Solace Direct Messaging Scaler by alfonso-chacon · Pull Request #6546 · kedacore/keda

alfonso-chacon · 2025-02-12T23:45:39Z

New Solace Direct Messaging Scaler Added

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Fixes #6545
[#1537] (kedacore/keda-docs#1537) - Documentation

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

…scarded messages while scaling up Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

- Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

pkg/scalers/solace_dm_scaler.go

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

* Code Cleanup - CodeQL/StaticChecks

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

* Code cleanup /golangci-lint

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

pkg/scalers/solace_dm_scaler.go

JorTurFer · 2025-02-14T22:45:51Z

/run-e2e solace_dm
Update: You can check the progress here

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

JorTurFer · 2025-02-15T22:26:24Z

/run-e2e solace_dm
Update: You can check the progress here

alfonso-chacon · 2025-02-17T15:50:15Z

@JorTurFer Is there anything I can do for the failed check? its complaining about a timeout in a API

=== FAIL: pkg/scalers TestPredictKubeGetMetricSpecForScaling (3.00s)
2025/02/17 08:01:26 🚀 starting mock grpc server. On host 0.0.0.0, with port: 44809
predictkube_scaler_test.go:187:
Error Trace: /__w/keda/keda/pkg/scalers/predictkube_scaler_test.go:187
Error: Received unexpected error:
error create Prometheus client and API objects: Get "http://demo.robustperception.io:9090/api/v1/status/runtimeinfo": dialing to the given TCP address timed out
Test: TestPredictKubeGetMetricSpecForScaling
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x277cad8]

alfonso-chacon · 2025-07-17T21:29:32Z

@wozniakjan @zroubalik @JorTurFer Hi Guys! @rickbrouwer approved the pull request, can you help me with your approval?

zroubalik · 2025-07-21T15:33:16Z

/run-e2e solace_dm
Update: You can check the progress here

Copilot

Pull Request Overview

This pull request introduces a new Solace Direct Messaging scaler for KEDA, which enables scaling based on client transmission metrics from Solace message brokers. The scaler monitors aggregated client transmission rates (both message and byte rates) and queue metrics to make scaling decisions.

Key Changes

Adds a new Solace Direct Messaging scaler with support for four different transmission rate metrics
Implements comprehensive test coverage including unit tests and end-to-end integration tests
Integrates the new scaler into KEDA's scaling infrastructure

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pkg/scalers/solace_dm_scaler.go	Core implementation of the Solace Direct Messaging scaler with SEMP API integration
pkg/scalers/solace_dm_scaler_test.go	Comprehensive unit tests covering configuration parsing and validation scenarios
pkg/scaling/scalers_builder.go	Registration of the new scaler in KEDA's scaler factory
tests/scalers/solace/direct-messaging/solace_dm_test.go	End-to-end integration tests with Solace broker deployment
CHANGELOG.md	Documentation of the new feature addition

pkg/scalers/solace_dm_scaler.go

tests/scalers/solace/direct-messaging/solace_dm_test.go

JorTurFer

great job!
Just a nitpick inline, but I already keep the approval to merge the PR after comments are ready

tests/scalers/solace/direct-messaging/solace_dm_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

rickbrouwer · 2025-07-30T10:59:24Z

Hi @alfonso-chacon

Can you do a git commit --amend --no-edit? then the tests are triggered again

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

… changelog-merge

alfonso-chacon · 2025-07-30T23:14:06Z

done, smoke and e2e tests pending

rickbrouwer · 2025-07-31T05:53:17Z

/run-e2e solace_dm
Update: You can check the progress here

rickbrouwer · 2025-07-31T08:24:59Z

/run-e2e solace_dm
Update: You can check the progress here

alfonso-chacon · 2025-07-31T14:29:00Z

@zroubalik @wozniakjan Hi Guys, Can you please approve?

wozniakjan

lgtm

* * Solace Direct Messaging Scaler Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Fix D-1 queue calculation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Refactor variables Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Inlcude D-1 messages in calculation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Modify url to be able to use https protocol Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Added UnsafeSSL parameter to avoid SSL validations Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Added a factor to multiply the weight of queues messages to reduce discarded messages while scaling up Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Refactor and enhancements - Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Scaler E2E testing Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Adding New Solace Direct Messaging Scaler in CHANGELOG.md Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code Cleanup - CodeQL/StaticChecks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code cleanup /golangci-lint Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Correct order in CHANGELOG.md Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove trailing white spaces Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - change log level Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * E2E tests - reduce time in scale down cfg Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * E2E fix typo Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Avoid read secrets from metadata Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Remove constant used once Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Remove constant used once on logger init Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code cleanup recommendations - Move regex to pkg level - Remove unnecessary struct and interface Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code cleanup Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code cleanup Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Updated to sync with other sol scaler Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove unnecessary trailing newline Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Remove optional keyword for optional fields Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code fixes -move unused variables to test file -return json unmarshall error Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Removing redundant validation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove unnecessary new line Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * fix triggerMetadata syntax Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update pkg/scalers/solace_dm_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update tests/scalers/solace/direct-messaging/solace_dm_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update tests/scalers/solace/direct-messaging/solace_dm_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * fix a typo and change the ScaleUp/Down to ScaleIn/Out Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * fix a typo and change the ScaleUp/Down to ScaleIn/Out Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> --------- Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Pochopsky <david.pochopsky@united.com>

* * Solace Direct Messaging Scaler Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Fix D-1 queue calculation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Refactor variables Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Inlcude D-1 messages in calculation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Modify url to be able to use https protocol Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Added UnsafeSSL parameter to avoid SSL validations Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Added a factor to multiply the weight of queues messages to reduce discarded messages while scaling up Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Refactor and enhancements - Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Scaler E2E testing Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Adding New Solace Direct Messaging Scaler in CHANGELOG.md Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code Cleanup - CodeQL/StaticChecks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code cleanup /golangci-lint Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Correct order in CHANGELOG.md Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove trailing white spaces Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - change log level Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * E2E tests - reduce time in scale down cfg Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * E2E fix typo Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Avoid read secrets from metadata Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Remove constant used once Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Remove constant used once on logger init Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code cleanup recommendations - Move regex to pkg level - Remove unnecessary struct and interface Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code cleanup Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code cleanup Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Updated to sync with other sol scaler Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove unnecessary trailing newline Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Remove optional keyword for optional fields Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code fixes -move unused variables to test file -return json unmarshall error Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Removing redundant validation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove unnecessary new line Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * fix triggerMetadata syntax Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update pkg/scalers/solace_dm_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update tests/scalers/solace/direct-messaging/solace_dm_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update tests/scalers/solace/direct-messaging/solace_dm_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * fix a typo and change the ScaleUp/Down to ScaleIn/Out Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * fix a typo and change the ScaleUp/Down to ScaleIn/Out Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> --------- Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

* * Solace Direct Messaging Scaler Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Fix D-1 queue calculation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Refactor variables Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Inlcude D-1 messages in calculation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Modify url to be able to use https protocol Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Added UnsafeSSL parameter to avoid SSL validations Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Added a factor to multiply the weight of queues messages to reduce discarded messages while scaling up Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Refactor and enhancements - Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Scaler E2E testing Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Adding New Solace Direct Messaging Scaler in CHANGELOG.md Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code Cleanup - CodeQL/StaticChecks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code cleanup /golangci-lint Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Correct order in CHANGELOG.md Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove trailing white spaces Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - remove comment Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Cleanup code - change log level Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * E2E tests - reduce time in scale down cfg Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * E2E fix typo Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Avoid read secrets from metadata Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Remove constant used once Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Remove constant used once on logger init Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code cleanup recommendations - Move regex to pkg level - Remove unnecessary struct and interface Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Code cleanup Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code cleanup Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Updated to sync with other sol scaler Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove unnecessary trailing newline Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * Remove optional keyword for optional fields Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * Code fixes -move unused variables to test file -return json unmarshall error Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Removing redundant validation Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * Remove unnecessary new line Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * fix triggerMetadata syntax Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update pkg/scalers/solace_dm_scaler.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update tests/scalers/solace/direct-messaging/solace_dm_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * Update tests/scalers/solace/direct-messaging/solace_dm_test.go Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> * * fix a typo and change the ScaleUp/Down to ScaleIn/Out Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> * * fix a typo and change the ScaleUp/Down to ScaleIn/Out Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> --------- Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

alfonso-chacon added 11 commits January 31, 2025 22:45

* Solace Direct Messaging Scaler

2eab88e

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Fix D-1 queue calculation

e7a401b

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Refactor variables

5bc9f84

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Inlcude D-1 messages in calculation

a4569b4

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Modify url to be able to use https protocol

5cd2c34

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Added UnsafeSSL parameter to avoid SSL validations

22e01b5

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Added a factor to multiply the weight of queues messages to reduce di…

c805b34

…scarded messages while scaling up Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Refactor and enhancements

6dabb42

- Added Configuration validations - Variables Refactor - Multiple URLs - Remove commented blocks Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

* Scaler E2E testing

81cdd14

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Adding New Solace Direct Messaging Scaler in CHANGELOG.md

4a9658b

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Merge branch 'main' into changelog-merge

660f78d

Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

github-advanced-security bot found potential problems Feb 13, 2025

View reviewed changes

pkg/scalers/solace_dm_scaler.go Fixed Show fixed Hide fixed

alfonso-chacon added 6 commits February 12, 2025 21:00

* Code Cleanup - CodeQL/StaticChecks

b387be3

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Merge pull request #1 from alfonso-chacon/main

94ebcb4

* Code Cleanup - CodeQL/StaticChecks

* Code cleanup /golangci-lint

df7168a

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Merge pull request #2 from alfonso-chacon/main

87fbac5

* Code cleanup /golangci-lint

* Correct order in CHANGELOG.md

9423f60

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

* Remove trailing white spaces

34c283a

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

alfonso-chacon marked this pull request as ready for review February 13, 2025 04:27

alfonso-chacon requested a review from a team as a code owner February 13, 2025 04:27

JorTurFer reviewed Feb 14, 2025

View reviewed changes

alfonso-chacon and others added 6 commits February 15, 2025 00:37

* Cleanup code - remove comment

03baab6

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

* Cleanup code - remove comment

bfb0c59

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

* Cleanup code - remove comment

886e402

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

* Cleanup code - change log level

0dd0153

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

* E2E tests - reduce time in scale down cfg

3035023

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

* E2E fix typo

2fa0250

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

zroubalik requested a review from Copilot July 21, 2025 15:33

Copilot AI reviewed Jul 21, 2025

View reviewed changes

Merge branch 'main' into changelog-merge

6f93a71

JorTurFer approved these changes Jul 22, 2025

View reviewed changes

tests/scalers/solace/direct-messaging/solace_dm_test.go Outdated Show resolved Hide resolved

rickbrouwer added the waiting-author-response All PR's or Issues where we are waiting for a response from the author label Jul 29, 2025

alfonso-chacon and others added 5 commits July 29, 2025 10:07

fix triggerMetadata syntax

cb4f7ef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

Update pkg/scalers/solace_dm_scaler.go

ed58966

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

Update tests/scalers/solace/direct-messaging/solace_dm_test.go

6ed93cd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

Update tests/scalers/solace/direct-messaging/solace_dm_test.go

fb7caa0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>

Merge branch 'main' into changelog-merge

ed9a8b9

rickbrouwer removed the waiting-author-response All PR's or Issues where we are waiting for a response from the author label Jul 29, 2025

* fix a typo and change the ScaleUp/Down to ScaleIn/Out

bef3ad2

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

alfonso-chacon added 2 commits July 30, 2025 09:32

* fix a typo and change the ScaleUp/Down to ScaleIn/Out

d0b4197

Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>

Merge branch 'changelog-merge' of github.com:alfonso-chacon/keda into…

a5ff9fa

… changelog-merge

rickbrouwer added the ok-to-merge This PR can be merged label Jul 31, 2025

wozniakjan enabled auto-merge (squash) August 8, 2025 09:13

wozniakjan approved these changes Aug 8, 2025

View reviewed changes

wozniakjan merged commit 56a023d into kedacore:main Aug 8, 2025
24 checks passed

alfonso-chacon deleted the changelog-merge branch September 6, 2025 00:11

Conversation

alfonso-chacon commented Feb 12, 2025 • edited by zroubalik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Feb 14, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Feb 15, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alfonso-chacon commented Feb 17, 2025

Uh oh!

alfonso-chacon commented Jul 17, 2025

Uh oh!

zroubalik commented Jul 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rickbrouwer commented Jul 30, 2025

Uh oh!

alfonso-chacon commented Jul 30, 2025

Uh oh!

rickbrouwer commented Jul 31, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Jul 31, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alfonso-chacon commented Jul 31, 2025

Uh oh!

wozniakjan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alfonso-chacon commented Feb 12, 2025 •

edited by zroubalik

Loading

JorTurFer commented Feb 14, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Feb 15, 2025 •

edited by github-actions bot

Loading

zroubalik commented Jul 21, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 31, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Jul 31, 2025 •

edited by github-actions bot

Loading