Merged
Conversation
Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
6 tasks
zroubalik
reviewed
Feb 18, 2025
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>
Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>
- Added HPA Algorithm URL reference Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>
Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>
Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>
Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>
Signed-off-by: Alfonso Chacón <alfonso.chacon@solace.com>
Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces documentation for the new Solace Direct Messaging scaler while updating references in the event queue scaler documentation.
- Updated solace-pub-sub.md to include a note differentiating between Direct Messaging and Guaranteed Messaging triggers.
- Added a new file, solace-pub-sub-dm.md, detailing the specification, parameters, and examples for the Direct Messaging scaler.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| content/docs/2.18/scalers/solace-pub-sub.md | Added clarification note regarding usage of Direct Messaging vs. Guaranteed Messaging |
| content/docs/2.18/scalers/solace-pub-sub-dm.md | Introduced new Direct Messaging scaler documentation with detailed trigger examples |
Comments suppressed due to low confidence (1)
content/docs/2.18/scalers/solace-pub-sub-dm.md:65
- The parameter name 'clientNamePrefix' in the requirements does not match the 'clientNamePattern' used in the trigger metadata. Please update for consistency.
- Parameters resolving the target host and shared subscription are all **required:** `solaceSempBaseURL`, `messageVpn`, `clientNamePrefix`
wozniakjan
reviewed
Apr 24, 2025
Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: alfonso-chacon <alfonso.chacon@solace.com>
zroubalik
approved these changes
Jul 21, 2025
JorTurFer
approved these changes
Jul 22, 2025
JorTurFer
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Solace Direct Messaging Scaler Documentation
Checklist
Fixes #
Related to #6545