Splunk observability scaler by sschimper-splunk · Pull Request #6534 · kedacore/keda

sschimper-splunk · 2025-02-07T13:29:00Z

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
[] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

JorTurFer

Thanks for the contribution! Some comments inline
Apart from them, please execute go mod tidy & go mod vendor and commit the output

tests/scalers/splunk_observability/splunk_observability_test.go

pkg/scalers/splunk_observability_scaler.go

pkg/scalers/splunk_observability_scaler_test.go

tests/scalers/splunk_observability/splunk_observability_test.go

JorTurFer · 2025-07-21T21:03:59Z

/run-e2e splunk_observability
Update: You can check the progress here

JorTurFer · 2025-07-28T09:11:33Z

/run-e2e splunk_observability
Update: You can check the progress here

JorTurFer · 2025-07-30T19:11:42Z

/run-e2e splunk_observability
Update: You can check the progress here

rickbrouwer · 2025-08-06T10:40:25Z

I see there are some merge conflicts.

JorTurFer

awesome contribution! just a nitpick inline

pkg/scalers/splunk_observability_scaler.go

rickbrouwer · 2025-08-11T09:13:33Z

Hi @sschimper-splunk

I think there are also some changes that shouldn't have been included (see CHANGELOG entries).
And maybe you have already seen it, but there's also a merge conflict.

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Add Splunk Observability scaler Implement a new scaler for Splunk Observability to allow KEDA to scale workloads based on metrics from Splunk Observability. Includes unit tests and environment configuration updates.

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolved merge conflict in CHANGELOG.md.

…names and propagate context to getQueryResult() func Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolving merge conflict in go.mod file.

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

…eal credention Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

…cloud Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolved merge conflict in go.mod.

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolve merge conflict in vendor/modules.txt

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

…erying Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

…observability_scaler_test.go Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

JorTurFer

AWESOME job! just a nitpick inline

pkg/scalers/splunk_observability_scaler.go

sschimper-splunk · 2025-10-01T18:45:35Z

Hi @rickbrouwer, thanks, I fixed it and pushed it again. Sorry, I did not notice it at first

…. I should go to sleep Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

rickbrouwer · 2025-10-01T19:06:59Z

/run-e2e splunk_observability
Update: You can check the progress here

sschimper-splunk · 2025-10-01T19:41:11Z

I see that the static test "CI / validate - amd64 (pull_request)" is failing due to lack of disk space. I will look into this first thing in the morning. Please let me know if you have any suggestions. Thank you.

rickbrouwer · 2025-10-02T05:23:07Z

I see that the static test "CI / validate - amd64 (pull_request)" is failing due to lack of disk space. I will look into this first thing in the morning. Please let me know if you have any suggestions. Thank you.

You can push your last commit again, so the job will be triggered again :)

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

wozniakjan · 2025-10-02T07:19:54Z

I see that the static test "CI / validate - amd64 (pull_request)" is failing due to lack of disk space. I will look into this first thing in the morning. Please let me know if you have any suggestions. Thank you.

I have seen this on a few other unrelated PRs, it seems like KEDA pipeline is using close to maximum of disk capacity. We may want to explore https://github.com/easimon/maximize-build-space or some other alternatives

EDIT: fyi #7150

wozniakjan · 2025-10-02T07:20:01Z

/run-e2e splunk_observability
Update: You can check the progress here

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

sschimper-splunk · 2025-10-02T09:31:39Z

I re-pushed 2 times, and I am not able to resolve the disk issue

rickbrouwer · 2025-10-02T09:45:18Z

I re-pushed 2 times, and I am not able to resolve the disk issue

@wozniakjan is working on solving this (#7150)

wozniakjan · 2025-10-02T14:33:55Z

@sschimper-splunk can you please rebase on latest main branch? #7150 merged.

zroubalik · 2025-10-02T14:36:02Z

@sschimper-splunk can you please rebase on latest main branch? #7150 merged.

I will trigger the rebase

zroubalik

@sschimper-splunk last nit, could you please open an issue like this one: #6576

and reference it here and in the docs PR and also in the changelog instead of the PR link?

Thanks!

sschimper-splunk · 2025-10-02T15:18:20Z

@zroubalik added issue here: #7152

rickbrouwer · 2025-10-02T15:31:32Z

@zroubalik added issue here: #7152

Thanks! Can you change the description of this PR and adjust it to the created issue? And can you also link the created issue in the CHANGELOG.md instead of the pull?

zroubalik · 2025-10-03T09:20:00Z

@zroubalik added issue here: #7152

Thanks! Can you change the description of this PR and adjust it to the created issue? And can you also link the created issue in the CHANGELOG.md instead of the pull?

I'll do that, to not block us

CHANGELOG.md

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

zroubalik · 2025-10-03T09:21:12Z

/run-e2e splunk
Update: You can check the progress here

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com>

sschimper-splunk requested a review from a team as a code owner February 7, 2025 13:29

sschimper-splunk mentioned this pull request Feb 7, 2025

Feature/splunk observability scaler #6192

Closed

6 tasks

JorTurFer reviewed Feb 9, 2025

View reviewed changes

sschimper-splunk force-pushed the splunk-observability-scaler branch from 8114ced to f767f24 Compare May 13, 2025 08:27

semgrep-app bot reviewed Jul 10, 2025

View reviewed changes

tests/scalers/splunk_observability/splunk_observability_test.go Outdated Show resolved Hide resolved

rickbrouwer added the waiting-author-response All PR's or Issues where we are waiting for a response from the author label Aug 6, 2025

JorTurFer reviewed Aug 7, 2025

View reviewed changes

pkg/scalers/splunk_observability_scaler.go Outdated Show resolved Hide resolved

rickbrouwer removed the waiting-author-response All PR's or Issues where we are waiting for a response from the author label Aug 11, 2025

Sebastian Schimper added 13 commits August 12, 2025 10:29

added updated changelog for splunk observability scaler

a995265

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolved merge conflict in CHANGELOG.md.

working in PR feedback from JorTurFer, alinging lines, changing test …

96baade

…names and propagate context to getQueryResult() func Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolving merge conflict in go.mod file.

working in feedback from failed 'Static Checks' test

77573b8

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

removed logging access creds from e2e test file, since we are using r…

2e0545c

…eal credention Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

moved signalflow query description to .env for e2e test

3ddfde2

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

e2e test - added goroutine to automatically send data to Splunk O11y …

016b8f3

…cloud Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

e2e test: hard-coded signlaflow query

d4f8a72

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

synced changes with official commits from KEDA

de37d8c

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolved merge conflict in go.mod.

fix: sync vendor after go mod tidy

fa13b33

Signed-off-by: Sebastian Schimper <sschimper@splunk.com> Resolve merge conflict in vendor/modules.txt

replaced sleep function to stop signalflow computation with goroutine

6ce5ba9

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

changed getQueryResult func to use context passed in to do metrics qu…

1caf348

…erying Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

tidying up vendor files

8b315a5

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

sschimper-splunk force-pushed the splunk-observability-scaler branch from 307f9c1 to 8b315a5 Compare August 13, 2025 13:56

Sebastian Schimper added 2 commits August 15, 2025 13:14

fixing formatting issue in CHANGELOG.md file and smal typo in splunk_…

2869619

…observability_scaler_test.go Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

fixed wrong sorting in CHANGELOG.md file

792bcc6

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

JorTurFer reviewed Aug 16, 2025

View reviewed changes

pkg/scalers/splunk_observability_scaler.go Outdated Show resolved Hide resolved

fixed failed static check by adding a new line at the end of the file…

9c4e320

…. I should go to sleep Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

sschimper-splunk mentioned this pull request Oct 1, 2025

feat: splunk observability scaler docs kedacore/keda-docs#1630

Merged

1 task

recommitting last commit to trigger CI again

4569f51

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

chore: retrigger CI

7bb95f1

Signed-off-by: Sebastian Schimper <sschimper@splunk.com>

Merge branch 'main' into splunk-observability-scaler

a261a31

zroubalik reviewed Oct 2, 2025

View reviewed changes

sschimper-splunk mentioned this pull request Oct 2, 2025

Support Splunk Observability Cloud Scaler #7152

Closed

zroubalik approved these changes Oct 3, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

6ebe15c

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

keda-automation requested a review from a team October 3, 2025 09:20

Merge branch 'main' into splunk-observability-scaler

c30a118

zroubalik enabled auto-merge (squash) October 3, 2025 09:21

zroubalik merged commit 33e1dfd into kedacore:main Oct 3, 2025
24 checks passed

Conversation

sschimper-splunk commented Feb 7, 2025 • edited by zroubalik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Jul 21, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Jul 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Jul 30, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rickbrouwer commented Aug 6, 2025

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rickbrouwer commented Aug 11, 2025

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sschimper-splunk commented Oct 1, 2025

Uh oh!

rickbrouwer commented Oct 1, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sschimper-splunk commented Oct 1, 2025

Uh oh!

rickbrouwer commented Oct 2, 2025

Uh oh!

wozniakjan commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan commented Oct 2, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sschimper-splunk commented Oct 2, 2025

Uh oh!

rickbrouwer commented Oct 2, 2025

Uh oh!

wozniakjan commented Oct 2, 2025

Uh oh!

zroubalik commented Oct 2, 2025

Uh oh!

zroubalik left a comment

Choose a reason for hiding this comment

Uh oh!

sschimper-splunk commented Oct 2, 2025

Uh oh!

rickbrouwer commented Oct 2, 2025

Uh oh!

zroubalik commented Oct 3, 2025

Uh oh!

Uh oh!

zroubalik commented Oct 3, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

sschimper-splunk commented Feb 7, 2025 •

edited by zroubalik

Loading

JorTurFer commented Jul 21, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Jul 28, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Jul 30, 2025 •

edited by github-actions bot

Loading

rickbrouwer commented Oct 1, 2025 •

edited by github-actions bot

Loading

wozniakjan commented Oct 2, 2025 •

edited

Loading

wozniakjan commented Oct 2, 2025 •

edited by github-actions bot

Loading

zroubalik commented Oct 3, 2025 •

edited by github-actions bot

Loading