Skip to content

ci: clear some disk space for PR validation step#7150

Merged
wozniakjan merged 2 commits intokedacore:mainfrom
wozniakjan:ci_pr_validation_clear_space
Oct 2, 2025
Merged

ci: clear some disk space for PR validation step#7150
wozniakjan merged 2 commits intokedacore:mainfrom
wozniakjan:ci_pr_validation_clear_space

Conversation

@wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Oct 2, 2025

tl;dr: this prolongs the step execution by ~4 minutes but frees up ~13 GB space, which means tests don't run out of disk space.


There is a number of PRs that fail the PR validation step on amd64 runner due to low disk space

# github.com/kedacore/keda/v2/controllers/keda [github.com/kedacore/keda/v2/controllers/keda.test]
compile: writing output: write $WORK/b2581/_pkg_.a: no space left on device
FAIL	github.com/kedacore/keda/v2/controllers/keda [build failed]
# github.com/kedacore/keda/v2/controllers/keda/util
# [github.com/kedacore/keda/v2/controllers/keda/util]
vet: failed to export analysis facts: write $WORK/b2588/vet.out: no space left on device
github.com/kedacore/keda/v2/pkg/mock/mock_eventemitter: mkdir /tmp/go-build1683534545/b2594/: no space left on device

For a quick fix to unblock PRs from merging, I would like to propose adding a step that removes some unnecessary software from GH actions runner. Later, we can explore why the disk space usage grew above the allocated limit.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

@wozniakjan wozniakjan requested a review from a team as a code owner October 2, 2025 08:23
@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Thank you for your contribution! 🙏

Please understand that we will do our best to review your PR and give you feedback as soon as possible, but please bear with us if it takes a little longer as expected.

While you are waiting, make sure to:

  • Add an entry in our changelog in alphabetical order and link related issue
  • Update the documentation, if needed
  • Add unit & e2e tests for your changes
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Once the initial tests are successful, a KEDA member will ensure that the e2e tests are run. Once the e2e tests have been successfully completed, the PR may be merged at a later date. Please be patient.

Learn more about our contribution guide.

@keda-automation keda-automation requested a review from a team October 2, 2025 08:23
@wozniakjan wozniakjan mentioned this pull request Oct 2, 2025
6 tasks
@wozniakjan wozniakjan force-pushed the ci_pr_validation_clear_space branch from 2d0b9df to d8df418 Compare October 2, 2025 08:36
@keda-automation keda-automation requested a review from a team October 2, 2025 08:36
@wozniakjan wozniakjan force-pushed the ci_pr_validation_clear_space branch 2 times, most recently from 0da1a60 to 5f84cf5 Compare October 2, 2025 08:41
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan force-pushed the ci_pr_validation_clear_space branch from 5f84cf5 to 61aee71 Compare October 2, 2025 08:43
@wozniakjan
Copy link
Member Author

hmm, I didn't realize it runs in a container and the step uses: easimon/maximize-build-space@master can't be executed there

 13     container: ghcr.io/kedacore/keda-tools:1.23.8

I will close this, we may need to figure out an alternative way

@wozniakjan wozniakjan closed this Oct 2, 2025
@wozniakjan wozniakjan reopened this Oct 2, 2025
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan force-pushed the ci_pr_validation_clear_space branch from 6f9e23e to 5c232a4 Compare October 2, 2025 11:24
@keda-automation keda-automation requested a review from a team October 2, 2025 11:24
@wozniakjan
Copy link
Member Author

wozniakjan commented Oct 2, 2025

I will close this, we may need to figure out an alternative way

I take that back, we can use bindmount to delete some extra cruft (haskell, android SDK, .NET) from the host disk. Despite the claims from easimon/maximize-build-space, I see only ~13GB extra after the cleanup, but this should suffice for some time.

@rickbrouwer rickbrouwer added the ok-to-merge This PR can be merged label Oct 2, 2025
@wozniakjan wozniakjan merged commit 58ff4cb into kedacore:main Oct 2, 2025
25 checks passed
clement-mesureux pushed a commit to clement-mesureux/keda that referenced this pull request Oct 2, 2025
* ci: clear some disk space for PR validation step

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* ci: cleanup disk space through container

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

---------

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
clement-mesureux pushed a commit to clement-mesureux/keda that referenced this pull request Oct 2, 2025
* ci: clear some disk space for PR validation step

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* ci: cleanup disk space through container

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

---------

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
alt-dima pushed a commit to alt-dima/keda that referenced this pull request Dec 13, 2025
* ci: clear some disk space for PR validation step

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* ci: cleanup disk space through container

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

---------

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Dec 22, 2025
* ci: clear some disk space for PR validation step

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* ci: cleanup disk space through container

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

---------

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
tangobango5 pushed a commit to tangobango5/keda that referenced this pull request Feb 13, 2026
* ci: clear some disk space for PR validation step

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

* ci: cleanup disk space through container

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>

---------

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-merge This PR can be merged skip-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants