new forgejo scaler by cobak78 · Pull Request #6495 · kedacore/keda

cobak78 · 2025-01-22T14:40:16Z

This PR adds a new forgejo autoscaler with the same characteristics of the github autoscaler.

Fixes: #6488

Docs PR: kedacore/keda-docs#1577

Another important discussions on this topic:

The issue on forgejo with the new endpoint needed to make this autoscaler work. https://codeberg.org/forgejo/discussions/issues/241
The accepted PR https://codeberg.org/forgejo/forgejo/pulls/6300
The modifications on the forgejo runner to work as a scaled job. https://code.forgejo.org/forgejo/runner/pulls/423

Checklist

When introducing a new scaler, I agree with the scaling governance policy
I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
A PR is opened to update the documentation on (repo) (if applicable)
Commits are signed with Developer Certificate of Origin (DCO - learn more)

pkg/scalers/forgejo_runner_scaler_test.go

pkg/scalers/forgejo_runner_scaler.go

pkg/scalers/forgejo_runner_scaler_test.go

JorTurFer

Thanks a lot for your contribution! I've left some comment inline. Additionally to them:

Please, add an e2e test covering the scaler. You get more info about how to do it here
Could you open a PR to docs adding the scaler in next version?
All commits must be signed and that's why DCO check is failing, please rebase your branch signing all the commits (how to do that it's explained in the check page)

pkg/scalers/forgejo/action.go

pkg/scalers/forgejo_runner_scaler.go

pkg/scalers/forgejo_runner_scaler_test.go

tests/scalers/forgejo_runner/app.ini

zroubalik

@cobak78 what is the status of this PR please?

ChristopherHX

I wondered why your tests still do not compile in CI, maybe you forget to fix them after removing JobsListResponse during Refactoring?

Or is the whole additional test file obsolete?

pkg/scalers/forgejo_runner_scaler_test.go

JorTurFer · 2025-05-20T07:26:50Z

/run-e2e forgejo
Update: You can check the progress here

JorTurFer · 2025-05-27T08:40:48Z

/run-e2e forgejo
Update: You can check the progress here

tests/scalers/forgejo_runner/forgejo_runner_test.go

JorTurFer · 2025-06-05T12:06:52Z

/run-e2e forgejo
Update: You can check the progress here

cobak78 · 2025-06-05T14:40:38Z

added the PR on the doc repository
kedacore/keda-docs#1577

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

tests/scalers/forgejo_runner/forgejo_runner_test.go

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-09-22T07:31:14Z

/run-e2e forgejo
Update: You can check the progress here

Copilot

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-09-22T08:25:25Z

/run-e2e forgejo
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-09-22T10:10:04Z

/run-e2e forgejo
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-09-22T10:51:05Z

/run-e2e forgejo
Update: You can check the progress here

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer · 2025-09-22T11:27:44Z

/run-e2e forgejo
Update: You can check the progress here

wozniakjan

lgtm, thank you!

zroubalik

Docs PR needs an update: kedacore/keda-docs#1577

JorTurFer · 2025-09-28T10:36:55Z

Docs PR needs an update: kedacore/keda-docs#1577

true, mb. Let me update docs

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

semgrep-app · 2025-09-28T10:49:17Z

Semgrep found 1 invalid-usage-of-modified-variable finding:

pkg/scaling/scalers_builder.go
- L93-108 - Triage

Variable scaler is likely modified and later used on error. In some cases this could result in panics due to a nil dereference

JorTurFer · 2025-09-28T11:16:35Z

/run-e2e forgejo
Update: You can check the progress here

JorTurFer · 2025-09-28T19:44:39Z

PTAL @zroubalik

* new forgejo scaler with tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * delete not needed package Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * use pascal case for tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * change forgejo endpoints response Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * improve testing Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * minimal e2e testing, local with local images Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix unit test Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * linter fixes Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * linter fixes Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * linter fixes Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * minimal e2e testing, using test image tool Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * edit CHANGELOG.md Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * comment fixes and improvements Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * comment fixes and improvements Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Move token to secret for e2e Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Move token to secret for e2e Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update schema Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update schema Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> --------- Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> Signed-off-by: Jaime <cobak78@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> Co-authored-by: jaime merino <jaime.merino_mora@mail.schwarz> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge.turrado@mail.schwarz> Signed-off-by: Dmitriy Altuhov <altuhovd@gmail.com>

* new forgejo scaler with tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * delete not needed package Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * use pascal case for tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * change forgejo endpoints response Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * improve testing Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * minimal e2e testing, local with local images Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix unit test Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * linter fixes Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * linter fixes Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * linter fixes Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * minimal e2e testing, using test image tool Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * fix error checks on unit tests Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * add new database update to modify timestamp of the pending job Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * edit CHANGELOG.md Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * comment fixes and improvements Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * comment fixes and improvements Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Update pkg/scalers/forgejo_runner_scaler.go Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jaime <cobak78@gmail.com> * Move token to secret for e2e Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * Move token to secret for e2e Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update schema Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update schema Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * update test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> * fix test Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> --------- Signed-off-by: jaime merino <jaime.merino_mora@mail.schwarz> Signed-off-by: Jaime <cobak78@gmail.com> Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz> Co-authored-by: jaime merino <jaime.merino_mora@mail.schwarz> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Co-authored-by: Jorge Turrado <jorge.turrado@mail.schwarz>

cobak78 requested a review from a team as a code owner January 22, 2025 14:40

cobak78 force-pushed the forgejo-runner-scaler branch from 03fd3a1 to 39fd60d Compare January 22, 2025 14:43

semgrep-app bot reviewed Jan 22, 2025

View reviewed changes

pkg/scalers/forgejo_runner_scaler_test.go Outdated Show resolved Hide resolved

semgrep-app bot reviewed Jan 22, 2025

View reviewed changes

pkg/scalers/forgejo_runner_scaler.go Outdated Show resolved Hide resolved

semgrep-app bot reviewed Jan 22, 2025

View reviewed changes

pkg/scalers/forgejo_runner_scaler_test.go Outdated Show resolved Hide resolved

semgrep-app bot reviewed Jan 22, 2025

View reviewed changes

pkg/scalers/forgejo_runner_scaler_test.go Outdated Show resolved Hide resolved

cobak78 force-pushed the forgejo-runner-scaler branch 2 times, most recently from 5b9d520 to f13dbc7 Compare January 23, 2025 11:41

JorTurFer reviewed Jan 24, 2025

View reviewed changes

cobak78 force-pushed the forgejo-runner-scaler branch 6 times, most recently from 6b7ca20 to a63882e Compare January 29, 2025 09:45

semgrep-app bot reviewed Mar 12, 2025

View reviewed changes

tests/scalers/forgejo_runner/app.ini Outdated Show resolved Hide resolved

semgrep-app bot reviewed Mar 12, 2025

View reviewed changes

tests/scalers/forgejo_runner/app.ini Outdated Show resolved Hide resolved

zroubalik reviewed Mar 26, 2025

View reviewed changes

cobak78 mentioned this pull request May 7, 2025

Forgejo 11 image for testing purposes kedacore/test-tools#219

Merged

2 tasks

ChristopherHX reviewed May 7, 2025

View reviewed changes

cobak78 force-pushed the forgejo-runner-scaler branch from d7de903 to 5db4208 Compare May 12, 2025 14:50

cobak78 force-pushed the forgejo-runner-scaler branch from 1fac30d to fcbeff9 Compare May 19, 2025 15:11

cobak78 force-pushed the forgejo-runner-scaler branch from 9c4b8af to 072caca Compare May 26, 2025 06:35

semgrep-app bot reviewed Jun 5, 2025

View reviewed changes

tests/scalers/forgejo_runner/forgejo_runner_test.go Outdated Show resolved Hide resolved

semgrep-app bot reviewed Jun 5, 2025

View reviewed changes

tests/scalers/forgejo_runner/forgejo_runner_test.go Outdated Show resolved Hide resolved

cobak78 force-pushed the forgejo-runner-scaler branch from 56441c6 to 1f88ea6 Compare June 5, 2025 10:28

Copilot AI reviewed Sep 22, 2025

View reviewed changes

Move token to secret for e2e

99c5961

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer requested a review from Copilot September 22, 2025 07:31

Copilot AI reviewed Sep 22, 2025

View reviewed changes

JorTurFer added 2 commits September 22, 2025 09:55

update schema

529e1f3

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

update schema

29592a2

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

update test

27541e8

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

JorTurFer added 2 commits September 22, 2025 12:31

fix test

a8a952e

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

fix test

19706aa

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

fix test

8299b05

Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>

wozniakjan approved these changes Sep 23, 2025

View reviewed changes

wozniakjan enabled auto-merge (squash) September 24, 2025 07:05

zroubalik reviewed Sep 26, 2025

View reviewed changes

Merge branch 'main' into forgejo-runner-scaler

7b04923

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

keda-automation requested a review from a team September 28, 2025 10:37

JorTurFer added 2 commits September 28, 2025 12:45

apply feedback

6b289a3

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

apply feedback

f5db629

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

wozniakjan merged commit 72f94ad into kedacore:main Sep 30, 2025
24 checks passed

Conversation

cobak78 commented Jan 22, 2025 • edited by zroubalik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zroubalik left a comment

Choose a reason for hiding this comment

Uh oh!

ChristopherHX left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented May 20, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented May 27, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Jun 5, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cobak78 commented Jun 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JorTurFer commented Sep 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

JorTurFer commented Sep 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Sep 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Sep 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Sep 22, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan left a comment

Choose a reason for hiding this comment

Uh oh!

zroubalik left a comment

cobak78 commented Jan 22, 2025 •

edited by zroubalik

Loading

JorTurFer left a comment •

edited

Loading

JorTurFer commented May 20, 2025 •

edited by github-actions bot

Loading

JorTurFer commented May 27, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Jun 5, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Sep 22, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Sep 22, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Sep 22, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Sep 22, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Sep 22, 2025 •

edited by github-actions bot

Loading

JorTurFer commented Sep 28, 2025 •

edited by github-actions bot

Loading