forgejo/forgejo
forgejo/forgejo
111
4.0k
Fork 696
Code Issues 1.2k Pull requests 154 Releases 97 Packages 1 Activity Actions 50

Add search action jobs for API routes, repo, org and global level #6300

Merged
earl-warren merged 17 commits from cobak78/forgejo:list-job-endpoints into forgejo 2025-01-14 12:17:48 +01:00
Conversation 12 Commits 17 Files changed 22 +640 -22
cobak78 commented 2024-12-17 17:09:06 +01:00
Member
Copy link

This PR wants to improve information of the tasks waiting to be executed on a global, organization, user and repository leve.
The main motivation is explained here forgejo/discussions#241

Checklist

The contributor guide contains information that will be helpful to first time contributors. There also are a few conditions for merging Pull Requests in Forgejo repositories. You are also welcome to join the Forgejo development chatroom.

Tests

  • I added test coverage for Go changes...
    • in their respective *_test.go for unit tests.
    • in the tests/integration directory if it involves interactions with a live Forgejo server.
  • I added test coverage for JavaScript changes...

Documentation

  • I created a pull request to the documentation to explain to Forgejo users how to use this change.
  • I did not document these changes and I do not expect someone else to do it.

Release notes

  • I do not want this change to show in the release notes.
  • I want the title to show in the release notes with a link to this pull request.
  • I want the content of the release-notes/<pull request number>.md to be be used for the release notes instead of the title.

Release notes

  • Features
    • PR: Add search action jobs for API routes, repo, org and global level
This PR wants to improve information of the tasks waiting to be executed on a global, organization, user and repository leve. The main motivation is explained here https://codeberg.org/forgejo/discussions/issues/241 ## Checklist The [contributor guide](https://forgejo.org/docs/next/contributor/) contains information that will be helpful to first time contributors. There also are a few [conditions for merging Pull Requests in Forgejo repositories](https://codeberg.org/forgejo/governance/src/branch/main/PullRequestsAgreement.md). You are also welcome to join the [Forgejo development chatroom](https://matrix.to/#/#forgejo-development:matrix.org). ### Tests - I added test coverage for Go changes... - [x] in their respective `*_test.go` for unit tests. - [x] in the `tests/integration` directory if it involves interactions with a live Forgejo server. - I added test coverage for JavaScript changes... - [ ] in `web_src/js/*.test.js` if it can be unit tested. - [ ] in `tests/e2e/*.test.e2e.js` if it requires interactions with a live Forgejo server (see also the [developer guide for JavaScript testing](https://codeberg.org/forgejo/forgejo/src/branch/forgejo/tests/e2e/README.md#end-to-end-tests)). ### Documentation - [ ] I created a pull request [to the documentation](https://codeberg.org/forgejo/docs) to explain to Forgejo users how to use this change. - [x] I did not document these changes and I do not expect someone else to do it. ### Release notes - [ ] I do not want this change to show in the release notes. - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Features - [PR](https://codeberg.org/forgejo/forgejo/pulls/6300): <!--number 6300 --><!--line 0 --><!--description QWRkIHNlYXJjaCBhY3Rpb24gam9icyBmb3IgQVBJIHJvdXRlcywgcmVwbywgb3JnIGFuZCBnbG9iYWwgbGV2ZWw=-->Add search action jobs for API routes, repo, org and global level<!--description--> <!--end release-notes-assistant-->
Gusted reviewed 2024-12-18 00:35:25 +01:00
modules/structs/action.go Outdated
@ -0,0 +1,22 @@
package structs
Gusted commented 2024-12-18 00:35:22 +01:00
Owner
Copy link

Please add license headers.

Please add license headers.
cobak78 marked this conversation as resolved
routers/api/v1/shared/runners.go Outdated
@ -33,0 +44,4 @@
func GetActionRunJobs(ctx *context.APIContext, ownerID int64, repoID int64) {
labels := strings.Split(ctx.FormTrim("labels"), ",")
log.Printf("labels: %v", labels)
Gusted commented 2024-12-18 00:29:36 +01:00
Owner
Copy link

Left debug statement.

Left debug statement.
cobak78 marked this conversation as resolved
routers/api/v1/shared/runners.go Outdated
@ -33,0 +81,4 @@
return res
}
func isSubset(set, subset []string) bool {
Gusted commented 2024-12-18 00:31:42 +01:00
Owner
Copy link

Please move this function to modules/container/subset.go as this is also defined in in models/actions/task.go.

Please move this function to `modules/container/subset.go` as this is also defined in in `models/actions/task.go`.
cobak78 marked this conversation as resolved
earl-warren 2024-12-19 07:26:32 +01:00
earl-warren commented 2024-12-19 07:27:56 +01:00
Contributor
Copy link

This looks interesting 👍 Would you mind switching to WIP: until it is ready for a review? Removing the WIP: will notify me and I'll take a look 🙏

This looks interesting 👍 Would you mind switching to WIP: until it is ready for a review? Removing the WIP: will notify me and I'll take a look 🙏
cobak78 changed title from Add search action jobs for API routes, repo, org and global level to WIP: Add search action jobs for API routes, repo, org and global level 2024-12-19 09:11:26 +01:00
cobak78 force-pushed list-job-endpoints from 1d68fab1c5
Some checks failed
requirements / merge-conditions (pull_request) Failing after 2s
Details
issue-labels / release-notes (pull_request_target) Has been skipped
Details
testing / frontend-checks (pull_request) Successful in 53s
Details
testing / backend-checks (pull_request) Failing after 1m23s
Details
testing / test-unit (pull_request) Has been skipped
Details
testing / test-e2e (pull_request) Has been skipped
Details
testing / test-mysql (pull_request) Has been skipped
Details
testing / test-pgsql (pull_request) Has been skipped
Details
testing / test-sqlite (pull_request) Has been skipped
Details
testing / test-remote-cacher (redis) (pull_request) Has been skipped
Details
testing / test-remote-cacher (valkey) (pull_request) Has been skipped
Details
testing / test-remote-cacher (garnet) (pull_request) Has been skipped
Details
testing / test-remote-cacher (redict) (pull_request) Has been skipped
Details
testing / security-check (pull_request) Has been skipped
Details
to 53b405e3cc
Some checks failed
requirements / merge-conditions (pull_request) Failing after 2s
Details
issue-labels / release-notes (pull_request_target) Has been skipped
Details
testing / frontend-checks (pull_request) Successful in 53s
Details
testing / backend-checks (pull_request) Failing after 1m22s
Details
testing / test-unit (pull_request) Has been skipped
Details
testing / test-e2e (pull_request) Has been skipped
Details
testing / test-mysql (pull_request) Has been skipped
Details
testing / test-pgsql (pull_request) Has been skipped
Details
testing / test-sqlite (pull_request) Has been skipped
Details
testing / test-remote-cacher (redis) (pull_request) Has been skipped
Details
testing / test-remote-cacher (valkey) (pull_request) Has been skipped
Details
testing / test-remote-cacher (garnet) (pull_request) Has been skipped
Details
testing / test-remote-cacher (redict) (pull_request) Has been skipped
Details
testing / security-check (pull_request) Has been skipped
Details
2024-12-19 14:43:45 +01:00 Compare
cobak78 changed title from WIP: Add search action jobs for API routes, repo, org and global level to Add search action jobs for API routes, repo, org and global level 2024-12-19 16:42:21 +01:00
forgejo-release-notes-assistant commented 2024-12-20 08:12:55 +01:00
Member
Copy link
Where does that come from? The following is a preview of the release notes for this pull request, as they will appear in the upcoming release. They are derived from the content of the `release-notes/6300.md` file, if it exists, or the title of the pull request. They were also added at the bottom of the description of this pull request for easier reference.

This message and the release notes originate from a call to the release-notes-assistant.

@@ -25,2 +25,10 @@
 - [x] I want the title to show in the release notes with a link to this pull request.
 - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title.
+
+<!--start release-notes-assistant-->
+
+## Release notes
+<!--URL:https://codeberg.org/forgejo/forgejo-->
+- Features
+  - [PR](https://codeberg.org/forgejo/forgejo/pulls/6300): <!--number 6300 --><!--line 0 --><!--description QWRkIHNlYXJjaCBhY3Rpb24gam9icyBmb3IgQVBJIHJvdXRlcywgcmVwbywgb3JnIGFuZCBnbG9iYWwgbGV2ZWw=-->Add search action jobs for API routes, repo, org and global level<!--description-->
+<!--end release-notes-assistant-->

Release notes

  • Features
    • PR: Add search action jobs for API routes, repo, org and global level
<details> <summary>Where does that come from?</summary> The following is a preview of the release notes for this pull request, as they will appear in the upcoming release. They are derived from the content of the `release-notes/6300.md` file, if it exists, or the title of the pull request. They were also added at the bottom of the description of this pull request for easier reference. This message and the release notes originate from a call to the [release-notes-assistant](https://code.forgejo.org/forgejo/release-notes-assistant). ```diff @@ -25,2 +25,10 @@ - [x] I want the title to show in the release notes with a link to this pull request. - [ ] I want the content of the `release-notes/<pull request number>.md` to be be used for the release notes instead of the title. + +<!--start release-notes-assistant--> + +## Release notes +<!--URL:https://codeberg.org/forgejo/forgejo--> +- Features + - [PR](https://codeberg.org/forgejo/forgejo/pulls/6300): <!--number 6300 --><!--line 0 --><!--description QWRkIHNlYXJjaCBhY3Rpb24gam9icyBmb3IgQVBJIHJvdXRlcywgcmVwbywgb3JnIGFuZCBnbG9iYWwgbGV2ZWw=-->Add search action jobs for API routes, repo, org and global level<!--description--> +<!--end release-notes-assistant--> ``` </details> <!--start release-notes-assistant--> ## Release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Features - [PR](https://codeberg.org/forgejo/forgejo/pulls/6300): <!--number 6300 --><!--line 0 --><!--description QWRkIHNlYXJjaCBhY3Rpb24gam9icyBmb3IgQVBJIHJvdXRlcywgcmVwbywgb3JnIGFuZCBnbG9iYWwgbGV2ZWw=-->Add search action jobs for API routes, repo, org and global level<!--description--> <!--end release-notes-assistant-->
cobak78 force-pushed list-job-endpoints from 560e526c89
Some checks failed
testing / frontend-checks (pull_request) Successful in 58s
Details
testing / backend-checks (pull_request) Successful in 2m44s
Details
testing / test-e2e (pull_request) Successful in 3m4s
Details
testing / test-unit (pull_request) Successful in 4m56s
Details
testing / test-remote-cacher (redis) (pull_request) Successful in 1m45s
Details
testing / test-remote-cacher (valkey) (pull_request) Successful in 1m44s
Details
testing / test-remote-cacher (garnet) (pull_request) Successful in 1m46s
Details
testing / test-remote-cacher (redict) (pull_request) Successful in 1m47s
Details
testing / test-mysql (pull_request) Failing after 24m29s
Details
testing / test-sqlite (pull_request) Failing after 26m33s
Details
testing / test-pgsql (pull_request) Failing after 30m51s
Details
testing / security-check (pull_request) Has been skipped
Details
issue-labels / backporting (pull_request_target) Has been skipped
Details
issue-labels / cascade (pull_request_target) Has been skipped
Details
requirements / merge-conditions (pull_request) Successful in 2s
Details
issue-labels / release-notes (pull_request_target) Successful in 40s
Details
to 5b3d42cff4
Some checks failed
requirements / merge-conditions (pull_request) Successful in 2s
Details
issue-labels / release-notes (pull_request_target) Successful in 23s
Details
testing / frontend-checks (pull_request) Successful in 48s
Details
testing / backend-checks (pull_request) Successful in 2m53s
Details
testing / test-e2e (pull_request) Successful in 3m4s
Details
testing / test-unit (pull_request) Successful in 4m59s
Details
testing / test-remote-cacher (redis) (pull_request) Successful in 1m50s
Details
testing / test-remote-cacher (valkey) (pull_request) Successful in 1m50s
Details
testing / test-remote-cacher (garnet) (pull_request) Successful in 2m27s
Details
testing / test-remote-cacher (redict) (pull_request) Successful in 2m15s
Details
testing / test-mysql (pull_request) Failing after 20m19s
Details
testing / test-sqlite (pull_request) Failing after 22m8s
Details
testing / test-pgsql (pull_request) Failing after 26m6s
Details
testing / security-check (pull_request) Has been skipped
Details
2024-12-20 11:16:33 +01:00 Compare
Gusted reviewed 2024-12-21 03:34:35 +01:00
modules/container/set.go Outdated
@ -30,2 +30,4 @@
}
func (s Set[T]) IsSubset(subset []T) bool {
if len(subset) < 1 {
Gusted commented 2024-12-21 03:30:52 +01:00
Owner
Copy link

len(subset) == 0 is a more idomatic way to do this.

`len(subset) == 0` is a more idomatic way to do this.
Gusted commented 2024-12-21 03:31:51 +01:00
Owner
Copy link

Is there a good reason to do this? This isn't how subsets in mathematics are defined, for which \emptyset \in S holds true for every set S.

Is there a good reason to do this? This isn't how subsets in mathematics are defined, for which $\emptyset \in S$ holds true for every set $S$.
cobak78 commented 2024-12-23 13:09:32 +01:00
Author
Member
Copy link

A possible solution would be to keep the function mathematically correct and move the equality check against 0 to where it is called. However, I think it would be more appropriate to create a specific function for the labels, called ItRunsOn.

A possible solution would be to keep the function mathematically correct and move the equality check against 0 to where it is called. However, I think it would be more appropriate to create a specific function for the labels, called ItRunsOn.
👍 1
cobak78 marked this conversation as resolved
tests/integration/api_org_actions_test.go Outdated
@ -0,0 +1,35 @@
package integration
Gusted commented 2024-12-21 03:32:47 +01:00
Owner
Copy link

Missing copyright headers.

Missing copyright headers.
cobak78 marked this conversation as resolved
tests/integration/api_repo_actions_test.go Outdated
@ -0,0 +1,40 @@
package integration
Gusted commented 2024-12-21 03:34:28 +01:00
Owner
Copy link

Ditto

Ditto
cobak78 marked this conversation as resolved
tests/integration/api_user_actions_test.go Outdated
@ -0,0 +1,35 @@
package integration
Gusted commented 2024-12-21 03:34:33 +01:00
Owner
Copy link

Ditto

Ditto
cobak78 marked this conversation as resolved
cobak78 force-pushed list-job-endpoints from 67c98bfe3b
Some checks failed
requirements / merge-conditions (pull_request) Successful in 2s
Details
issue-labels / release-notes (pull_request_target) Successful in 37s
Details
testing / frontend-checks (pull_request) Successful in 50s
Details
testing / backend-checks (pull_request) Failing after 2m7s
Details
testing / test-unit (pull_request) Has been skipped
Details
testing / test-e2e (pull_request) Has been skipped
Details
testing / test-mysql (pull_request) Has been skipped
Details
testing / test-pgsql (pull_request) Has been skipped
Details
testing / test-sqlite (pull_request) Has been skipped
Details
testing / test-remote-cacher (redis) (pull_request) Has been skipped
Details
testing / test-remote-cacher (valkey) (pull_request) Has been skipped
Details
testing / test-remote-cacher (garnet) (pull_request) Has been skipped
Details
testing / test-remote-cacher (redict) (pull_request) Has been skipped
Details
testing / security-check (pull_request) Has been skipped
Details
Integration tests for the release process / release-simulation (pull_request) Successful in 5m4s
Details
to bdb16e66d5
Some checks failed
requirements / merge-conditions (pull_request) Successful in 2s
Details
issue-labels / release-notes (pull_request_target) Successful in 34s
Details
testing / frontend-checks (pull_request) Successful in 1m36s
Details
testing / backend-checks (pull_request) Failing after 1m44s
Details
testing / test-unit (pull_request) Has been skipped
Details
testing / test-e2e (pull_request) Has been skipped
Details
testing / test-mysql (pull_request) Has been skipped
Details
testing / test-pgsql (pull_request) Has been skipped
Details
testing / test-sqlite (pull_request) Has been skipped
Details
testing / test-remote-cacher (redis) (pull_request) Has been skipped
Details
testing / test-remote-cacher (valkey) (pull_request) Has been skipped
Details
testing / test-remote-cacher (garnet) (pull_request) Has been skipped
Details
testing / test-remote-cacher (redict) (pull_request) Has been skipped
Details
testing / security-check (pull_request) Has been skipped
Details
2025-01-08 15:05:57 +01:00 Compare
cobak78 force-pushed list-job-endpoints from 854412aca1
Some checks failed
requirements / merge-conditions (pull_request) Successful in 2s
Details
issue-labels / release-notes (pull_request_target) Successful in 22s
Details
testing / frontend-checks (pull_request) Successful in 1m1s
Details
testing / backend-checks (pull_request) Successful in 2m53s
Details
testing / test-e2e (pull_request) Successful in 2m33s
Details
testing / test-unit (pull_request) Successful in 3m25s
Details
testing / test-remote-cacher (valkey) (pull_request) Successful in 54s
Details
testing / test-remote-cacher (redis) (pull_request) Successful in 57s
Details
testing / test-remote-cacher (garnet) (pull_request) Successful in 53s
Details
testing / test-remote-cacher (redict) (pull_request) Successful in 53s
Details
testing / test-mysql (pull_request) Failing after 16m25s
Details
testing / test-sqlite (pull_request) Failing after 17m57s
Details
testing / test-pgsql (pull_request) Failing after 21m43s
Details
testing / security-check (pull_request) Has been skipped
Details
to 4e30805b26
Some checks failed
testing / frontend-checks (pull_request) Successful in 1m47s
Details
testing / backend-checks (pull_request) Successful in 5m39s
Details
testing / test-e2e (pull_request) Successful in 3m10s
Details
testing / test-unit (pull_request) Successful in 3m52s
Details
testing / test-remote-cacher (redis) (pull_request) Successful in 1m18s
Details
testing / test-remote-cacher (valkey) (pull_request) Successful in 1m17s
Details
testing / test-mysql (pull_request) Failing after 21m48s
Details
testing / test-remote-cacher (garnet) (pull_request) Successful in 1m17s
Details
testing / test-remote-cacher (redict) (pull_request) Successful in 1m7s
Details
testing / test-sqlite (pull_request) Failing after 21m41s
Details
testing / test-pgsql (pull_request) Failing after 26m22s
Details
testing / security-check (pull_request) Has been skipped
Details
requirements / merge-conditions (pull_request) Successful in 1s
Details
issue-labels / release-notes (pull_request_target) Successful in 39s
Details
2025-01-09 08:51:50 +01:00 Compare
viceice reviewed 2025-01-10 09:35:30 +01:00
viceice left a comment
Owner
Copy link

adding a jobs api seems useful. i think i find use-cases beside autoscaling

adding a jobs api seems useful. i think i find use-cases beside autoscaling
models/actions/run_job_test.go Outdated
@ -0,0 +1,25 @@
// SPDX-License-Identifier: MIT
viceice commented 2025-01-10 09:34:44 +01:00
Owner
Copy link

Are you open to use GPL-3.0-or-later for new files ?

Are you open to use `GPL-3.0-or-later` for new files ?
earl-warren approved these changes 2025-01-10 09:52:24 +01:00
earl-warren left a comment
Contributor
Copy link

Excellent work.

Excellent work.
❤️ 1
earl-warren changed title from Add search action jobs for API routes, repo, org and global level to WIP: Add search action jobs for API routes, repo, org and global level 2025-01-13 07:58:29 +01:00
earl-warren commented 2025-01-13 07:58:55 +01:00
Contributor
Copy link

Please remove the WIP: prefix once the tests pass.

Please remove the WIP: prefix once the tests pass.
cobak78 changed title from WIP: Add search action jobs for API routes, repo, org and global level to Add search action jobs for API routes, repo, org and global level 2025-01-13 10:40:27 +01:00
earl-warren commented 2025-01-13 14:37:53 +01:00
Contributor
Copy link

The failure is related.

https://codeberg.org/forgejo/forgejo/actions/runs/52489/jobs/8#jobstep-5-2657

Could you please check that the tests run successfully before removing the WIP:? It signals me that I should take a look and that would save me a little time 🙏

The failure is related. https://codeberg.org/forgejo/forgejo/actions/runs/52489/jobs/8#jobstep-5-2657 Could you please check that the tests run successfully before removing the WIP:? It signals me that I should take a look and that would save me a little time 🙏
👍 1
earl-warren changed title from Add search action jobs for API routes, repo, org and global level to WIP: Add search action jobs for API routes, repo, org and global level 2025-01-13 14:38:09 +01:00
cobak78 changed title from WIP: Add search action jobs for API routes, repo, org and global level to Add search action jobs for API routes, repo, org and global level 2025-01-14 10:57:03 +01:00
cobak78 force-pushed list-job-endpoints from 7db327a1b3
All checks were successful
testing / frontend-checks (pull_request) Successful in 59s
Details
testing / backend-checks (pull_request) Successful in 3m39s
Details
Integration tests for the release process / release-simulation (pull_request) Successful in 5m8s
Details
testing / test-e2e (pull_request) Successful in 3m31s
Details
testing / test-unit (pull_request) Successful in 4m5s
Details
testing / test-remote-cacher (redis) (pull_request) Successful in 1m4s
Details
testing / test-remote-cacher (valkey) (pull_request) Successful in 1m2s
Details
testing / test-remote-cacher (garnet) (pull_request) Successful in 1m4s
Details
testing / test-remote-cacher (redict) (pull_request) Successful in 1m6s
Details
testing / test-mysql (pull_request) Successful in 20m23s
Details
testing / test-sqlite (pull_request) Successful in 21m7s
Details
testing / test-pgsql (pull_request) Successful in 25m32s
Details
testing / security-check (pull_request) Successful in 1m47s
Details
requirements / merge-conditions (pull_request) Successful in 2s
Details
issue-labels / release-notes (pull_request_target) Successful in 23s
Details
to bfac9a8e94
All checks were successful
requirements / merge-conditions (pull_request) Successful in 1s
Details
issue-labels / release-notes (pull_request_target) Successful in 22s
Details
testing / frontend-checks (pull_request) Successful in 53s
Details
testing / backend-checks (pull_request) Successful in 3m14s
Details
testing / test-e2e (pull_request) Successful in 3m5s
Details
testing / test-unit (pull_request) Successful in 5m17s
Details
testing / test-remote-cacher (redis) (pull_request) Successful in 1m50s
Details
testing / test-remote-cacher (garnet) (pull_request) Successful in 1m49s
Details
testing / test-remote-cacher (redict) (pull_request) Successful in 1m49s
Details
testing / test-remote-cacher (valkey) (pull_request) Successful in 1m51s
Details
testing / test-mysql (pull_request) Successful in 18m11s
Details
testing / test-sqlite (pull_request) Successful in 20m26s
Details
testing / test-pgsql (pull_request) Successful in 24m6s
Details
testing / security-check (pull_request) Successful in 1m3s
Details
issue-labels / backporting (pull_request_target) Has been skipped
Details
milestone / set (pull_request_target) Successful in 10s
Details
2025-01-14 10:57:22 +01:00 Compare
earl-warren commented 2025-01-14 12:18:45 +01:00
Contributor
Copy link

@cobak78 this will be deployed on https://v11.next.forgejo.org and you'll be able to check how it behaves for real. 🚀

@cobak78 this will be deployed on https://v11.next.forgejo.org and you'll be able to check how it behaves for real. 🚀
❤️ 1
emilylange reviewed 2025-02-22 23:14:35 +01:00
routers/api/v1/shared/runners.go
@ -33,0 +55,4 @@
}
res := new(RunJobList)
res.Body = fromRunJobModelToResponse(total, labels)
emilylange commented 2025-02-22 23:14:34 +01:00
Member
Copy link

Is there a particular reason why the response is wrapped in body?

This is different from virtually any other endpoint I looked at and the generated Swagger schema is wrong.

Lines 1013 to 1016 in 75b9bd8
"responses": {
"200": {
"$ref": "#/responses/RunJobList"
},

Lines 28982 to 28990 in 75b9bd8
"RunJobList": {
"description": "RunJobList is a list of action run jobs",
"schema": {
"type": "array",
"items": {
"$ref": "#/definitions/ActionRunJob"
}
}
},

An example response looks like

{
  "body": [
    {
      "id": 1,
      "repo_id": 1,
      "owner_id": 1,
      "name": "name",
      "needs": null,
      "runs_on": [
        "native"
      ],
      "task_id": 0,
      "status": "waiting"
    }
  ]
}

while the schema suggests:

[
  {
    "id": 1,
    "repo_id": 1,
    "owner_id": 1,
    "name": "name",
    "needs": null,
    "runs_on": [
      "native"
    ],
    "task_id": 0,
    "status": "waiting"
  }
]

Similarly, an empty result looks like

{
  "body": null
}

instead of

[]
Is there a particular reason why the response is wrapped in `body`? This is different from virtually any other endpoint I looked at and the generated Swagger schema is wrong. https://codeberg.org/forgejo/forgejo/src/commit/75b9bd82e8a4fe4de0e04d3a236be4036750754e/templates/swagger/v1_json.tmpl#L1013-L1016 https://codeberg.org/forgejo/forgejo/src/commit/75b9bd82e8a4fe4de0e04d3a236be4036750754e/templates/swagger/v1_json.tmpl#L28982-L28990 An example response looks like ~~~json { "body": [ { "id": 1, "repo_id": 1, "owner_id": 1, "name": "name", "needs": null, "runs_on": [ "native" ], "task_id": 0, "status": "waiting" } ] } ~~~ while the schema suggests: ~~~json [ { "id": 1, "repo_id": 1, "owner_id": 1, "name": "name", "needs": null, "runs_on": [ "native" ], "task_id": 0, "status": "waiting" } ] ~~~ Similarly, an empty result looks like ~~~json { "body": null } ~~~ instead of ~~~json [] ~~~
Gusted commented 2025-02-23 21:58:25 +01:00
Owner
Copy link

Huh, that's interesting. Could you open a new issue so it can be marked as an release blocker?

Huh, that's interesting. Could you open a new issue so it can be marked as an release blocker?
earl-warren commented 2025-02-24 08:15:23 +01:00
Contributor
Copy link

@cobak78 FYI

@cobak78 FYI
cobak78 commented 2025-02-24 11:11:02 +01:00
Author
Member
Copy link

Yes, you're right, good catch. I think I mistakenly copied that result from a Swagger definition instead of a real response. Here's a small PR to fix it. #7050

Yes, you're right, good catch. I think I mistakenly copied that result from a Swagger definition instead of a real response. Here's a small PR to fix it. https://codeberg.org/forgejo/forgejo/pulls/7050
👍 1
earl-warren reviewed 2025-04-25 09:16:29 +02:00
routers/web/shared/actions/runners.go
@ -80,3 +80,3 @@
PageSize: 30,
},
Status: actions_model.StatusUnknown, // Unknown means all
Status: []actions_model.Status{actions_model.StatusUnknown}, // Unknown means all
earl-warren commented 2025-04-25 09:16:29 +02:00
Contributor
Copy link

See #7643. The field should have been removed instead to ensure all tasks are listed.

See https://codeberg.org/forgejo/forgejo/issues/7643. The field should have been removed instead to ensure all tasks are listed.
Sign in to join this conversation.
Reviewers
No reviewers
caesar
crystal
Gusted
earl-warren
Labels
Clear labels   
arch
riscv64

Archived

  
backport/v1.19

Scheduled for backport to Forgejo v1.19

Archived

  
backport/v1.20

Scheduled for backport to Forgejo v1.20

Archived

  
backport/v1.21/forgejo

Scheduled for backport to Forgejo v1.21

Archived

  
backport/v10.0/forgejo

Automated backport to v10.0

Archived

  
backport/v11.0/forgejo

Automated backport to v11.0

  
backport/v12.0/forgejo

Automated backport to v12.0

Archived

  
backport/v13.0/forgejo

Automated backport to v13.0

Archived

  
backport/v14.0/forgejo

Automated backport to v14.0

  
backport/v15.0/forgejo

Automated backport to v15.0

  
backport/v7.0/forgejo

Scheduled for backport to Forgejo v7.0

Archived

  
backport/v8.0/forgejo

Scheduled for backport to Forgejo v8.0

Archived

  
backport/v9.0/forgejo

Scheduled for backport to Forgejo v9.0

Archived

  
breaking

The release containing this change is not backward compatible

  
bug

Something is not working

Archived

  
bug
confirmed
it can be reproduced

  
bug
duplicate
bug has already been reported in the Forgejo tracker

  
bug
needs-more-info
the information provided does not contain enough details

  
bug
new-report
bug has just been reported and need triage (default label on issue creation)

  
bug
reported-upstream
bug cannot be fixed within Forgejo easily, it has been reported upstream

  
code/actions

Forgejo Actions feature

  
code/api

API

  
code/auth

Forgejo Authentication

  
code/auth/faidp

Forgejo as Identity Provider (in OAuth/OIDC flow)

  
code/auth/farp

Forgejo as Relying Party / Client (in OAuth/OIDC flow)

  
code/email

Everything related to email in Forgejo

  
code/federation

Federation

  
code/git

Related to the Git backend in Forgejo

  
code/migrations

Migration between Git forges (i.e. for GitHub, GitLab, Gitea, Forgejo, etc.). NOT for database migrations.

  
code/packages

Forgejo package and container registry

  
code/wiki
  
database
MySQL
https://www.mysql.com/

  
database
PostgreSQL
https://www.postgresql.org/

  
database
SQLite
https://sqlite.org/

  
dependency-upgrade

https://codeberg.org/forgejo/forgejo/issues/2779

  
dependency
certmagic
github.com/caddyserver/certmagic

Archived

  
dependency
chart.js
https://github.com/chartjs/Chart.js

Archived

  
dependency
Chi
https://github.com/go-chi/chi/

Archived

  
dependency
Chroma
https://github.com/alecthomas/chroma/

Archived

  
dependency
citation.js
https://github.com/larsgw/citation.js/

Archived

  
dependency
codespell
https://github.com/codespell-project/codespell

Archived

  
dependency
css-loader
https://github.com/webpack-contrib/css-loader

Archived

  
dependency
devcontainers
https://github.com/devcontainers/cli

Archived

  
dependency
dropzone
https://github.com/dropzone/dropzone

Archived

  
dependency
editorconfig-checker
https://github.com/editorconfig-checker/editorconfig-checker

Archived

  
dependency
elasticsearch
https://www.elastic.co/elasticsearch

Archived

  
dependency
enmime
https://github.com/jhillyerd/enmime

Archived

  
dependency
F3
https://f3.forgefriends.org/

  
dependency
ForgeFed
https://forgefed.org

  
dependency
garage
https://git.deuxfleurs.fr/Deuxfleurs/garage

  
dependency
Git
https://git-scm.com/

Archived

  
dependency
git-backporting
https://github.com/kiegroup/git-backporting

Archived

  
dependency
Gitea
https://github.com/go-gitea/gitea

  
dependency
gitignore
https://github.com/github/gitignore

Archived

  
dependency
go-ap
https://github.com/go-ap/activitypub

Archived

  
dependency
go-enry
https://github.com/go-enry/go-enry

Archived

  
dependency
go-gitlab
https://github.com/xanzy/go-gitlab

Archived

  
dependency
Go-org
https://github.com/niklasfasching/go-org

Archived

  
dependency
go-rpmutils
https://github.com/sassoftware/go-rpmutils

Archived

  
dependency
go-sql-driver mysql
https://github.com/go-sql-driver/mysql/

Archived

  
dependency
go-swagger
github.com/go-swagger/go-swagger

Archived

  
dependency
go-version
https://github.com/hashicorp/go-version

Archived

  
dependency
go-webauthn
https://github.com/go-webauthn/webauthn

Archived

  
dependency
gocron
https://github.com/go-co-op/gocron

Archived

  
dependency
Golang
https://go.dev/

  
dependency
goldmark
https://github.com/yuin/goldmark

Archived

  
dependency
goquery
github.com/PuerkitoBio/goquery

Archived

  
dependency
Goth
https://github.com/markbates/goth/

Archived

  
dependency
grpc-go
https://github.com/grpc/grpc-go

Archived

  
dependency
happy-dom
https://github.com/capricorn86/happy-dom

Archived

  
dependency
Helm
https://helm.sh/

Archived

  
dependency
image-spec
https://github.com/opencontainers/image-spec

Archived

  
dependency
jsonschema
https://github.com/santhosh-tekuri/jsonschema

Archived

  
dependency
KaTeX
https://github.com/KaTeX/KaTeX

Archived

  
dependency
lint
All linting tools and libraries

Archived

  
dependency
MariaDB
https://mariadb.com/

Archived

  
dependency
Mermaid
https://github.com/mermaid-js/mermaid/

Archived

  
dependency
minio-go
https://github.com/minio/minio-go/

Archived

  
dependency
misspell
github.com/golangci/misspell/cmd/misspell

Archived

  
dependency
Monaco
https://github.com/microsoft/monaco-editor

Archived

  
dependency
PDFobject
https://pdfobject.com/

Archived

  
dependency
playwright
https://playwright.dev/

Archived

  
dependency
postcss
https://github.com/postcss/postcss

Archived

  
dependency
postcss-plugins
https://github.com/csstools/postcss-plugins

Archived

  
dependency
pprof
https://github.com/google/pprof

Archived

  
dependency
prometheus client_golang
https://github.com/prometheus/client_golang

Archived

  
dependency
protobuf
https://google.golang.org/protobuf

Archived

  
dependency
relative-time-element
https://github.com/github/relative-time-element

Archived

  
dependency
renovate
https://github.com/renovatebot/renovate

Archived

  
dependency
reply
https://code.forgejo.org/forgejo/reply

Archived

  
dependency
ssh
https://github.com/gliderlabs/ssh

Archived

  
dependency
swagger-ui
https://github.com/swagger-api/swagger-ui

Archived

  
dependency
tailwind
https://tailwindcss.com/

Archived

  
dependency
temporal-polyfill
https://github.com/fullcalendar/temporal-polyfill

Archived

  
dependency
terminal-to-html
github.com/buildkite/terminal-to-html

Archived

  
dependency
tests-only
Undifferentiated dependencies used for testing only

Archived

  
dependency
text-expander-element
https://github.com/github/text-expander-element

Archived

  
dependency
urfave
https://github.com/urfave/cli

Archived

  
dependency
vfsgen
https://github.com/lunny/vfsgen

Archived

  
dependency
vite
https://vitejs.dev/

Archived

  
dependency
Woodpecker CI
https://woodpecker-ci.org/

Archived

  
dependency
x tools
https://golang.org/x/tools

Archived

  
dependency
XORM
https://gitea.com/xorm/xorm

Archived

  
Discussion

   
duplicate

This issue or pull request already exists

  
enhancement/feature

New feature

  
forgejo/accessibility

Accessibility (a11y)

  
forgejo/branding

Branding (logo, name, tagline etc.)

  
forgejo/ci

Forgejo Actions CI configuration

  
forgejo/commit-graph

The commit graph feature and page.

  
forgejo/documentation

   
forgejo/furnace cleanup

Keeping Forgejo in sync with its dependencies and contributing back to them

Archived

  
forgejo/i18n

t9n/translation, l10n/localization, and i18n/internationalization of Forgejo

  
forgejo/interop

Interoperability with other services: Webhooks, bridges, integrations

  
forgejo/moderation

Moderation

  
forgejo/privacy

Privacy first

  
forgejo/release

Release management

  
forgejo/scaling

Performance and scaling

  
forgejo/security

Security (please disclose responsibly)

  
forgejo/ui

User interface

  
Gain
High
User research provides indicators that this would be good to have, interested contributors are encouraged to pick this.

  
Gain
Nice to have
This is likely worth having, but the assumption is not backed by user research data (it might benefit a small amount of users only.) Unlikely to receive much attention, but feel free to pick.

  
Gain
Undefined
Not enough information to assess the request's benefits. This issue may be closed if no gain is established: You can help by giving us more input.

  
Gain
Very High
User research indicates that this is an important improvement for Forgejo users. Contributions very welcome!

  
good first issue

Optimal for first-timers! Make sure to look for further explanations and ask for help if needed. If you want, you can consider the person who added this label as a point of contact.

  
i18n/backport-stable

This PR needs to be backported to stable branch of Forgejo safely and manually, using a migration script.

  
impact
large
Large impact: Potential data loss, many users affected, major degradation in UX.

  
impact
medium
Medium impact: Several users affected, degradation in UX, workarounds might be available but inconvenient.

  
impact
small
Small impact: No data loss, workarounds might be available, affects few users.

  
impact
unknown
Report was not yet triaged to assess impact.

  
Incompatible license

This pull request contains changes that are not (yet) compatible with the current Forgejo license

  
issue
closed
The issue was resolved in the repository of the dependency

  
issue
do-not-exist-yet
An issue should be created in the respository of the dependency

  
issue
open
An open issue exists in the upstream repository of the dependency

  
manual test

Pull requests that have been merged with a manual test

Archived

  
Manually tested during feature freeze

The manual test instructions were followed

  
OS
FreeBSD
Specific to the FreeBSD Operating System

  
OS
Linux
Specific to (GNU/)Linux Operating Systems

  
OS
macOS
Specific to the MacOS Operating System

  
OS
Windows
Specific to the Windows Operating System

  
problem

A user report about a problem. Needs to be triaged to find potential solutions.

  
QA

   
regression

found in the version of the milestone and not before

  
release blocker

Issues that must be fixed before the release can be published

  
Release Cycle
Feature Freeze
Only bug fixes with automated tests (except for CSS/JavaScript)

  
release-blocker
v7.0
Issues that must be fixed before Forgejo v7.0 can be released 17 April 2024

Archived

  
release-blocker
v7.0.1
Issues that must be fixed before Forgejo v7.0.1 can be released

Archived

  
release-blocker
v7.0.2
Issues that must be fixed before Forgejo v7.0.2 can be released

Archived

  
release-blocker
v7.0.3
Issues that must be fixed before Forgejo v7.0.3 can be released

Archived

  
release-blocker
v7.0.4
Issues that must be fixed before Forgejo v7.0.4 can be released

Archived

  
release-blocker
v8.0.0
Issues that must be fixed before Forgejo v8.0.0 can be released

Archived

  
release-blocker/v9.0.0

Issues that must be fixed before Forgejo v9.0.0 can be released

Archived

  
run-all-playwright-tests

Add this label to a PR to run all playwright tests manually.

  
run-end-to-end-tests

Trigger additional tests on the PR when it is ready to be merged

  
test
manual
manual testing has been documented

  
test
needed
test should be added

  
test
needs-help
help needed to add a test

  
test
not-needed
no additional test is needed

  
test
present
test has been added

  
untested

Pull requests that have been merged with no test and submitted as is to the dependency where they belong

Archived

  
User research - time-tracker

Time tracking feature for issues and the JS stopwatch.

  
valuable code

This PR was closed because the implementation is incomplete

  
worth a release-note

Add this PR to the release notes

  
User research - Accessibility

Requires input about accessibility features, likely involves user testing.

  
User research - Blocked

Do not pick as-is! We are happy if you can help, but please coordinate with ongoing redesign in this area.

  
User research - Community

Community features, such as discovering other people's work or otherwise feeling welcome on a Forgejo instance.

  
User research - Config (instance)

Instance-wide configuration, authentication and other admin-only needs.

  
User research - Errors

How to deal with errors in the application and write helpful error messages.

  
User research - Filters

How filter and search is being worked with.

  
User research - Future backlog

The issue might be inspiring for future design work.

  
User research - Git workflow

AGit, fork-based and new Git workflow, PR creation etc

  
User research - Labels

Active research about Labels

  
User research - Moderation

Moderation Featuers for Admins are undergoing active User Research

  
User research - Needs input

Use this label to let the User Research team know their input is requested.

  
User research - Notifications/Dashboard

Research on how users should know what to do next.

  
User research - Rendering

Text rendering, markup languages etc

  
User research - Repo creation

Active research about the New Repo dialog.

  
User research - Repo units

The repo sections, disabling them and the "Add more" button.

  
User research - Security

   
User research - Settings (in-app)

How to structure in-app settings in the future?

No labels
arch
riscv64
backport/v1.19
backport/v1.20
backport/v1.21/forgejo
backport/v10.0/forgejo
backport/v11.0/forgejo
backport/v12.0/forgejo
backport/v13.0/forgejo
backport/v14.0/forgejo
backport/v15.0/forgejo
backport/v7.0/forgejo
backport/v8.0/forgejo
backport/v9.0/forgejo
breaking
bug
bug
confirmed
bug
duplicate
bug
needs-more-info
bug
new-report
bug
reported-upstream
code/actions
code/api
code/auth
code/auth/faidp
code/auth/farp
code/email
code/federation
code/git
code/migrations
code/packages
code/wiki
database
MySQL
database
PostgreSQL
database
SQLite
dependency-upgrade
dependency
certmagic
dependency
chart.js
dependency
Chi
dependency
Chroma
dependency
citation.js
dependency
codespell
dependency
css-loader
dependency
devcontainers
dependency
dropzone
dependency
editorconfig-checker
dependency
elasticsearch
dependency
enmime
dependency
F3
dependency
ForgeFed
dependency
garage
dependency
Git
dependency
git-backporting
dependency
Gitea
dependency
gitignore
dependency
go-ap
dependency
go-enry
dependency
go-gitlab
dependency
Go-org
dependency
go-rpmutils
dependency
go-sql-driver mysql
dependency
go-swagger
dependency
go-version
dependency
go-webauthn
dependency
gocron
dependency
Golang
dependency
goldmark
dependency
goquery
dependency
Goth
dependency
grpc-go
dependency
happy-dom
dependency
Helm
dependency
image-spec
dependency
jsonschema
dependency
KaTeX
dependency
lint
dependency
MariaDB
dependency
Mermaid
dependency
minio-go
dependency
misspell
dependency
Monaco
dependency
PDFobject
dependency
playwright
dependency
postcss
dependency
postcss-plugins
dependency
pprof
dependency
prometheus client_golang
dependency
protobuf
dependency
relative-time-element
dependency
renovate
dependency
reply
dependency
ssh
dependency
swagger-ui
dependency
tailwind
dependency
temporal-polyfill
dependency
terminal-to-html
dependency
tests-only
dependency
text-expander-element
dependency
urfave
dependency
vfsgen
dependency
vite
dependency
Woodpecker CI
dependency
x tools
dependency
XORM
Discussion
duplicate
enhancement/feature
forgejo/accessibility
forgejo/branding
forgejo/ci
forgejo/commit-graph
forgejo/documentation
forgejo/furnace cleanup
forgejo/i18n
forgejo/interop
forgejo/moderation
forgejo/privacy
forgejo/release
forgejo/scaling
forgejo/security
forgejo/ui
Gain
High
Gain
Nice to have
Gain
Undefined
Gain
Very High
good first issue
i18n/backport-stable
impact
large
impact
medium
impact
small
impact
unknown
Incompatible license
issue
closed
issue
do-not-exist-yet
issue
open
manual test
Manually tested during feature freeze
OS
FreeBSD
OS
Linux
OS
macOS
OS
Windows
problem
QA
regression
release blocker
Release Cycle
Feature Freeze
release-blocker
v7.0
release-blocker
v7.0.1
release-blocker
v7.0.2
release-blocker
v7.0.3
release-blocker
v7.0.4
release-blocker
v8.0.0
release-blocker/v9.0.0
run-all-playwright-tests
run-end-to-end-tests
test
manual
test
needed
test
needs-help
test
not-needed
test
present
untested
User research - time-tracker
valuable code
worth a release-note
User research - Accessibility
User research - Blocked
User research - Community
User research - Config (instance)
User research - Errors
User research - Filters
User research - Future backlog
User research - Git workflow
User research - Labels
User research - Moderation
User research - Needs input
User research - Notifications/Dashboard
User research - Rendering
User research - Repo creation
User research - Repo units
User research - Security
User research - Settings (in-app)
Milestone
Clear milestone
No items
No milestone
Forgejo v11.0.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo/forgejo!6300
No description provided.