forgejo/forgejo

Fork 696

bug: the edit runner page no longer show the list of jobs #7643

New issue

Closed

opened 2025-04-25 01:26:42 +02:00 by earl-warren · 4 comments

earl-warren commented

2025-04-25 01:26:42 +02:00

Contributor

Can you reproduce the bug on the Forgejo test instance?

Yes

Description

Visit /admin/actions/runners/NN for an existing runner which had some runs already. See the list is empty.

Screenshots

On https://v10.next.forgejo.org the list shows something like

Forgejo Version

v11.0 and above

Browser Version

any

### Can you reproduce the bug on the Forgejo test instance? Yes ### Description Visit `/admin/actions/runners/NN` for an existing runner which had some runs already. See the list is empty. ### Screenshots ![image](/attachments/570e49df-4f28-458b-bd8e-a227c38a6921) On https://v10.next.forgejo.org the list shows something like ![image](/attachments/173b7f12-6cf6-4ffc-ad4c-27cc93897e91) ### Forgejo Version v11.0 and above ### Browser Version any

image.png

29 KiB

image.png

33 KiB

earl-warren added the

forgejo/ui

code/actions

labels

2025-04-25 01:26:42 +02:00

earl-warren self-assigned this

2025-04-25 01:26:58 +02:00

earl-warren removed their assignment

2025-04-25 01:26:59 +02:00

earl-warren added the

bug

confirmed

label

2025-04-25 01:27:08 +02:00

earl-warren commented

2025-04-25 01:27:47 +02:00

Author

Contributor

@cobak78 I think this is a regression introduced in #6300. Does that ring a bell?

@cobak78 I think this is a regression introduced in https://codeberg.org/forgejo/forgejo/pulls/6300. Does that ring a bell?

earl-warren added the

regression

label

2025-04-25 01:27:59 +02:00

earl-warren commented

2025-04-25 08:56:30 +02:00

Author

Contributor

The fix is trivial, what is lacking is a test covering that part.

modified   routers/web/shared/actions/runners.go
@@ -79,7 +79,6 @@ func RunnerDetails(ctx *context.Context, page int, runnerID, ownerID, repoID int
 			Page:     page,
 			PageSize: 30,
 		},
-		Status:   []actions_model.Status{actions_model.StatusUnknown}, // Unknown means all
 		RunnerID: runner.ID,
 	}

The fix is trivial, what is lacking is a test covering that part. ```diff modified routers/web/shared/actions/runners.go @@ -79,7 +79,6 @@ func RunnerDetails(ctx *context.Context, page int, runnerID, ownerID, repoID int Page: page, PageSize: 30, }, - Status: []actions_model.Status{actions_model.StatusUnknown}, // Unknown means all RunnerID: runner.ID, } ```

earl-warren referenced this issue

2025-04-25 09:16:29 +02:00

Add search action jobs for API routes, repo, org and global level #6300

cobak78 commented

2025-04-25 11:34:52 +02:00

Member

you are right, that function should return all of them so that means the comment about the unknown status is incorrect.
As long as the test for the filtered jobs pass that fix does not break the endpoints I introduced.

you are right, that function should return all of them so that means the comment about the unknown status is incorrect. As long as the test for the filtered jobs pass that fix does not break the endpoints I introduced.

👍 1

earl-warren referenced this issue from a commit

2025-04-25 11:42:16 +02:00

fix: display the list of tasks in the runner edit page

earl-warren referenced this issue

2025-04-25 11:45:15 +02:00

fix: display the list of tasks in the runner edit page #7650

earl-warren referenced this issue from a commit

2025-04-25 11:50:03 +02:00

fix: display the list of tasks in the runner edit page

earl-warren referenced this issue from a commit

2025-04-25 11:54:45 +02:00

fix: display the list of tasks in the runner edit page

earl-warren commented

2025-04-25 13:59:13 +02:00

Author

Contributor

It was correct before because 0 was the same as not specifying the field. But now that it is an array, that changed. This function is only ever used for displaying the task list in the admin page, there is very little room for undesirable side effects.

earl-warren referenced this issue from a commit

2025-04-25 14:00:02 +02:00

fix: display the list of tasks in the runner edit page (#7650)

earl-warren closed this issue

2025-04-25 14:00:07 +02:00