fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA by VietND96 · Pull Request #6368 · kedacore/keda

VietND96 · 2024-11-26T19:41:39Z

Provide a description of what has been changed

As KEDA exposes a metric to the HPA Controller, KEDA has to expose the raw value of the queue including all the jobs in-progress and pending, because it's the HPA controller the one which will calculate the right value based on the metric type (Value or AverageValue).

Selenium Grid scaler exposes the the sum of the in-progress sessions plus the pending sessions (after counting nodeMaxSessions to KEDA.

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes SeleniumHQ/docker-selenium#2464

Relates to #6331

rickbrouwer · 2024-11-26T20:09:18Z

I see you are using optional with a default value. I think if something has a default, optional does not need to be passed along. What do you think?

VietND96 · 2024-11-26T20:17:21Z

I am not aware on this. So, we can remove optional from all trigger params which has default value already?
If yes, I will proceed the clean up

rickbrouwer · 2024-11-26T20:31:02Z

I am not aware on this. So, we can remove optional from all trigger params which has default value already? If yes, I will proceed the clean up

Yes, because if it doesn't exist the value is set with the default.
Reference:

keda/pkg/scalers/scalersconfig/typed_config.go

Lines 198 to 201 in 29400ed

    
           if !exists && params.Default != "" { 
        
           	exists = true 
        
           	valFromConfig = params.Default 
        
           }

VietND96 · 2024-11-26T20:42:50Z

Thanks! I updated the same.

pkg/scalers/selenium_grid_scaler.go

… to KDEA Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

JorTurFer

Thanks a lot for this awesome fix! ❤️

JorTurFer · 2024-12-02T09:49:20Z

/run-e2e selenium
Update: You can check the progress here

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

JorTurFer · 2024-12-02T10:44:03Z

/run-e2e selenium
Update: You can check the progress here

wozniakjan

thank you!

… to KDEA (kedacore#6368)

… to KDEA (kedacore#6368) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix: CVE-2024-45337 (#6422) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * :fix: ensure consistent JSON log format for automaxprocs (#6335) * fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Upgrade to the latest new-relic-go v2 client (#6325) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * refactor: replace experimental `maps` and `slices` with stdlib (#6372) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA (#6368) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix: scaledjobs stuck as not ready (#6329) since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in #5916 Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix: Paused ScaledObject count is reported correctly after operator restart (#6322) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update changelog Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Bump go and deps (#6434) * Bump go and deps Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * bump golang.org/x/net Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Add missing permissions to code-scaners Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update release tracker Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix aws scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Pass theregion Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Pass theregion Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix aws tests Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix aws tests Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update AWS admission probes Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * commit last vendored deps Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: Selenium Grid in case multiple scaler triggers are activate (#6437) * fix: Selenium Grid scaler avoids overlapping when multiple browserVersion triggers are active Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Fix e2e template test Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Change imagePullPolicy to Always to take latest change Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update platformName default value as empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add missing change Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Omer Aplatony <omerap12@gmail.com> Co-authored-by: smcavallo <smcavallo@users.noreply.github.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Mårten Svantesson <marten.svantesson@ticket.se>

… to KDEA (kedacore#6368)

… to KDEA (kedacore#6368) Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>

VietND96 requested a review from a team as a code owner November 26, 2024 19:41

VietND96 force-pushed the main branch from 1386b4b to 477aa89 Compare November 26, 2024 19:42

VietND96 mentioned this pull request Nov 26, 2024

[🐛 Bug]: Issue with Scaling Already Scaled Deployments SeleniumHQ/docker-selenium#2464

Closed

VietND96 force-pushed the main branch from 477aa89 to 08ff129 Compare November 26, 2024 20:02

VietND96 mentioned this pull request Nov 26, 2024

Update docs for Selenium Grid Scaler kedacore/keda-docs#1504

Closed

1 task

VietND96 force-pushed the main branch from 94dd4a7 to f9f3d23 Compare December 1, 2024 18:43

VietND96 changed the title ~~fix: Condition of queueLength for Selenium Grid scaler will scale up~~ fix: Selenium Grid scaler exposes sum of pending and ongoing requests to KDEA Dec 1, 2024

VietND96 changed the title ~~fix: Selenium Grid scaler exposes sum of pending and ongoing requests to KDEA~~ fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA Dec 1, 2024

VietND96 force-pushed the main branch from f9f3d23 to 57c3025 Compare December 1, 2024 19:04

JorTurFer reviewed Dec 2, 2024

View reviewed changes

pkg/scalers/selenium_grid_scaler.go Outdated Show resolved Hide resolved

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions…

dcdb283

… to KDEA Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

VietND96 force-pushed the main branch from 57c3025 to dcdb283 Compare December 2, 2024 09:41

JorTurFer approved these changes Dec 2, 2024

View reviewed changes

Update CHANGELOG

9e6e5c3

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

JorTurFer approved these changes Dec 2, 2024

View reviewed changes

JorTurFer enabled auto-merge (squash) December 2, 2024 10:44

wozniakjan approved these changes Dec 4, 2024

View reviewed changes

JorTurFer merged commit c43af59 into kedacore:main Dec 4, 2024

ctccxxd pushed a commit to ctccxxd/keda that referenced this pull request Dec 10, 2024

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions…

ee4fa22

… to KDEA (kedacore#6368)

JorTurFer mentioned this pull request Dec 22, 2024

Release: 2.16.1 #6435

Closed

24 tasks

JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Dec 22, 2024

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions…

ec46d55

… to KDEA (kedacore#6368)

JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Dec 22, 2024

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions…

b10caf1

… to KDEA (kedacore#6368) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

rickbrouwer pushed a commit to rickbrouwer/keda that referenced this pull request Jan 2, 2025

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions…

27706de

… to KDEA (kedacore#6368)

chiragbhatia8 pushed a commit to chiragbhatia8/keda that referenced this pull request Jan 9, 2025

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions…

e0e5490

… to KDEA (kedacore#6368) Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA#6368

fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA#6368
JorTurFer merged 2 commits intokedacore:mainfrom
NDViet:main

VietND96 commented Nov 26, 2024 •

edited

Loading

Uh oh!

rickbrouwer commented Nov 26, 2024 •

edited

Loading

Uh oh!

VietND96 commented Nov 26, 2024

Uh oh!

rickbrouwer commented Nov 26, 2024

Uh oh!

VietND96 commented Nov 26, 2024

Uh oh!

Uh oh!

JorTurFer left a comment

Uh oh!

JorTurFer commented Dec 2, 2024 •

edited by github-actions bot

Loading

Uh oh!

JorTurFer commented Dec 2, 2024 •

edited by github-actions bot

Loading

Uh oh!

wozniakjan left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

VietND96 commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

rickbrouwer commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

VietND96 commented Nov 26, 2024

Uh oh!

rickbrouwer commented Nov 26, 2024

Uh oh!

VietND96 commented Nov 26, 2024

Uh oh!

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

JorTurFer commented Dec 2, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JorTurFer commented Dec 2, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VietND96 commented Nov 26, 2024 •

edited

Loading

rickbrouwer commented Nov 26, 2024 •

edited

Loading

JorTurFer commented Dec 2, 2024 •

edited by github-actions bot

Loading

JorTurFer commented Dec 2, 2024 •

edited by github-actions bot

Loading