fix: ensure consistent JSON log format for automaxprocs by omerap12 · Pull Request #6335 · kedacore/keda

omerap12 · 2024-11-15T18:42:56Z

Configures automaxprocs to use the application logger instead of default console logging to maintain consistent JSON format across all log output.
output:

keda-admission-webhooks:
 ~/ k logs deployments.apps/keda-admission-webhooks -n keda
2024-11-15T18:39:05Z	INFO	setup	maxprocs: Updating GOMAXPROCS=1: determined from CPU quota	{"system": "automaxprocs"}
2024-11-15T18:39:05Z	INFO	setup	Starting admission webhooks
2024-11-15T18:39:05Z	INFO	setup	KEDA Version: main
2024-11-15T18:39:05Z	INFO	setup	Git Commit: c2a6df04230e1f62d335127e0a02694015c79fa6
2024-11-15T18:39:05Z	INFO	setup	Go Version: go1.23.3
2024-11-15T18:39:05Z	INFO	setup	Go OS/Arch: linux/arm64
2024-11-15T18:39:05Z	INFO	setup	Running on Kubernetes 1.30	{"version": "v1.30.0"}
2024-11-15T18:39:05Z	INFO	controller-runtime.builder	skip registering a mutating webhook, object does not implement admission.Defaulter or WithDefaulter wasn't called	{"GVK": "keda.sh/v1alpha1, Kind=ScaledObject"}

keda-operator:

 ~/ k logs deployment/keda-operator -n keda
2024-11-15T18:39:00Z	INFO	setup	maxprocs: Updating GOMAXPROCS=1: determined from CPU quota	{"system": "automaxprocs"}
2024-11-15T18:39:00Z	INFO	setup	Starting manager
2024-11-15T18:39:00Z	INFO	setup	KEDA Version: main
2024-11-15T18:39:00Z	INFO	setup	Git Commit: c2a6df04230e1f62d335127e0a02694015c79fa6
2024-11-15T18:39:00Z	INFO	setup	Go Version: go1.23.3
2024-11-15T18:39:00Z	INFO	setup	Go OS/Arch: linux/arm64
2024-11-15T18:39:00Z	INFO	setup	Running on Kubernetes 1.30	{"version": "v1.30.0"}
2024-11-15T18:39:01Z	INFO	starting server	{"name": "health probe", "addr": "[::]:8081"}
I1115 18:39:01.071646       1 leaderelection.go:254] attempting to acquire leader lease keda/operator.keda.sh...
I1115 18:39:39.767722       1 leaderelection.go:268] successfully acquired lease keda/operator.keda.sh

keda-operator-metrics-apiserver:

 ~/ k logs deployments.apps/keda-operator-metrics-apiserver -n keda                       
I1115 18:38:55.350590       1 welcome.go:34] "msg"="Starting metrics server" "logger"="keda_metrics_adapter"
I1115 18:38:55.350752       1 welcome.go:35] "msg"="KEDA Version: main" "logger"="keda_metrics_adapter"
I1115 18:38:55.350756       1 welcome.go:36] "msg"="Git Commit: c2a6df04230e1f62d335127e0a02694015c79fa6" "logger"="keda_metrics_adapter"
I1115 18:38:55.350759       1 welcome.go:37] "msg"="Go Version: go1.23.3" "logger"="keda_metrics_adapter"
I1115 18:38:55.350761       1 welcome.go:38] "msg"="Go OS/Arch: linux/arm64" "logger"="keda_metrics_adapter"
I1115 18:38:55.350775       1 welcome.go:39] "msg"="Running on Kubernetes 1.30" "logger"="keda_metrics_adapter" "version"={"major":"1","minor":"30","gitVersion":"v1.30.0","gitCommit":"7c48c2bd72b9bf5c44d21d7338cc7bea77d0ad2a","gitTreeState":"clean","buildDate":"2024-05-13T22:02:25Z","goVersion":"go1.22.2","compiler":"gc","platform":"linux/arm64"}
I1115 18:38:55.350913       1 main.go:263] "msg"="maxprocs: Updating GOMAXPROCS=1: determined from CPU quota" "logger"="keda_metrics_adapter"
I1115 18:38:55.351645       1 main.go:112] "msg"="Connecting Metrics Service gRPC client to the server" "address"="keda-operator.keda.svc.cluster.local:9666" "logger"="keda_metrics_adapter"

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5970

zroubalik

Thanks, this is great!

Could you please define this in a single place and just reference in each component? The best place is probably a new file in https://github.com/kedacore/keda/tree/main/pkg/util

omerap12 · 2024-11-19T09:20:48Z

Thanks, this is great!

Could you please define this in a single place and just reference in each component? The best place is probably a new file in https://github.com/kedacore/keda/tree/main/pkg/util

fixed :)

zroubalik · 2024-11-19T12:21:36Z

/run-e2e internal
Update: You can check the progress here

zroubalik · 2024-11-19T12:22:29Z

@omerap12 could you please also update Changelog? https://github.com/kedacore/keda/blob/main/CHANGELOG.md#improvements-1

omerap12 · 2024-11-19T12:29:41Z

@omerap12 could you please also update Changelog? https://github.com/kedacore/keda/blob/main/CHANGELOG.md#improvements-1

Done

cmd/adapter/main.go

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

wozniakjan · 2024-11-19T14:36:03Z

/run-e2e internal
Update: You can check the progress here

omerap12 · 2024-11-20T15:09:49Z

/run-e2e internal Update: You can check the progress here

Passed. can we merge it? :)

JorTurFer

LGTM! Could you move the changelog entry to the unreleased section? after the release it was moved to v2.16 and should be unreleased yet

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 · 2024-11-21T07:49:06Z

LGTM! Could you move the changelog entry to the unreleased section? after the release it was moved to v2.16 and should be unreleased yet

hope I did it right this time lol

wozniakjan · 2024-11-21T08:40:55Z

/skip-e2e
(last commit is just CHANGELOG.md change, previous commit e2e tests passed)

* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: michael pechner <mike.pechner@akasa.com>

* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* fix: CVE-2024-45337 (#6422) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * :fix: ensure consistent JSON log format for automaxprocs (#6335) * fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Upgrade to the latest new-relic-go v2 client (#6325) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * refactor: replace experimental `maps` and `slices` with stdlib (#6372) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix: Selenium Grid scaler exposes sum of pending and ongoing sessions to KDEA (#6368) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix: scaledjobs stuck as not ready (#6329) since code was missing for setting a scaledjob as ready it was stuck as unready if there ever was a problem This is a fix for a regression in #5916 Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix: Paused ScaledObject count is reported correctly after operator restart (#6322) Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update changelog Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Bump go and deps (#6434) * Bump go and deps Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * bump golang.org/x/net Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Add missing permissions to code-scaners Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * update release tracker Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix aws scaler Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Pass theregion Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Pass theregion Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix aws tests Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * fix aws tests Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * Update AWS admission probes Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * commit last vendored deps Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> * fix: Selenium Grid in case multiple scaler triggers are activate (#6437) * fix: Selenium Grid scaler avoids overlapping when multiple browserVersion triggers are active Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update CHANGELOG Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Fix e2e template test Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Change imagePullPolicy to Always to take latest change Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update platformName default value as empty Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> * add missing change Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> --------- Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es> Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Signed-off-by: Mårten Svantesson <Marten.Svantesson@ticket.se> Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl> Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Omer Aplatony <omerap12@gmail.com> Co-authored-by: smcavallo <smcavallo@users.noreply.github.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> Co-authored-by: Mårten Svantesson <marten.svantesson@ticket.se>

* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com>

* fix: ensure consistent JSON log format for automaxprocs Signed-off-by: Omer Aplatony <omerap12@gmail.com> * moved to Unreleased Signed-off-by: Omer Aplatony <omerap12@gmail.com> --------- Signed-off-by: Omer Aplatony <omerap12@gmail.com> Signed-off-by: Chirag Bhatia <chiragbhatia8@gmail.com>

omerap12 requested a review from a team as a code owner November 15, 2024 18:42

zroubalik reviewed Nov 18, 2024

View reviewed changes

omerap12 force-pushed the issue-5970 branch from 0f95de7 to 49e5e8f Compare November 19, 2024 09:20

omerap12 requested a review from zroubalik November 19, 2024 09:20

omerap12 force-pushed the issue-5970 branch from 49e5e8f to 416db72 Compare November 19, 2024 09:52

zroubalik approved these changes Nov 19, 2024

View reviewed changes

omerap12 force-pushed the issue-5970 branch from 416db72 to 88fcf63 Compare November 19, 2024 12:29

omerap12 requested a review from zroubalik November 19, 2024 12:29

wozniakjan reviewed Nov 19, 2024

View reviewed changes

cmd/adapter/main.go Show resolved Hide resolved

fix: ensure consistent JSON log format for automaxprocs

0a1d8be

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

omerap12 force-pushed the issue-5970 branch from 88fcf63 to 0a1d8be Compare November 19, 2024 12:44

wozniakjan approved these changes Nov 19, 2024

View reviewed changes

JorTurFer reviewed Nov 20, 2024

View reviewed changes

moved to Unreleased

c1934bb

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

wozniakjan enabled auto-merge (squash) November 21, 2024 08:39

keda-automation added the skip-e2e label Nov 21, 2024

wozniakjan merged commit 8b4ccdb into kedacore:main Nov 21, 2024

JorTurFer mentioned this pull request Dec 22, 2024

Release: 2.16.1 #6435

Closed

24 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: ensure consistent JSON log format for automaxprocs#6335

fix: ensure consistent JSON log format for automaxprocs#6335
wozniakjan merged 2 commits intokedacore:mainfrom
omerap12:issue-5970

omerap12 commented Nov 15, 2024 •

edited by wozniakjan

Loading

Uh oh!

zroubalik left a comment

Uh oh!

omerap12 commented Nov 19, 2024

Uh oh!

zroubalik commented Nov 19, 2024 •

edited by github-actions bot

Loading

Uh oh!

zroubalik commented Nov 19, 2024

Uh oh!

omerap12 commented Nov 19, 2024

Uh oh!

Uh oh!

wozniakjan commented Nov 19, 2024 •

edited by github-actions bot

Loading

Uh oh!

omerap12 commented Nov 20, 2024

Uh oh!

JorTurFer left a comment

Uh oh!

omerap12 commented Nov 21, 2024 •

edited

Loading

Uh oh!

wozniakjan commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

omerap12 commented Nov 15, 2024 • edited by wozniakjan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

zroubalik left a comment

Choose a reason for hiding this comment

Uh oh!

omerap12 commented Nov 19, 2024

Uh oh!

zroubalik commented Nov 19, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zroubalik commented Nov 19, 2024

Uh oh!

omerap12 commented Nov 19, 2024

Uh oh!

Uh oh!

wozniakjan commented Nov 19, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

omerap12 commented Nov 20, 2024

Uh oh!

JorTurFer left a comment

Choose a reason for hiding this comment

Uh oh!

omerap12 commented Nov 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wozniakjan commented Nov 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

omerap12 commented Nov 15, 2024 •

edited by wozniakjan

Loading

zroubalik commented Nov 19, 2024 •

edited by github-actions bot

Loading

wozniakjan commented Nov 19, 2024 •

edited by github-actions bot

Loading

omerap12 commented Nov 21, 2024 •

edited

Loading