Skip to content

Refactor IBM MQ scaler and remove and deprecate variables#6034

Merged
JorTurFer merged 2 commits intokedacore:mainfrom
rickbrouwer:main
Aug 20, 2024
Merged

Refactor IBM MQ scaler and remove and deprecate variables#6034
JorTurFer merged 2 commits intokedacore:mainfrom
rickbrouwer:main

Conversation

@rickbrouwer
Copy link
Member

@rickbrouwer rickbrouwer commented Aug 5, 2024 •
edited
Loading

  • The queueManager parameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code is removed.
  • The parameter tlsDisabled (as mentioned in the documentation) / tls (as mentioned in the code) will be announced as being deprecated in a further release. All other scalers use the parameter unsafeSsl. To maintain consistency between other scalers, we are making changes, as unsafeSsl already handles this functionality. tls will still be supported. When both variables are filled in, an error message is logged and returned. If only tls is filled in, its value will be assigned to unsafeSsl. A deprecation info message will be logged. My proposal is to tag the tls parameter with deprecated=use unsafeSsl instead in version 2.18 and remove the deprecated code.
  • Refactor the scaler to match the new metadata guidelines.

Checklist

Fixes #6033
Docs: 1445
Related: 5797

@rickbrouwer rickbrouwer requested a review from a team as a code owner August 5, 2024 09:52
@rickbrouwer rickbrouwer force-pushed the main branch 2 times, most recently from a1db827 to 3e31a12 Compare August 5, 2024 10:13
@rickbrouwer rickbrouwer mentioned this pull request Aug 5, 2024
Merged
1 task
@JorTurFer
Copy link
Member

JorTurFer commented Aug 5, 2024 •
edited
Loading

Hello
Thanks for the improvement! We can remove unused parameters but we can't remove the used ones without following the deprecation policy
To remove the parameter tls we have to support it + the new one, printing a deprecation warning when it's used (+ the deprecation announce, etc...).

Could you update the PR to align it with our deprecation policy? I think that unifying is always better

@wozniakjan
Copy link
Member

wozniakjan commented Aug 5, 2024

would it be possible to also refactor the scaler to match the new metadata guidelines as outlined by #5797 and #5676? No worries if not, just thought it might make sense to do that if it doesn't bring too much trouble.

@rickbrouwer rickbrouwer marked this pull request as draft August 5, 2024 18:50
@rickbrouwer rickbrouwer force-pushed the main branch 20 times, most recently from 82f5b89 to 995b612 Compare August 8, 2024 15:37
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Aug 9, 2024

would it be possible to also refactor the scaler to match the new metadata guidelines as outlined by #5797 and #5676? No worries if not, just thought it might make sense to do that if it doesn't bring too much trouble.

I think that is possible. I will work on it and get back to you as soon as possible.

@rickbrouwer rickbrouwer changed the title refactor: Remove unused variables in IBM MQ scaler Refactor IBM MQ scaler and remove and deprecate variables Aug 12, 2024
@rickbrouwer rickbrouwer marked this pull request as ready for review August 13, 2024 06:38
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Aug 13, 2024

Hello Thanks for the improvement! We can remove unused parameters but we can't remove the used ones without following the deprecation policy To remove the parameter tls we have to support it + the new one, printing a deprecation warning when it's used (+ the deprecation announce, etc...).

Could you update the PR to align it with our deprecation policy? I think that unifying is always better

Thanks. You are absolutely right! I have updated the PR. tls will still be supported now. When tls is filled in, a deprecation info message will be logged. My proposal is to tag the tls parameter with deprecated=use unsafeSsl instead (according to the new metadata guidelines) and remove the deprecated code in version 2.17. What do you think?

@rickbrouwer rickbrouwer force-pushed the main branch 3 times, most recently from a61368f to c1d94ce Compare August 13, 2024 08:31
wozniakjan
wozniakjan approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@wozniakjan wozniakjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes for IBM scaler look really good!

ptal @JorTurFer

@rickbrouwer rickbrouwer force-pushed the main branch 3 times, most recently from d8611d8 to cc3aae8 Compare August 16, 2024 13:48
@dttung2905 dttung2905 mentioned this pull request Aug 18, 2024
Open
58 tasks
@wozniakjan
Copy link
Member

wozniakjan commented Aug 19, 2024

ptal @kedacore/keda-core-contributors, I think this should be good to merge

@rickbrouwer rickbrouwer marked this pull request as draft August 19, 2024 14:41
@rickbrouwer
Copy link
Member Author

rickbrouwer commented Aug 19, 2024

ptal @kedacore/keda-core-contributors, I think this should be good to merge

I forgot the usernameFromEnv and the passwordFromEnv. I will fix this tomorrow.

JorTurFer
JorTurFer reviewed Aug 19, 2024
View reviewed changes
@JorTurFer
Copy link
Member

JorTurFer commented Aug 19, 2024

LGTM, just an small nit

JorTurFer
JorTurFer reviewed Aug 19, 2024
View reviewed changes
@rickbrouwer rickbrouwer marked this pull request as ready for review August 20, 2024 08:48
@rickbrouwer
refactor: Remove and deprecate unused variables in IBM MQ scaler
ba7fa8b 
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
JorTurFer
JorTurFer approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@JorTurFer
Copy link
Member

JorTurFer commented Aug 20, 2024 •
edited by github-actions bot
Loading

/run-e2e ibm
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 03041f4 into kedacore:main Aug 20, 2024
@JorTurFer JorTurFer mentioned this pull request Aug 20, 2024
Closed
fira42073 pushed a commit to fira42073/keda that referenced this pull request Aug 25, 2024
@rickbrouwer @fira42073
Refactor IBM MQ scaler and remove and deprecate variables (kedacore#6034
9c08822 
)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Fira Curie <fira42073@gmail.com>
JorTurFer pushed a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
@rickbrouwer @JorTurFer
Refactor IBM MQ scaler and remove and deprecate variables (kedacore#6034
81f8a1b 
)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
@rickbrouwer @mpechner-akasa
Refactor IBM MQ scaler and remove and deprecate variables (kedacore#6034
391840c 
)

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Signed-off-by: michael pechner <mike.pechner@akasa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zroubalik zroubalik zroubalik left review comments

@wozniakjan wozniakjan wozniakjan approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unused variables in IBM MQ scaler

4 participants

@rickbrouwer @JorTurFer @wozniakjan @zroubalik