Remove and deprecate unused variables and correct queueDepth default in IBM MQ scaler#1445
Merged
JorTurFer merged 3 commits intokedacore:mainfrom Aug 20, 2024
Merged
Remove and deprecate unused variables and correct queueDepth default in IBM MQ scaler#1445JorTurFer merged 3 commits intokedacore:mainfrom
JorTurFer merged 3 commits intokedacore:mainfrom
Conversation
|
Thank you for your contribution! 🙏 We will review your PR as soon as possible.
Learn more about:
|
5 tasks
✅ Deploy Preview for keda ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Member
|
Are all deprecated? I thought that only the tls one is deprecated |
JorTurFer
reviewed
Aug 19, 2024
JorTurFer
reviewed
Aug 19, 2024
Member
Author
Yes, sorry. My bad. I misunderstood something. I have changed it back. |
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: rickbrouwer <rickbrouwer@gmail.com>
JorTurFer
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queueDepthis5, while the code default is20. The documentation will be updated to reflect the correct default value of20, aligning it with the code.queueManagerparameter is currently checked to see if it's filled, but it's not used elsewhere in the code. This unused code is removed. The documentation is updated accordingly.tlsDisabledis set to DEPRECATED. All other scalers use the parameterunsafeSsl. To maintain consistency across the other scalers, the code related totlsDisabledis set to deprecated, asunsafeSslalready handles this functionality.Checklist
Related: 6034