Handle API lifecycle#62
Merged
Merged
Conversation
…esource On-behalf-of: @SAP christoph.mewes@sap.com
…VK anymore) On-behalf-of: @SAP christoph.mewes@sap.com
…on logic accessibility On-behalf-of: @SAP christoph.mewes@sap.com
…n reconciling APIExports On-behalf-of: @SAP christoph.mewes@sap.com
…local/remote GVKs On-behalf-of: @SAP christoph.mewes@sap.com
…ometimes?) On-behalf-of: @SAP christoph.mewes@sap.com
Since a CRD has a _list_ of versions, there is no risk of running into map collisions when renaming versions, so we can slim down our API to just a map, no individual steps. On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
…ier, adjust it to the new logic On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
On-behalf-of: @SAP christoph.mewes@sap.com
Member
|
/kind feature |
On-behalf-of: @SAP christoph.mewes@sap.com
Contributor
Author
|
/retest |
Contributor
|
LGTM label has been added. DetailsGit tree hash: 43dd2caa99d5854f9e30eeb8c48a6dcd462f2d0c |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the Agent's support for handling the lifecycle of CRDs. Notably, updates to CRDs are now reflected in kcp.
This PR started as #61, but then I noticed that even though APIConversions are a documented feature of kcp, they have in fact been entirely removed from kcp 2 years ago, except for their API types. So I forked #61 and trimmed it down to everything else.
This means even though the agent can now handle CRD updates and even multiple versions, there is absolutely no support whatsoever for conversions.
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #12
Release Notes