Skip to content

Handle API lifecycle, add support for APIConversions#61

Closed
xrstf wants to merge 22 commits into
mainfrom
add-apiconversions
Closed

Handle API lifecycle, add support for APIConversions#61
xrstf wants to merge 22 commits into
mainfrom
add-apiconversions

Conversation

@xrstf

@xrstf xrstf commented May 16, 2025

Copy link
Copy Markdown
Contributor

Summary

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #12

Release Notes

NONE

xrstf added 3 commits May 16, 2025 16:33
@xrstf
prepare to publish more than 1 version of a given GVK in a PublishedR…
2285d35 
…esource

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
codegen
1650e9d 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
refactor crd-puller to pull all versions (i.e. work on GK basis not G…
ce77504 
…VK anymore)

On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot

kcp-ci-bot commented May 16, 2025

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kcp-ci-bot kcp-ci-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels May 16, 2025
@kcp-ci-bot

kcp-ci-bot commented May 16, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xrstf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrstf xrstf changed the title Handle API lifecycle, add suppor for APIConversions Handle API lifecycle, add support for APIConversions May 16, 2025
@kcp-ci-bot kcp-ci-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2025
xrstf added 4 commits May 16, 2025 19:00
@xrstf
create new APIResourceSchemas when CRDs or PRs change, improve mutati…
3c7647a 
…on logic accessibility

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
correctly merge and update existing ResourceSchemas with new ones whe…
a8bb1e8 
…n reconciling APIExports

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
update remaining controllers to perform the new routine to determine …
382725f 
…local/remote GVKs

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
fix discovery of built-in resources (oh Kubernetes, why u like this s…
4eb8c44 
…ometimes?)

On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2025
@xrstf
lint
4fd3f75 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf

xrstf commented May 16, 2025

Copy link
Copy Markdown
Contributor Author

/test all

xrstf added 7 commits May 16, 2025 20:53
@xrstf
add API conversion to PublishedResources
f332be3 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
codegen
193da9a 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
add reconciling config for APIConversions
d0d8c1f 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
codegen
3acf0d1 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
simplify projecting versions
3640fe5 
Since a CRD has a _list_ of versions, there is no risk of running into map collisions when renaming
versions, so we can slim down our API to just a map, no individual steps.

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
codegen
50e77d1 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
add logic to apiresourceschema ctrl to maintain a matching APIConvers…
92d0af9 
…ion object in kcp

On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 16, 2025
@xrstf

xrstf commented May 16, 2025

Copy link
Copy Markdown
Contributor Author

/test all

@xrstf
add discovery e2e tests
589d829 
On-behalf-of: @SAP christoph.mewes@sap.com
xrstf added 6 commits May 20, 2025 16:47
@xrstf
add more unit tests for CRD projections
7bf4455 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
test conversion rule projection
f03b863 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
add more e2e tests for the APIExport controller
dfccf04 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
fix: make apiresourceschema controller watch for CRD changes
14023e1 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
make selecting ARS easier by labelling them with the agent name
e911d9b 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
this test obviously failed since we fixed the CRD watching issue earl…
5f5c89d 
…ier, adjust it to the new logic

On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf

xrstf commented May 20, 2025

Copy link
Copy Markdown
Contributor Author

/test all

@kcp-ci-bot

kcp-ci-bot commented May 20, 2025

Copy link
Copy Markdown
Contributor

@xrstf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-api-syncagent-verify 5f5c89d link true /test pull-api-syncagent-verify

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xrstf

xrstf commented May 21, 2025

Copy link
Copy Markdown
Contributor Author

Superseded by #62, which is the same as this but without all the APIConversion stuff.

@xrstf xrstf closed this May 21, 2025
@xrstf xrstf mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature: actively manage lifecycle of resource schemas

2 participants

@xrstf @kcp-ci-bot