fix(vcpkg-ports): enable thread_system integration in logger_system port#572
Merged
Conversation
Remove the LOGGER_USE_THREAD_SYSTEM=OFF workaround that was disabling thread_system integration due to previously unresolved externals for thread_pool symbols. The upstream logger_system CMake now correctly handles IMPORTED targets: - Detects vcpkg-installed thread_system as IMPORTED - Links it PUBLIC so symbols propagate through the export set - Config template calls find_dependency(thread_system CONFIG REQUIRED) Add kcenon-thread-system as a runtime dependency in the port vcpkg.json so vcpkg installs it before building logger_system. Closes kcenon/logger_system#507
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…A512 (#514) Update the vcpkg overlay port for kcenon/thread_system: - REF: commit SHA 80242646 → annotated tag v0.3.0 - SHA512: placeholder '0' → actual archive hash The v0.3.0 tag was created in kcenon/thread_system after merging: - #571: fix(build) link common_system target for vcpkg find_package - #572: chore(release) bump version to 0.3.0 SHA512 was computed from the GitHub-generated source archive: https://github.com/kcenon/thread_system/archive/refs/tags/v0.3.0.tar.gz Resolves: kcenon/thread_system#570
kcenon
added a commit
that referenced
this pull request
Apr 13, 2026
…ort (#572) Remove the LOGGER_USE_THREAD_SYSTEM=OFF workaround that was disabling thread_system integration due to previously unresolved externals for thread_pool symbols. The upstream logger_system CMake now correctly handles IMPORTED targets: - Detects vcpkg-installed thread_system as IMPORTED - Links it PUBLIC so symbols propagate through the export set - Config template calls find_dependency(thread_system CONFIG REQUIRED) Add kcenon-thread-system as a runtime dependency in the port vcpkg.json so vcpkg installs it before building logger_system. Closes kcenon/logger_system#507
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Summary
Enable
LOGGER_USE_THREAD_SYSTEM=ONin thekcenon-logger-systemoverlay port and addkcenon-thread-systemas a runtime dependency. Removes the-DLOGGER_USE_THREAD_SYSTEM=OFFworkaround that was disabling thread_system integration.Change Type
Why
Related Issues
Motivation
The portfile previously forced
LOGGER_USE_THREAD_SYSTEM=OFFas a workaround for unresolved externals when linking thread_pool symbols. Since then, both logger_system and thread_system have undergone CMake improvements:find_dependency(thread_system CONFIG REQUIRED)With thread_system disabled, vcpkg consumers miss the optimized thread pool (work stealing, lock-free queues) for async log dispatch, falling back to a standalone
std::jthread-based executor.Where
Files Changed
vcpkg-ports/kcenon-logger-system/vcpkg.jsonkcenon-thread-systemto dependenciesvcpkg-ports/kcenon-logger-system/portfile.cmakeLOGGER_USE_THREAD_SYSTEMfrom OFF to ONHow
Implementation
"kcenon-thread-system"to the port'sdependenciesarray-DLOGGER_USE_THREAD_SYSTEM=OFFto-DLOGGER_USE_THREAD_SYSTEM=ONTest Plan
vcpkg install kcenon-logger-systemwith overlay ports should build successfully with thread_system linkedfind_package(logger_system CONFIG)should resolvethread_systemas a transitive dependencyLoggerSystem_USE_THREAD_SYSTEMshould beONin the installed config